You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-11] [Due for payment 2026-05-07] [$250] Expensify Card - After clicking View transactions, Workspaces tab resets to initial page #89009
Version Number: 9.3.62-12 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#85234 Email or phone of affected tester (no customers):applausetester+khcategory20@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Workspace is set up with Expensify card feature.
Assign a virtual card to any member.
Go to staging.new.expensify.com
Go to workspace settings > Expensify Card.
Click on any card.
Click View transactions.
Click Workspaces tab.
Expected Result:
Workspaces tab will open workspace settings > Expensify Card where it was left off.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Problem: When navigating from Workspace > Expensify Card > Card Details > "View transactions" and then clicking the Workspaces tab, the workspace navigation resets to the list page instead of returning to the Expensify Card settings page.
Root Cause: When "View transactions" is clicked from the card details RHP, linkTo sees the current top route is RIGHT_MODAL_NAVIGATOR (not TAB_NAVIGATOR) and force-PUSHes a newTAB_NAVIGATOR instance onto the root stack. This creates two TAB_NAVIGATOR instances: the original (with workspace state) and a new one (focused on Search, with no workspace state).
When the user then clicks the Workspaces tab, useRestoreWorkspacesTabOnNavigate uses findLast to look at only the newestTAB_NAVIGATOR — which has no workspace state. The session storage fallback is a no-op on native, so lastWorkspacesTabNavigatorRoute is undefined, causing navigateToWorkspacesPage to default to the workspace list.
Solution: Fix useRestoreWorkspacesTabOnNavigate to search allTAB_NAVIGATOR instances for workspace state (not just the newest one). When the newest TAB_NAVIGATOR has no workspace state, fall back to checking older TAB_NAVIGATOR instances in the root stack before defaulting to the workspace list.
Specifically, in useRestoreWorkspacesTabOnNavigate.ts, change the lookup to iterate through all TAB_NAVIGATOR routes (from newest to oldest) until one with workspace state is found:
Additionally, navigateToWorkspacesPage should restore deeper workspace sub-page state (not just WORKSPACE_INITIAL) when the workspace navigator route has nested state available.
Investigation details
Navigation flow that triggers the bug:
User is on Workspace > Expensify Card settings. Root stack: [TAB_NAVIGATOR(workspace tab focused), RIGHT_MODAL_NAVIGATOR(card details)]
User clicks Workspaces tab → useRestoreWorkspacesTabOnNavigate finds the newest TAB_NAVIGATOR (search one) via findLast, finds no workspace state, defaults to workspace list
Why this only happens via "View transactions": The key is that the navigation to Search happens while the card details RHP is the top route. If the user navigated to Search directly from the Workspaces tab (without the RHP), linkTo would switch tabs within the existing TAB_NAVIGATOR instead of pushing a new one.
Alternative explanations considered:
Tab state freezing/unmounting: Ruled out — ensureTabNavigatorRoutes at ensureTabNavigatorRoutes.ts:13-32 keeps both TAB_NAVIGATOR instances mounted
Session storage bug: Partially correct for web, but the primary issue is the findLast lookup targeting the wrong TAB_NAVIGATOR
Introduced by: PR Expensify/App#85234 — "Introduce a Bottom Tab Navigator for Top-Level Navigation"
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.64-31 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2026-05-07] [$250] Expensify Card - After clicking View transactions, Workspaces tab resets to initial page[/-][+][Due for payment 2026-05-11] [Due for payment 2026-05-07] [$250] Expensify Card - After clicking View transactions, Workspaces tab resets to initial page[/+]on May 4, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.65-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Apr 27, 2026
@mountiny recently merged #85234, but they are OOO right now, so I'll auto-assign someone else.
github-actions commentedon Apr 27, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Apr 27, 2026
Triggered auto assignment to @chuckdries (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 27, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon Apr 28, 2026
Proposal
Problem: When navigating from Workspace > Expensify Card > Card Details > "View transactions" and then clicking the Workspaces tab, the workspace navigation resets to the list page instead of returning to the Expensify Card settings page.
Root Cause: When "View transactions" is clicked from the card details RHP,
linkTosees the current top route isRIGHT_MODAL_NAVIGATOR(notTAB_NAVIGATOR) and force-PUSHes a newTAB_NAVIGATORinstance onto the root stack. This creates twoTAB_NAVIGATORinstances: the original (with workspace state) and a new one (focused on Search, with no workspace state).When the user then clicks the Workspaces tab,
useRestoreWorkspacesTabOnNavigateusesfindLastto look at only the newestTAB_NAVIGATOR— which has no workspace state. The session storage fallback is a no-op on native, solastWorkspacesTabNavigatorRouteisundefined, causingnavigateToWorkspacesPageto default to the workspace list.Solution: Fix
useRestoreWorkspacesTabOnNavigateto search allTAB_NAVIGATORinstances for workspace state (not just the newest one). When the newestTAB_NAVIGATORhas no workspace state, fall back to checking olderTAB_NAVIGATORinstances in the root stack before defaulting to the workspace list.Specifically, in
useRestoreWorkspacesTabOnNavigate.ts, change the lookup to iterate through allTAB_NAVIGATORroutes (from newest to oldest) until one with workspace state is found:Additionally,
navigateToWorkspacesPageshould restore deeper workspace sub-page state (not justWORKSPACE_INITIAL) when the workspace navigator route has nested state available.Investigation details
Navigation flow that triggers the bug:
[TAB_NAVIGATOR(workspace tab focused), RIGHT_MODAL_NAVIGATOR(card details)]WorkspaceExpensifyCardDetailsPage.tsx:346-361, which callsNavigation.navigate(ROUTES.SEARCH_ROOT.getRoute(...))linkToat line 175-181 forces PUSH becausecurrentTopRouteisRIGHT_MODAL_NAVIGATOR, notTAB_NAVIGATOR[TAB_NAVIGATOR(workspace), RIGHT_MODAL_NAVIGATOR, TAB_NAVIGATOR(search)]useRestoreWorkspacesTabOnNavigatefinds the newestTAB_NAVIGATOR(search one) viafindLast, finds no workspace state, defaults to workspace listWhy this only happens via "View transactions": The key is that the navigation to Search happens while the card details RHP is the top route. If the user navigated to Search directly from the Workspaces tab (without the RHP),
linkTowould switch tabs within the existingTAB_NAVIGATORinstead of pushing a new one.Alternative explanations considered:
ensureTabNavigatorRoutesatensureTabNavigatorRoutes.ts:13-32keeps bothTAB_NAVIGATORinstances mountedfindLastlookup targeting the wrongTAB_NAVIGATORIntroduced by: PR Expensify/App#85234 — "Introduce a Bottom Tab Navigator for Top-Level Navigation"
Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.23 remaining items
m-natarajan commentedon Apr 30, 2026
Passed, Chrome / v9.3.64-27, Xiaomi Redmi Note 10 / Android 12, App 9.3.64-27 (Waiting for validation on iOS)
Screenrecorder-2026-04-30-20-38-27-27.mp4
REC-20260430203319.mp4
luacmartins commentedon Apr 30, 2026
Fixed. Closing.
[-][$250] Expensify Card - After clicking View transactions, Workspaces tab resets to initial page[/-][+][Due for payment 2026-05-07] [$250] Expensify Card - After clicking View transactions, Workspaces tab resets to initial page[/+]melvin-bot commentedon Apr 30, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 30, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.64-31 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-07. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 30, 2026
@ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][Due for payment 2026-05-07] [$250] Expensify Card - After clicking View transactions, Workspaces tab resets to initial page[/-][+][Due for payment 2026-05-11] [Due for payment 2026-05-07] [$250] Expensify Card - After clicking View transactions, Workspaces tab resets to initial page[/+]melvin-bot commentedon May 4, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.65-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-11. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 4, 2026
@ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]