You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-12] Android - Spend - Number of expenses increases by 1 after deleting a split offline #89035
Version Number: 9.3.63-1 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#87742 Email or phone of affected tester (no customers):sdsodijnosdjoij@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Samsung Galaxy S25 FE / Android 16 App Component: Search
Action Performed:
Launch Expensify app.
Go to workspace chat.
Create an expense.
Tap More > Split > Add split > Save.
Go to Spend > Reports.
Go offline.
Open the report.
Delete one of the splits.
Return to Spend > Reports.
Expected Result:
Number of expenses will not increase by 1.
Actual Result:
Number of expenses increases by 1 after deleting a split offline.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #87742 - "Update table and row styles for mobile search pages" by @Krishna2323 (High confidence) Related Issues: None
Recommendation: REVERT
PR #87742 introduced the display of expense count on mobile narrow layout in the Reports view. The count formula item.transactionCount ?? item.transactions?.length ?? 0 produces an incorrect result in the offline split-deletion scenario, causing the count to increase by 1 instead of reflecting the actual expense count.
Assigned: @Krishna2323 (PR author), @situchan@shawnborton@JS00001@luacmartins (approving reviewers) from PR #87742 Labels: DeployBlockerCash kept (App PR is the cause). DeployBlocker is present but the root cause is in the App repo — recommend removing DeployBlocker.
This file is modified by PR #87742 (confirmed via gh pr view 87742 --json files). The critical change is in the narrow layout (!isLargeScreenWidth) branch, which previously rendered user info / action cells with NO expense count display. The PR introduced:
Prior to this PR, no expense count was shown on mobile narrow layout in the Reports list.
Root Cause
When deleting a split transaction offline, the app performs an optimistic update. For a "reverse split" operation (reducing from 2 splits back to 1 expense), the Onyx update flow involves:
Marking split transactions for deletion (decrement)
Recreating the original single transaction (increment)
The item.transactionCount field comes from the spread of reportItem in SearchUIUtils.ts (line 2696: ...reportItem). The transactionCount on the Onyx report object is not correctly accounting for the net effect of the offline split deletion in some cases, resulting in it being 1 higher than expected. Since the expense count was not visible on mobile before PR #87742, this was a latent data bug that only became visible once the PR started displaying the count. The fix could either correct the transactionCount optimistic update in the split deletion path or filter pending-delete transactions from the count calculation.
@Krishna2323 / @situchan@mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2026-05-12] [Due for payment 2026-05-11] [$250] [Due for payment 2026-05-07] Android - Spend - Number of expenses increases by 1 after deleting a split offline[/-][+][Due for payment 2026-05-12] Android - Spend - Number of expenses increases by 1 after deleting a split offline[/+]on May 7, 2026
No payment here cuz it's a regression? cc @Krishna2323@situchan .
Please try to post deets on here so I don't have to fully review the issue and PR to see if anyone's due payment
The original issue itself is a regression. And payment will be handled in parent issue.
But while fixing this, we found another bug happening in production (verified here).
So I am only due payment for fixing this separate bug.
PR: #89403 (worked with Melvin)
Activity
melvin-bot commentedon Apr 28, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #87742
melvin-bot commentedon Apr 28, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 28, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Apr 28, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #87742 - "Update table and row styles for mobile search pages" by @Krishna2323 (High confidence)
Related Issues: None
Recommendation: REVERT
PR #87742 introduced the display of expense count on mobile narrow layout in the Reports view. The count formula
item.transactionCount ?? item.transactions?.length ?? 0produces an incorrect result in the offline split-deletion scenario, causing the count to increase by 1 instead of reflecting the actual expense count.Assigned: @Krishna2323 (PR author), @situchan @shawnborton @JS00001 @luacmartins (approving reviewers) from PR #87742
Labels:
DeployBlockerCashkept (App PR is the cause).DeployBlockeris present but the root cause is in the App repo — recommend removingDeployBlocker.Detailed Analysis
Evidence
StagingDeployCash(version 9.3.64-0).Verification
Affected file:
src/components/Search/SearchList/ListItem/ExpenseReportListItemRow.tsxThis file is modified by PR #87742 (confirmed via
gh pr view 87742 --json files). The critical change is in the narrow layout (!isLargeScreenWidth) branch, which previously rendered user info / action cells with NO expense count display. The PR introduced:Prior to this PR, no expense count was shown on mobile narrow layout in the Reports list.
Root Cause
When deleting a split transaction offline, the app performs an optimistic update. For a "reverse split" operation (reducing from 2 splits back to 1 expense), the Onyx update flow involves:
The
item.transactionCountfield comes from the spread ofreportIteminSearchUIUtils.ts(line 2696:...reportItem). ThetransactionCounton the Onyx report object is not correctly accounting for the net effect of the offline split deletion in some cases, resulting in it being 1 higher than expected. Since the expense count was not visible on mobile before PR #87742, this was a latent data bug that only became visible once the PR started displaying the count. The fix could either correct thetransactionCountoptimistic update in the split deletion path or filter pending-delete transactions from the count calculation.53 remaining items
melvin-bot commentedon May 5, 2026
@Krishna2323 / @situchan @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][Due for payment 2026-05-12] [Due for payment 2026-05-11] [$250] [Due for payment 2026-05-07] Android - Spend - Number of expenses increases by 1 after deleting a split offline[/-][+][Due for payment 2026-05-12] Android - Spend - Number of expenses increases by 1 after deleting a split offline[/+]melvin-bot commentedon May 8, 2026
@Krishna2323 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon May 12, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon May 14, 2026
No payment here cuz it's a regression? cc @Krishna2323 @situchan .
Please try to post deets on here so I don't have to fully review the issue and PR to see if anyone's due payment
situchan commentedon May 14, 2026
The original issue itself is a regression. And payment will be handled in parent issue.
But while fixing this, we found another bug happening in production (verified here).
So I am only due payment for fixing this separate bug.
PR: #89403 (worked with Melvin)
@JS00001 can confirm
mallenexpensify commentedon May 14, 2026
Payment Summary
Contributor+: @situchan due $250 via NewDot
Thx @situchan
laurenreidexpensify commentedon May 23, 2026
$250 approved for @situchan