You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-11] [Due for payment 2026-05-07] Spend - Amount is shown on left when expense has no merchant and description #89042
Version Number: 9.3.64-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#87742 Email or phone of affected tester (no customers):sdsodijnosdjoij@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Samsung Galaxy S25 FE / Android 16 App Component: Search
Action Performed:
Launch Expensify app.
Go to workspace chat.
Create an expense.
Go to self DM.
Create an expense without merchant and description.
Go to Spend > Expenses.
Expected Result:
Amount will always appear on the right.
Actual Result:
Amount is shown on the left when expense has no merchant and description.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #87742 - "Update table and row styles for mobile search pages" by @Krishna2323 (High confidence) Related Issues: #87460
Recommendation: REVERT
PR #87742 introduced a layout regression in the narrow (mobile) transaction row rendering where the amount (TotalCell) appears on the left when an expense has no merchant or description. The fix requires reverting or patching the App PR.
PR Update table and row styles for mobile search pages #87742 was merged on 2026-04-27, one day before the bug was reported (2026-04-28), and the issue is staging-only (not reproducible in production), consistent with this staging deploy.
The PR explicitly modifies src/components/TransactionItemRow/index.tsx — the exact component rendering the expense row in the Spend > Expenses view.
The bug affects Android and iOS native apps — the narrow layout code path (shouldUseNarrowLayout) is precisely what this PR changed.
The current code at line 712–733 in the narrow layout block uses justifyContentBetween on the first row. When merchantOrDescription is falsy, the conditional renders null for the left slot, leaving only the right-side <View> (containing TotalCell). With justifyContentBetween and a single child, flexbox places that child at the start of the row (left), causing the amount to appear on the left.
Root Cause
In the old layout (before PR #87742), when merchantOrDescription was empty, the TotalCell was explicitly placed on the right using styles.mlAuto (auto left margin) inside the date/type row. The new layout in PR #87742 restructured the narrow rows: the first row now conditionally renders <MerchantOrDescriptionCell> only when there is content, and always renders the TotalCell inside a right-side <View>. However, the parent <View> uses styles.justifyContentBetween — when the left side renders null and only the right-side element exists, flexbox treats it as the single child and places it at the flex start (left edge), instead of the end. The fix is to ensure the amount is always right-aligned regardless of whether the merchant/description is present, e.g. by using marginLeft: 'auto' on the right container or conditionally rendering an empty placeholder on the left.
The narrow/mobile layout in TransactionItemRow/index.tsx:712 uses justifyContentBetween on the row containing the merchant/description and the amount. When both merchant and description are empty, merchantOrDescription evaluates to '' (falsy), so the conditional at line 713 renders null instead of the MerchantOrDescriptionCell. This leaves the amount View as the only child. With justify-content: space-between and a single child, that child is placed at flex-start (left), so the amount appears on the left instead of the right.
What changes do you think we should make in order to solve the problem?
Add styles.mlAuto (marginLeft: 'auto') to the amount wrapper View at line 721. This pushes the amount to the right regardless of whether the merchant/description sibling is present. The change is a single style addition:
// line 721: add styles.mlAuto
<View style={[styles.flexRow, styles.alignItemsCenter, styles.gap2, styles.mlAuto]}>
What alternative solutions did you explore? (Optional)
Render an empty placeholder View with flex: 1 when merchantOrDescription is falsy — this works but adds an unnecessary DOM element.
Always render MerchantOrDescriptionCell even when empty — this changes the component contract and could introduce other layout side effects.
The mlAuto approach is the simplest and most robust fix.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-]Spend - Amount is shown on left when expense has no merchant and description[/-][+][Due for payment 2026-05-07] Spend - Amount is shown on left when expense has no merchant and description[/+]on Apr 30, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.64-31 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@Krishna2323 / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2026-05-07] Spend - Amount is shown on left when expense has no merchant and description[/-][+][Due for payment 2026-05-11] [Due for payment 2026-05-07] Spend - Amount is shown on left when expense has no merchant and description[/+]on May 4, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.65-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@Krishna2323 / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Apr 28, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #87742
melvin-bot commentedon Apr 28, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 28, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Apr 28, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #87742 - "Update table and row styles for mobile search pages" by @Krishna2323 (High confidence)
Related Issues: #87460
Recommendation: REVERT
PR #87742 introduced a layout regression in the narrow (mobile) transaction row rendering where the amount (
TotalCell) appears on the left when an expense has no merchant or description. The fix requires reverting or patching the App PR.Assigned: @Krishna2323 (PR author), @situchan, @JS00001, @shawnborton, @luacmartins (approving reviewers) from PR #87742
Labels:
DeployBlockerCashkept (frontend bug in App PR). No label changes made —DeployBlockerwas not present.📋 Detailed Analysis
Evidence
src/components/TransactionItemRow/index.tsx— the exact component rendering the expense row in the Spend > Expenses view.shouldUseNarrowLayout) is precisely what this PR changed.Verification
src/components/TransactionItemRow/index.tsxgh pr view 87742 --json files).justifyContentBetweenon the first row. WhenmerchantOrDescriptionis falsy, the conditional rendersnullfor the left slot, leaving only the right-side<View>(containingTotalCell). WithjustifyContentBetweenand a single child, flexbox places that child at the start of the row (left), causing the amount to appear on the left.Root Cause
In the old layout (before PR #87742), when
merchantOrDescriptionwas empty, theTotalCellwas explicitly placed on the right usingstyles.mlAuto(auto left margin) inside the date/type row. The new layout in PR #87742 restructured the narrow rows: the first row now conditionally renders<MerchantOrDescriptionCell>only when there is content, and always renders theTotalCellinside a right-side<View>. However, the parent<View>usesstyles.justifyContentBetween— when the left side rendersnulland only the right-side element exists, flexbox treats it as the single child and places it at the flex start (left edge), instead of the end. The fix is to ensure the amount is always right-aligned regardless of whether the merchant/description is present, e.g. by usingmarginLeft: 'auto'on the right container or conditionally rendering an empty placeholder on the left.MelvinBot commentedon Apr 28, 2026
Proposal
What is the root cause of that problem?
The narrow/mobile layout in
TransactionItemRow/index.tsx:712usesjustifyContentBetweenon the row containing the merchant/description and the amount. When both merchant and description are empty,merchantOrDescriptionevaluates to''(falsy), so the conditional at line 713 rendersnullinstead of theMerchantOrDescriptionCell. This leaves the amountViewas the only child. Withjustify-content: space-betweenand a single child, that child is placed at flex-start (left), so the amount appears on the left instead of the right.What changes do you think we should make in order to solve the problem?
Add
styles.mlAuto(marginLeft: 'auto') to the amount wrapperViewat line 721. This pushes the amount to the right regardless of whether the merchant/description sibling is present. The change is a single style addition:What alternative solutions did you explore? (Optional)
Viewwithflex: 1whenmerchantOrDescriptionis falsy — this works but adds an unnecessary DOM element.MerchantOrDescriptionCelleven when empty — this changes the component contract and could introduce other layout side effects.The
mlAutoapproach is the simplest and most robust fix.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.7 remaining items
melvin-bot commentedon Apr 28, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
JS00001 commentedon Apr 29, 2026
Fixed
[-]Spend - Amount is shown on left when expense has no merchant and description[/-][+][Due for payment 2026-05-07] Spend - Amount is shown on left when expense has no merchant and description[/+]melvin-bot commentedon Apr 30, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 30, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.64-31 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-07. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 30, 2026
@Krishna2323 / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][Due for payment 2026-05-07] Spend - Amount is shown on left when expense has no merchant and description[/-][+][Due for payment 2026-05-11] [Due for payment 2026-05-07] Spend - Amount is shown on left when expense has no merchant and description[/+]melvin-bot commentedon May 4, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.65-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-11. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 4, 2026
@Krishna2323 / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]