Skip to content

[Due for payment 2026-05-11] [Due for payment 2026-05-07] Spend - Amount is shown on left when expense has no merchant and description #89042

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.64-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #87742
Email or phone of affected tester (no customers): sdsodijnosdjoij@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Samsung Galaxy S25 FE / Android 16
App Component: Search

Action Performed:

  1. Launch Expensify app.
  2. Go to workspace chat.
  3. Create an expense.
  4. Go to self DM.
  5. Create an expense without merchant and description.
  6. Go to Spend > Expenses.

Expected Result:

Amount will always appear on the right.

Actual Result:

Amount is shown on the left when expense has no merchant and description.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Image

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @Krishna2323

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 28, 2026
  2. melvin-bot commented on Apr 28, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #87742

  3. melvin-bot commented on Apr 28, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Apr 28, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. OSBotify commented on Apr 28, 2026

    @OSBotify
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #87742 - "Update table and row styles for mobile search pages" by @Krishna2323 (High confidence)
    Related Issues: #87460

    Recommendation: REVERT

    PR #87742 introduced a layout regression in the narrow (mobile) transaction row rendering where the amount (TotalCell) appears on the left when an expense has no merchant or description. The fix requires reverting or patching the App PR.

    Assigned: @Krishna2323 (PR author), @situchan, @JS00001, @shawnborton, @luacmartins (approving reviewers) from PR #87742
    Labels: DeployBlockerCash kept (frontend bug in App PR). No label changes made — DeployBlocker was not present.

    📋 Detailed Analysis

    Evidence

    Verification

    • Affected file: src/components/TransactionItemRow/index.tsx
    • PR Update table and row styles for mobile search pages #87742 modifies this file (confirmed via gh pr view 87742 --json files).
    • The current code at line 712–733 in the narrow layout block uses justifyContentBetween on the first row. When merchantOrDescription is falsy, the conditional renders null for the left slot, leaving only the right-side <View> (containing TotalCell). With justifyContentBetween and a single child, flexbox places that child at the start of the row (left), causing the amount to appear on the left.

    Root Cause

    In the old layout (before PR #87742), when merchantOrDescription was empty, the TotalCell was explicitly placed on the right using styles.mlAuto (auto left margin) inside the date/type row. The new layout in PR #87742 restructured the narrow rows: the first row now conditionally renders <MerchantOrDescriptionCell> only when there is content, and always renders the TotalCell inside a right-side <View>. However, the parent <View> uses styles.justifyContentBetween — when the left side renders null and only the right-side element exists, flexbox treats it as the single child and places it at the flex start (left edge), instead of the end. The fix is to ensure the amount is always right-aligned regardless of whether the merchant/description is present, e.g. by using marginLeft: 'auto' on the right container or conditionally rendering an empty placeholder on the left.

  6. MelvinBot commented on Apr 28, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    The narrow/mobile layout in TransactionItemRow/index.tsx:712 uses justifyContentBetween on the row containing the merchant/description and the amount. When both merchant and description are empty, merchantOrDescription evaluates to '' (falsy), so the conditional at line 713 renders null instead of the MerchantOrDescriptionCell. This leaves the amount View as the only child. With justify-content: space-between and a single child, that child is placed at flex-start (left), so the amount appears on the left instead of the right.

    What changes do you think we should make in order to solve the problem?

    Add styles.mlAuto (marginLeft: 'auto') to the amount wrapper View at line 721. This pushes the amount to the right regardless of whether the merchant/description sibling is present. The change is a single style addition:

    // line 721: add styles.mlAuto
    <View style={[styles.flexRow, styles.alignItemsCenter, styles.gap2, styles.mlAuto]}>
    

    What alternative solutions did you explore? (Optional)

    1. Render an empty placeholder View with flex: 1 when merchantOrDescription is falsy — this works but adds an unnecessary DOM element.
    2. Always render MerchantOrDescriptionCell even when empty — this changes the component contract and could introduce other layout side effects.

    The mlAuto approach is the simplest and most robust fix.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  7. 7 remaining items

  8. melvin-bot commented on Apr 28, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  9. JS00001 commented on Apr 29, 2026

    @JS00001
    Contributor
    Image

    Fixed

  10. added and removed
    ReviewingHas a PR in review
    on Apr 30, 2026
  11. changed the title [-]Spend - Amount is shown on left when expense has no merchant and description[/-] [+][Due for payment 2026-05-07] Spend - Amount is shown on left when expense has no merchant and description[/+] on Apr 30, 2026
  12. melvin-bot commented on Apr 30, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Apr 30, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.64-31 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-05-07. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Krishna2323 requires payment through NewDot Manual Requests
    • @situchan requires payment through NewDot Manual Requests
  14. melvin-bot commented on Apr 30, 2026

    @melvin-bot

    @Krishna2323 / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. changed the title [-][Due for payment 2026-05-07] Spend - Amount is shown on left when expense has no merchant and description[/-] [+][Due for payment 2026-05-11] [Due for payment 2026-05-07] Spend - Amount is shown on left when expense has no merchant and description[/+] on May 4, 2026
  16. melvin-bot commented on May 4, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.65-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-05-11. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Krishna2323 requires payment through NewDot Manual Requests
    • @situchan requires payment through NewDot Manual Requests
  17. melvin-bot commented on May 4, 2026

    @melvin-bot

    @Krishna2323 / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions