Skip to content

[Due for payment 2026-05-11] [Due for payment 2026-05-07] Expense - Selected unreported expense shows sharp corners instead of rounded corners #89045

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.64-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #87742
Email or phone of affected tester (no customers): sdsodijnosdjoij@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: iPhone 15 Pro Max / iOS 26.3
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com.
  2. Go to self DM.
  3. Create an expense.
  4. Go to workspace chat.
  5. Create a report.
  6. On the report preview, click Add expense > Add unreported expense.
  7. Click on the unreported expense.

Expected Result:

The selected unreported expense will show rounded corners.

Actual Result:

The selected unreported expense shows sharp corners instead of rounded corners.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @Krishna2323

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 28, 2026
  2. melvin-bot commented on Apr 28, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #87742

  3. melvin-bot commented on Apr 28, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Apr 28, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. OSBotify commented on Apr 28, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #87742 - "Update table and row styles for mobile search pages" by @Krishna2323 (High confidence)
    Related Issues: #87460

    Recommendation: REVERT

    PR #87742 introduced the regression by removing the expenseWidgetRadius and overflowHidden styles from the narrow layout rendering in TransactionItemRow, which broke rounded corners for selected expenses in the "Add unreported expense" flow. Reverting this PR is the clearest path to restore correct behavior.

    Assigned: @Krishna2323 (PR author), @situchan, @JS00001, @shawnborton, @luacmartins (approving reviewers)
    Labels: DeployBlockerCash kept (frontend bug in App repo). No label changes made.

    Detailed Analysis

    Evidence

    • The issue is reproducible on staging only (not production), indicating it was introduced in this staging cycle.
    • melvin-bot identified PR Update table and row styles for mobile search pages #87742 as the causing PR based on the regression test reference in the issue body.
    • PR Update table and row styles for mobile search pages #87742 was merged on 2026-04-27 and appears at position 175 in the chronologically ordered StagingDeployCash PR list, matching the timing of the bug appearing in version 9.3.64-0.
    • The bug affects the "Add unreported expense" flow on Android native, iOS native, Windows Chrome, and MacOS Chrome/Safari — all platforms consistent with a frontend change to shared UI components.

    Verification

    • The affected file is src/components/TransactionItemRow/index.tsx.
    • PR Update table and row styles for mobile search pages #87742 modifies this file directly (confirmed in the PR file list and diff).
    • The diff for this file shows the narrow layout View previously had style={[styles.expenseWidgetRadius, bgActiveStyles, styles.justifyContentEvenly, style, styles.overflowHidden]}. PR Update table and row styles for mobile search pages #87742 changed it to style={[bgActiveStyles, styles.justifyContentEvenly, style]}, removing both styles.expenseWidgetRadius and styles.overflowHidden.
    • styles.expenseWidgetRadius provides borderRadius: variables.componentBorderRadiusNormal and styles.overflowHidden clips child content to respect that border radius. Without these, the activeComponentBG background applied when an item is selected renders as a rectangle with sharp corners.
    • The UnreportedExpenseListItem at src/pages/UnreportedExpenseListItem.tsx passes shouldUseNarrowLayout={true} (hardcoded) to TransactionItemRow, so it uses the affected narrow layout code path.
    • The outer PressableWithFeedback in UnreportedExpenseListItem has borderRadius: 8 from styles.transactionListItemStyle, but without overflowHidden on the inner content view, the selected-state background overflows those rounded edges showing sharp corners.

    Root Cause

    In PR #87742, the narrow layout rendering branch in TransactionItemRow/index.tsx was refactored to change the root View's style from [styles.expenseWidgetRadius, bgActiveStyles, styles.justifyContentEvenly, style, styles.overflowHidden] to [bgActiveStyles, styles.justifyContentEvenly, style]. Removing expenseWidgetRadius (the border radius style) and overflowHidden (which clips the background to stay within the rounded border) causes the activeComponentBG fill applied when a user selects an expense item to render with sharp corners instead of rounded ones. This affects the UnreportedExpenseListItem component used in the "Add unreported expense" modal, as well as any other component that renders TransactionItemRow in narrow layout with selection enabled.

  6. MelvinBot commented on Apr 28, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    PR #87742 ("Update table and row styles for mobile search pages") removed styles.expenseWidgetRadius and styles.overflowHidden from the narrow-layout View in TransactionItemRow/index.tsx:687.

    Before the PR, the View had style={[styles.expenseWidgetRadius, bgActiveStyles, styles.justifyContentEvenly, style, styles.overflowHidden]}, which gave selected items an 8px border radius and clipped child content to that shape. After the PR, it became style={[bgActiveStyles, styles.justifyContentEvenly, style]} — so the selected background (activeComponentBG) now renders with sharp corners.

    The wide-layout path at line 798 still has styles.expenseWidgetRadius, which is why only the narrow layout (used by UnreportedExpenseListItem) is affected.

    What changes do you think we should make in order to solve the problem?

    Restore styles.expenseWidgetRadius and styles.overflowHidden on the narrow-layout View at TransactionItemRow/index.tsx:687, changing:

    style={[bgActiveStyles, styles.justifyContentEvenly, style]} → style={[styles.expenseWidgetRadius, bgActiveStyles, styles.justifyContentEvenly, style, styles.overflowHidden]}

    If the removal was intentional for the search page redesign, an alternative is to have callers like UnreportedExpenseListItem pass the radius via the style prop instead.

    What alternative solutions did you explore? (Optional)

    Another option is to make the border radius conditional — applying it only when isSelected is true. However, the wide-layout path applies it unconditionally, so restoring it unconditionally on the narrow path is the most consistent fix.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  7. 7 remaining items

  8. melvin-bot commented on Apr 28, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  9. JS00001 commented on Apr 29, 2026

    @JS00001
    Contributor
    Image

    Fixed

  10. added and removed
    ReviewingHas a PR in review
    on Apr 30, 2026
  11. changed the title [-]Expense - Selected unreported expense shows sharp corners instead of rounded corners[/-] [+][Due for payment 2026-05-07] Expense - Selected unreported expense shows sharp corners instead of rounded corners[/+] on Apr 30, 2026
  12. melvin-bot commented on Apr 30, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Apr 30, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.64-31 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-05-07. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Krishna2323 requires payment through NewDot Manual Requests
    • @situchan requires payment through NewDot Manual Requests
  14. melvin-bot commented on Apr 30, 2026

    @melvin-bot

    @Krishna2323 / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. changed the title [-][Due for payment 2026-05-07] Expense - Selected unreported expense shows sharp corners instead of rounded corners[/-] [+][Due for payment 2026-05-11] [Due for payment 2026-05-07] Expense - Selected unreported expense shows sharp corners instead of rounded corners[/+] on May 4, 2026
  16. melvin-bot commented on May 4, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.65-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-05-11. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Krishna2323 requires payment through NewDot Manual Requests
    • @situchan requires payment through NewDot Manual Requests
  17. melvin-bot commented on May 4, 2026

    @melvin-bot

    @Krishna2323 / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions