You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-11] [Due for payment 2026-05-07] Expense - Selected unreported expense shows sharp corners instead of rounded corners #89045
Version Number: 9.3.64-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#87742 Email or phone of affected tester (no customers):sdsodijnosdjoij@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: iPhone 15 Pro Max / iOS 26.3 App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com.
Go to self DM.
Create an expense.
Go to workspace chat.
Create a report.
On the report preview, click Add expense > Add unreported expense.
Click on the unreported expense.
Expected Result:
The selected unreported expense will show rounded corners.
Actual Result:
The selected unreported expense shows sharp corners instead of rounded corners.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #87742 - "Update table and row styles for mobile search pages" by @Krishna2323 (High confidence) Related Issues: #87460
Recommendation: REVERT
PR #87742 introduced the regression by removing the expenseWidgetRadius and overflowHidden styles from the narrow layout rendering in TransactionItemRow, which broke rounded corners for selected expenses in the "Add unreported expense" flow. Reverting this PR is the clearest path to restore correct behavior.
PR Update table and row styles for mobile search pages #87742 was merged on 2026-04-27 and appears at position 175 in the chronologically ordered StagingDeployCash PR list, matching the timing of the bug appearing in version 9.3.64-0.
The bug affects the "Add unreported expense" flow on Android native, iOS native, Windows Chrome, and MacOS Chrome/Safari — all platforms consistent with a frontend change to shared UI components.
Verification
The affected file is src/components/TransactionItemRow/index.tsx.
The diff for this file shows the narrow layout View previously had style={[styles.expenseWidgetRadius, bgActiveStyles, styles.justifyContentEvenly, style, styles.overflowHidden]}. PR Update table and row styles for mobile search pages #87742 changed it to style={[bgActiveStyles, styles.justifyContentEvenly, style]}, removing both styles.expenseWidgetRadius and styles.overflowHidden.
styles.expenseWidgetRadius provides borderRadius: variables.componentBorderRadiusNormal and styles.overflowHidden clips child content to respect that border radius. Without these, the activeComponentBG background applied when an item is selected renders as a rectangle with sharp corners.
The UnreportedExpenseListItem at src/pages/UnreportedExpenseListItem.tsx passes shouldUseNarrowLayout={true} (hardcoded) to TransactionItemRow, so it uses the affected narrow layout code path.
The outer PressableWithFeedback in UnreportedExpenseListItem has borderRadius: 8 from styles.transactionListItemStyle, but without overflowHidden on the inner content view, the selected-state background overflows those rounded edges showing sharp corners.
Root Cause
In PR #87742, the narrow layout rendering branch in TransactionItemRow/index.tsx was refactored to change the root View's style from [styles.expenseWidgetRadius, bgActiveStyles, styles.justifyContentEvenly, style, styles.overflowHidden] to [bgActiveStyles, styles.justifyContentEvenly, style]. Removing expenseWidgetRadius (the border radius style) and overflowHidden (which clips the background to stay within the rounded border) causes the activeComponentBG fill applied when a user selects an expense item to render with sharp corners instead of rounded ones. This affects the UnreportedExpenseListItem component used in the "Add unreported expense" modal, as well as any other component that renders TransactionItemRow in narrow layout with selection enabled.
PR #87742 ("Update table and row styles for mobile search pages") removed styles.expenseWidgetRadius and styles.overflowHidden from the narrow-layout View in TransactionItemRow/index.tsx:687.
Before the PR, the View had style={[styles.expenseWidgetRadius, bgActiveStyles, styles.justifyContentEvenly, style, styles.overflowHidden]}, which gave selected items an 8px border radius and clipped child content to that shape. After the PR, it became style={[bgActiveStyles, styles.justifyContentEvenly, style]} — so the selected background (activeComponentBG) now renders with sharp corners.
The wide-layout path at line 798 still has styles.expenseWidgetRadius, which is why only the narrow layout (used by UnreportedExpenseListItem) is affected.
What changes do you think we should make in order to solve the problem?
Restore styles.expenseWidgetRadius and styles.overflowHidden on the narrow-layout View at TransactionItemRow/index.tsx:687, changing:
If the removal was intentional for the search page redesign, an alternative is to have callers like UnreportedExpenseListItem pass the radius via the style prop instead.
What alternative solutions did you explore? (Optional)
Another option is to make the border radius conditional — applying it only when isSelected is true. However, the wide-layout path applies it unconditionally, so restoring it unconditionally on the narrow path is the most consistent fix.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.64-31 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@Krishna2323 / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.65-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@Krishna2323 / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Apr 28, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #87742
melvin-bot commentedon Apr 28, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 28, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Apr 28, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #87742 - "Update table and row styles for mobile search pages" by @Krishna2323 (High confidence)
Related Issues: #87460
Recommendation: REVERT
PR #87742 introduced the regression by removing the
expenseWidgetRadiusandoverflowHiddenstyles from the narrow layout rendering inTransactionItemRow, which broke rounded corners for selected expenses in the "Add unreported expense" flow. Reverting this PR is the clearest path to restore correct behavior.Assigned: @Krishna2323 (PR author), @situchan, @JS00001, @shawnborton, @luacmartins (approving reviewers)
Labels:
DeployBlockerCashkept (frontend bug in App repo). No label changes made.Detailed Analysis
Evidence
Verification
src/components/TransactionItemRow/index.tsx.Viewpreviously hadstyle={[styles.expenseWidgetRadius, bgActiveStyles, styles.justifyContentEvenly, style, styles.overflowHidden]}. PR Update table and row styles for mobile search pages #87742 changed it tostyle={[bgActiveStyles, styles.justifyContentEvenly, style]}, removing bothstyles.expenseWidgetRadiusandstyles.overflowHidden.styles.expenseWidgetRadiusprovidesborderRadius: variables.componentBorderRadiusNormalandstyles.overflowHiddenclips child content to respect that border radius. Without these, theactiveComponentBGbackground applied when an item is selected renders as a rectangle with sharp corners.UnreportedExpenseListItematsrc/pages/UnreportedExpenseListItem.tsxpassesshouldUseNarrowLayout={true}(hardcoded) toTransactionItemRow, so it uses the affected narrow layout code path.PressableWithFeedbackinUnreportedExpenseListItemhasborderRadius: 8fromstyles.transactionListItemStyle, but withoutoverflowHiddenon the inner content view, the selected-state background overflows those rounded edges showing sharp corners.Root Cause
In PR #87742, the narrow layout rendering branch in
TransactionItemRow/index.tsxwas refactored to change the rootView's style from[styles.expenseWidgetRadius, bgActiveStyles, styles.justifyContentEvenly, style, styles.overflowHidden]to[bgActiveStyles, styles.justifyContentEvenly, style]. RemovingexpenseWidgetRadius(the border radius style) andoverflowHidden(which clips the background to stay within the rounded border) causes theactiveComponentBGfill applied when a user selects an expense item to render with sharp corners instead of rounded ones. This affects theUnreportedExpenseListItemcomponent used in the "Add unreported expense" modal, as well as any other component that rendersTransactionItemRowin narrow layout with selection enabled.MelvinBot commentedon Apr 28, 2026
Proposal
What is the root cause of that problem?
PR #87742 ("Update table and row styles for mobile search pages") removed
styles.expenseWidgetRadiusandstyles.overflowHiddenfrom the narrow-layoutViewinTransactionItemRow/index.tsx:687.Before the PR, the View had
style={[styles.expenseWidgetRadius, bgActiveStyles, styles.justifyContentEvenly, style, styles.overflowHidden]}, which gave selected items an 8px border radius and clipped child content to that shape. After the PR, it becamestyle={[bgActiveStyles, styles.justifyContentEvenly, style]}— so the selected background (activeComponentBG) now renders with sharp corners.The wide-layout path at
line 798still hasstyles.expenseWidgetRadius, which is why only the narrow layout (used byUnreportedExpenseListItem) is affected.What changes do you think we should make in order to solve the problem?
Restore
styles.expenseWidgetRadiusandstyles.overflowHiddenon the narrow-layoutViewatTransactionItemRow/index.tsx:687, changing:style={[bgActiveStyles, styles.justifyContentEvenly, style]}→style={[styles.expenseWidgetRadius, bgActiveStyles, styles.justifyContentEvenly, style, styles.overflowHidden]}If the removal was intentional for the search page redesign, an alternative is to have callers like
UnreportedExpenseListItempass the radius via thestyleprop instead.What alternative solutions did you explore? (Optional)
Another option is to make the border radius conditional — applying it only when
isSelectedis true. However, the wide-layout path applies it unconditionally, so restoring it unconditionally on the narrow path is the most consistent fix.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.7 remaining items
melvin-bot commentedon Apr 28, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
JS00001 commentedon Apr 29, 2026
Fixed
[-]Expense - Selected unreported expense shows sharp corners instead of rounded corners[/-][+][Due for payment 2026-05-07] Expense - Selected unreported expense shows sharp corners instead of rounded corners[/+]melvin-bot commentedon Apr 30, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 30, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.64-31 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-07. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 30, 2026
@Krishna2323 / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][Due for payment 2026-05-07] Expense - Selected unreported expense shows sharp corners instead of rounded corners[/-][+][Due for payment 2026-05-11] [Due for payment 2026-05-07] Expense - Selected unreported expense shows sharp corners instead of rounded corners[/+]melvin-bot commentedon May 4, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.65-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-11. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 4, 2026
@Krishna2323 / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]