You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expensify Card - Issue card RHP opens after clicking Got it on Bank account verified RHP #89117
Version Number: 9.3.64-9 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#85234 Email or phone of affected tester (no customers):applausetester+khcategory20@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Workspace Settings
Action Performed:
Go to staging.new.expensify.com
Create a USD workspace.
Go to workspace settings > More features.
Enable Expensify Card.
Go to Expensify Card.
Click Issue new card > Issue new card > Log into your bank.
Add a bank account.
Click Issue new card > select bank account.
Click Got it.
Expected Result:
Issue card RHP will not open after clicking Got it.
Actual Result:
Issue card RHP opens after clicking Got it on Bank account verified RHP.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #85234 - "Add TabNavigator" by @WojtekBoman (High confidence) Related Issues: None identified
Recommendation: REVERT
PR #85234 introduced a new TabNavigator (a proper createBottomTabNavigator) that wraps all full-screen navigators. This restructured the root navigation stack from individual screen entries to a single TAB_NAVIGATOR entry. The handleVerifiedButtonPress handler in WorkspaceExpensifyCardBankAccounts.tsx calls Navigation.dismissModal() followed immediately by Navigation.navigate(ROUTES.WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW.getRoute(policyID)). Under the new navigation architecture, this pattern causes the Issue New Card RHP to re-open after dismissal instead of the modal closing cleanly.
Assigned: @WojtekBoman (PR author), @ZhenjaHorbach and @mountiny (approving reviewers) Labels: DeployBlockerCash kept (frontend App PR caused the issue). DeployBlocker not present.
📋 Detailed Analysis
Evidence
The bug is reproducible on staging (version 9.3.64-9) but not production, meaning it was introduced in the current staging release.
PR Introduce a Bottom Tab Navigator for Top-Level Navigation #85234 made a fundamental change: all full-screen navigators (ReportsSplitNavigator, SearchFullscreenNavigator, SettingsSplitNavigator, WorkspaceNavigator) were moved from individual root stack screens into a new TabNavigator created with @react-navigation/bottom-tabs.
The bug reproduces when pressing "Got it" on the Bank account verified RHP, which triggers handleVerifiedButtonPress in src/pages/workspace/expensifyCard/WorkspaceExpensifyCardBankAccounts.tsx.
PR Introduce a Bottom Tab Navigator for Top-Level Navigation #85234 restructured the navigation architecture that underlies how dismissModal() + navigate() interact. Many callsites were updated in the PR to use dismissModal({afterTransition: () => navigate(route)}) instead of sequential calls, but handleVerifiedButtonPress was not updated.
The WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW route is an RHP screen (confirmed via src/libs/Navigation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts). Navigating to it after a dismissModal() under the new TabNavigator structure re-opens the Issue New Card RHP instead of navigating away.
Root Cause
handleVerifiedButtonPress calls Navigation.dismissModal() (which is asynchronous — it queues a DISMISS_MODAL action via TransitionTracker) and then immediately calls Navigation.navigate(ROUTES.WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW...). Under the old navigation structure, this had a different effect. Under PR #85234's new TabNavigator structure, the synchronous navigate() call to an RHP route runs before the dismiss transition completes, resulting in the Issue New Card RHP being pushed back onto the stack. PR #85234 updated many similar patterns to use dismissModal({afterTransition: () => navigate(route)}) but missed this one.
Problem: After clicking "Got it" on the Bank account verified RHP, the Issue New Card RHP immediately re-opens.
Root Cause:handleVerifiedButtonPress calls Navigation.dismissModal() and then immediately calls Navigation.navigate(). After #85234 introduced TabNavigator, the navigate() executes before the dismiss transition completes, pushing the Issue New Card RHP back onto the stack. Many similar callsites were updated in that PR to use the afterTransition callback, but this one was missed.
Fix: Wrap the Navigation.navigate() call inside dismissModal's afterTransition callback, matching the pattern used elsewhere in the codebase:
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
@mjasikowski I would wait with the melvin implementation :) I checked it and it won't fix the issue. According to the issue description, we shouldn't call navigate after closing the modal
@lanitochka17 Could you check if it works fine on prod? I see in code that it's expected to open the Issue Card RHP in that case, so I'd like to confirm we should adjust it
Activity
melvin-bot commentedon Apr 28, 2026
@mountiny recently merged #85234, but they are OOO right now, so I'll auto-assign someone else.
melvin-bot commentedon Apr 28, 2026
Triggered auto assignment to @mjasikowski (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 28, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 28, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Apr 28, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #85234 - "Add TabNavigator" by @WojtekBoman (High confidence)
Related Issues: None identified
Recommendation: REVERT
PR #85234 introduced a new
TabNavigator(a propercreateBottomTabNavigator) that wraps all full-screen navigators. This restructured the root navigation stack from individual screen entries to a singleTAB_NAVIGATORentry. ThehandleVerifiedButtonPresshandler inWorkspaceExpensifyCardBankAccounts.tsxcallsNavigation.dismissModal()followed immediately byNavigation.navigate(ROUTES.WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW.getRoute(policyID)). Under the new navigation architecture, this pattern causes the Issue New Card RHP to re-open after dismissal instead of the modal closing cleanly.Assigned: @WojtekBoman (PR author), @ZhenjaHorbach and @mountiny (approving reviewers)
Labels:
DeployBlockerCashkept (frontend App PR caused the issue).DeployBlockernot present.📋 Detailed Analysis
Evidence
9.3.64-9) but not production, meaning it was introduced in the current staging release.StagingDeployCashdeploy checklist and was merged on April 24, 2026.ReportsSplitNavigator,SearchFullscreenNavigator,SettingsSplitNavigator,WorkspaceNavigator) were moved from individual root stack screens into a newTabNavigatorcreated with@react-navigation/bottom-tabs.handleVerifiedButtonPressinsrc/pages/workspace/expensifyCard/WorkspaceExpensifyCardBankAccounts.tsx.Verification
src/pages/workspace/expensifyCard/WorkspaceExpensifyCardBankAccounts.tsxdismissModal()+navigate()interact. Many callsites were updated in the PR to usedismissModal({afterTransition: () => navigate(route)})instead of sequential calls, buthandleVerifiedButtonPresswas not updated.WORKSPACE_EXPENSIFY_CARD_ISSUE_NEWroute is an RHP screen (confirmed viasrc/libs/Navigation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts). Navigating to it after adismissModal()under the newTabNavigatorstructure re-opens the Issue New Card RHP instead of navigating away.Root Cause
handleVerifiedButtonPresscallsNavigation.dismissModal()(which is asynchronous — it queues aDISMISS_MODALaction viaTransitionTracker) and then immediately callsNavigation.navigate(ROUTES.WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW...). Under the old navigation structure, this had a different effect. Under PR #85234's newTabNavigatorstructure, the synchronousnavigate()call to an RHP route runs before the dismiss transition completes, resulting in the Issue New Card RHP being pushed back onto the stack. PR #85234 updated many similar patterns to usedismissModal({afterTransition: () => navigate(route)})but missed this one.mjasikowski commentedon Apr 29, 2026
@MelvinBot propose a fix for this issue.
MelvinBot commentedon Apr 29, 2026
Proposal
Problem: After clicking "Got it" on the Bank account verified RHP, the Issue New Card RHP immediately re-opens.
Root Cause:
handleVerifiedButtonPresscallsNavigation.dismissModal()and then immediately callsNavigation.navigate(). After #85234 introducedTabNavigator, thenavigate()executes before the dismiss transition completes, pushing the Issue New Card RHP back onto the stack. Many similar callsites were updated in that PR to use theafterTransitioncallback, but this one was missed.Fix: Wrap the
Navigation.navigate()call insidedismissModal'safterTransitioncallback, matching the pattern used elsewhere in the codebase:const handleVerifiedButtonPress = () => { if (!policyID) { return; } setIssueNewCardStepAndData({policyID, isChangeAssigneeDisabled: false}); - Navigation.dismissModal(); - Navigation.navigate(ROUTES.WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW.getRoute(policyID)); + Navigation.dismissModal({ + afterTransition: () => Navigation.navigate(ROUTES.WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW.getRoute(policyID)), + }); };What changes:
WorkspaceExpensifyCardBankAccounts.tsx:121-122— replace the two sequential calls with a singledismissModal({afterTransition})call.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.mjasikowski commentedon Apr 29, 2026
@MelvinBot implement this
WojtekBoman commentedon Apr 29, 2026
@mjasikowski I would wait with the melvin implementation :) I checked it and it won't fix the issue. According to the issue description, we shouldn't call
navigateafter closing the modal@lanitochka17 Could you check if it works fine on prod? I see in code that it's expected to open the Issue Card RHP in that case, so I'd like to confirm we should adjust it
MelvinBot commentedon Apr 29, 2026
🤖 Draft PR created: #89151
Please mark it as "Ready for review" when it is ready for review.
mjasikowski commentedon Apr 29, 2026
@WojtekBoman no worries, this was more to have a draft PR to create an ad hoc build
luacmartins commentedon Apr 29, 2026
This seems to be expected https://expensify.slack.com/archives/C05LX9D6E07/p1777475145833249?thread_ts=1777305341.023169&cid=C05LX9D6E07. Closing.