You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expensify Card - RHP back button on Reconciliation account page is unresponsive #89127
Version Number: 9.3.64-9 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#85234 Email or phone of affected tester (no customers):applausetester+khcategory20@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Workspace is set up with Expensify Card feature.
Workspace is connected to QBO.
Go to staging.new.expensify.com
Go to workspace settings > Accounting.
Click Card reconciliation.
Enable Continuous Reconciliation.
Click Expensify Card settlement account.
Click Reconciliation account.
Click Expensify Card settlement account.
Click Reconciliation account.
Click RHP back button twice.
Click RHP back button again.
Expected Result:
RHP back button will return to Settlement account page.
Actual Result:
RHP back button on Reconciliation account page is unresponsive.
Account list on this page is empty.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #87916 - "Use accounting integration bank accounts for reconciliation" by @rlinoz (High confidence) Related Issues: None
Recommendation: REVERT
PR #87916 directly modified DynamicReconciliationAccountSettingsPage.tsx and introduced the regression. It was merged on 2026-04-27 (the day before this bug was filed) and is confirmed present in the current StagingDeployCash. Reverting it is the cleanest path to unblocking the deploy.
Assigned: @rlinoz (PR author), @blimpich (approving reviewer) Labels: DeployBlockerCash kept (Frontend bug in App). No label changes made.
PR #87916 changed DynamicReconciliationAccountSettingsPage to source bank account options from getConnectionBankAccountsForReconciliation(connections, connectionName) instead of from the user's BANK_ACCOUNT_LIST Onyx key via getEligibleBankAccountsForCard(). It also introduced a new Onyx key EXPENSIFY_CARD_RECONCILIATION_BANK_ACCOUNT_ID to track the selected reconciliation account.
Two regressions result from this change:
Empty account list: getConnectionBankAccountsForReconciliation reads from policy?.connections (i.e., the accounting integration's bank account data). If the integration data hasn't been fetched or is incomplete when the page renders, connectionBankAccounts is an empty array and no options are shown.
Unresponsive back button: The goBack callback calls Navigation.goBack(backPath), where backPath is computed by useDynamicBackPath. When the user navigates back and forth between the Settlement account page and the Reconciliation account page multiple times (as in the reproduction steps), the navigation state can reach an inconsistent state because the new code calls goBack() immediately after setCardReconciliationAccount(), and the new Onyx key optimistic update may interfere with the re-render cycle. This leaves the page in a state where the back path resolves incorrectly or the component no longer responds to button presses.
Note: PR #85234 (Bottom Tab Navigator refactor) also modified navigation-related files including useRootNavigationState.ts, but that PR's changes are broader and not specific to the reconciliation flow. PR #87916 is the targeted cause for this specific regression.
Activity
melvin-bot commentedon Apr 28, 2026
@mountiny recently merged #85234, but they are OOO right now, so I'll auto-assign someone else.
melvin-bot commentedon Apr 28, 2026
Triggered auto assignment to @chuckdries (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 28, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 28, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Apr 28, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #87916 - "Use accounting integration bank accounts for reconciliation" by @rlinoz (High confidence)
Related Issues: None
Recommendation: REVERT
PR #87916 directly modified
DynamicReconciliationAccountSettingsPage.tsxand introduced the regression. It was merged on 2026-04-27 (the day before this bug was filed) and is confirmed present in the current StagingDeployCash. Reverting it is the cleanest path to unblocking the deploy.Assigned: @rlinoz (PR author), @blimpich (approving reviewer)
Labels:
DeployBlockerCashkept (Frontend bug in App). No label changes made.📋 Detailed Analysis
Evidence
Verification
src/pages/workspace/accounting/reconciliation/DynamicReconciliationAccountSettingsPage.tsxgh pr view 87916 --json files).src/pages/workspace/accounting/reconciliation/CardReconciliationPage.tsx.Root Cause
PR #87916 changed
DynamicReconciliationAccountSettingsPageto source bank account options fromgetConnectionBankAccountsForReconciliation(connections, connectionName)instead of from the user'sBANK_ACCOUNT_LISTOnyx key viagetEligibleBankAccountsForCard(). It also introduced a new Onyx keyEXPENSIFY_CARD_RECONCILIATION_BANK_ACCOUNT_IDto track the selected reconciliation account.Two regressions result from this change:
Empty account list:
getConnectionBankAccountsForReconciliationreads frompolicy?.connections(i.e., the accounting integration's bank account data). If the integration data hasn't been fetched or is incomplete when the page renders,connectionBankAccountsis an empty array and no options are shown.Unresponsive back button: The
goBackcallback callsNavigation.goBack(backPath), wherebackPathis computed byuseDynamicBackPath. When the user navigates back and forth between the Settlement account page and the Reconciliation account page multiple times (as in the reproduction steps), the navigation state can reach an inconsistent state because the new code callsgoBack()immediately aftersetCardReconciliationAccount(), and the new Onyx key optimistic update may interfere with the re-render cycle. This leaves the page in a state where the back path resolves incorrectly or the component no longer responds to button presses.Note: PR #85234 (Bottom Tab Navigator refactor) also modified navigation-related files including
useRootNavigationState.ts, but that PR's changes are broader and not specific to the reconciliation flow. PR #87916 is the targeted cause for this specific regression.chuckdries commentedon Apr 28, 2026
This appears to be a duplicate of #89122, just reported for a different platform
lanitochka17 commentedon Apr 28, 2026
sorry, duplicate of #89122