Skip to content

Expensify Card - RHP back button on Reconciliation account page is unresponsive #89127

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.64-9
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #85234
Email or phone of affected tester (no customers): applausetester+khcategory20@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Workspace is set up with Expensify Card feature.
  • Workspace is connected to QBO.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Accounting.
  3. Click Card reconciliation.
  4. Enable Continuous Reconciliation.
  5. Click Expensify Card settlement account.
  6. Click Reconciliation account.
  7. Click Expensify Card settlement account.
  8. Click Reconciliation account.
  9. Click RHP back button twice.
  10. Click RHP back button again.

Expected Result:

RHP back button will return to Settlement account page.

Actual Result:

RHP back button on Reconciliation account page is unresponsive.
Account list on this page is empty.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7140302_1777390927178.13.1.mp4

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Apr 28, 2026

    @melvin-bot

    @mountiny recently merged #85234, but they are OOO right now, so I'll auto-assign someone else.

  2. melvin-bot commented on Apr 28, 2026

    @melvin-bot

    Triggered auto assignment to @chuckdries (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Apr 28, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Apr 28, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. OSBotify commented on Apr 28, 2026

    @OSBotify
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #87916 - "Use accounting integration bank accounts for reconciliation" by @rlinoz (High confidence)
    Related Issues: None

    Recommendation: REVERT

    PR #87916 directly modified DynamicReconciliationAccountSettingsPage.tsx and introduced the regression. It was merged on 2026-04-27 (the day before this bug was filed) and is confirmed present in the current StagingDeployCash. Reverting it is the cleanest path to unblocking the deploy.

    Assigned: @rlinoz (PR author), @blimpich (approving reviewer)
    Labels: DeployBlockerCash kept (Frontend bug in App). No label changes made.

    📋 Detailed Analysis

    Evidence

    Verification

    Root Cause

    PR #87916 changed DynamicReconciliationAccountSettingsPage to source bank account options from getConnectionBankAccountsForReconciliation(connections, connectionName) instead of from the user's BANK_ACCOUNT_LIST Onyx key via getEligibleBankAccountsForCard(). It also introduced a new Onyx key EXPENSIFY_CARD_RECONCILIATION_BANK_ACCOUNT_ID to track the selected reconciliation account.

    Two regressions result from this change:

    1. Empty account list: getConnectionBankAccountsForReconciliation reads from policy?.connections (i.e., the accounting integration's bank account data). If the integration data hasn't been fetched or is incomplete when the page renders, connectionBankAccounts is an empty array and no options are shown.

    2. Unresponsive back button: The goBack callback calls Navigation.goBack(backPath), where backPath is computed by useDynamicBackPath. When the user navigates back and forth between the Settlement account page and the Reconciliation account page multiple times (as in the reproduction steps), the navigation state can reach an inconsistent state because the new code calls goBack() immediately after setCardReconciliationAccount(), and the new Onyx key optimistic update may interfere with the re-render cycle. This leaves the page in a state where the back path resolves incorrectly or the component no longer responds to button presses.

    Note: PR #85234 (Bottom Tab Navigator refactor) also modified navigation-related files including useRootNavigationState.ts, but that PR's changes are broader and not specific to the reconciliation flow. PR #87916 is the targeted cause for this specific regression.

  6. chuckdries commented on Apr 28, 2026

    @chuckdries
    Contributor

    This appears to be a duplicate of #89122, just reported for a different platform

  7. lanitochka17 commented on Apr 28, 2026

    @lanitochka17
    Author

    sorry, duplicate of #89122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions