You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Let's create a composable version of PopoverMenu, following our new React code guidelines, with a target API similar to the one described here: #79387 (comment)
This will unblock a similar refactor for ButtonWithDropdownMenu, which in turn will unblock a similar refactor for SettlementButton.
Sorry for the delay - there were just too many competing priorities at once for me. Next step is to talk about the new code patterns in the modal decomposition and make sure the team agrees on that design
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
roryabraham commentedon Apr 30, 2026
Not looking for proposals on this one at this time - @TaduJR is already working on it
TaduJR commentedon Apr 30, 2026
👋
TaduJR commentedon May 2, 2026
PR is ready.
roryabraham commentedon May 3, 2026
Posted a thorough review
TaduJR commentedon May 3, 2026
Awesome Thanks Rory, This is getting super exciting.
roryabraham commentedon May 5, 2026
agree. Posted another pretty sizeable review yesterday
45 remaining items
roryabraham commentedon Jul 30, 2026
Sorry for the delay - there were just too many competing priorities at once for me. Next step is to talk about the new code patterns in the modal decomposition and make sure the team agrees on that design
melvin-bot commentedon Aug 24, 2026
This issue has not been updated in over 15 days. @roryabraham, @linhvovan29546, @TaduJR eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
melvin-bot commentedon Nov 5, 2026
@roryabraham, @linhvovan29546, @TaduJR, this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.