Skip to content

Decompose PopoverMenu #89236

Open
Open

Description

@roryabraham

Coming from #79387 (comment)

Let's create a composable version of PopoverMenu, following our new React code guidelines, with a target API similar to the one described here: #79387 (comment)

This will unblock a similar refactor for ButtonWithDropdownMenu, which in turn will unblock a similar refactor for SettlementButton.

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. roryabraham commented on Apr 30, 2026

    @roryabraham
    ContributorAuthor

    Not looking for proposals on this one at this time - @TaduJR is already working on it

  2. TaduJR commented on Apr 30, 2026

    @TaduJR
    Contributor

    👋

  3. added
    ReviewingHas a PR in review
    and removed on May 2, 2026
  4. TaduJR commented on May 2, 2026

    @TaduJR
    Contributor

    PR is ready.

  5. roryabraham commented on May 3, 2026

    @roryabraham
    ContributorAuthor

    Posted a thorough review

  6. TaduJR commented on May 3, 2026

    @TaduJR
    Contributor

    Posted a thorough review

    Awesome Thanks Rory, This is getting super exciting.

  7. roryabraham commented on May 5, 2026

    @roryabraham
    ContributorAuthor

    agree. Posted another pretty sizeable review yesterday

  8. 45 remaining items

  9. roryabraham commented on Jul 30, 2026

    @roryabraham
    ContributorAuthor

    Sorry for the delay - there were just too many competing priorities at once for me. Next step is to talk about the new code patterns in the modal decomposition and make sure the team agrees on that design

  10. melvin-bot commented on Aug 24, 2026

    @melvin-bot

    This issue has not been updated in over 15 days. @roryabraham, @linhvovan29546, @TaduJR eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  11. melvin-bot commented on Nov 5, 2026

    @melvin-bot

    @roryabraham, @linhvovan29546, @TaduJR, this Monthly task hasn't been acted upon in 6 weeks; closing.

    If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

  12. reopened this on Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions