Skip to content

[Due for payment 2026-05-11] [Due for payment 2026-05-07] Spend - Report carrousel disappears on approve #89255

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.64-23
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation (hyperlinked to channel name): #expensify_bugs

Action Performed:

Prerequisites: Workspace with 2 employee

  1. Go to https://staging.new.expensify.com/
  2. Create several reports
  3. Employee A and employee B submit to manager C expense
  4. As manager C, go to the Spend page > Needs approval
  5. Approve one report

Expected Result:

User should be able to navigate to the other reports for approval using report carrousel.

Actual Result:

Report carrousel disappears on approve page.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Recording.3730.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 30, 2026
  2. melvin-bot commented on Apr 30, 2026

    @melvin-bot

    Triggered auto assignment to @chiragsalian (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Apr 30, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Apr 30, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. OSBotify commented on Apr 30, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #88714 - "Avoid mounting MoneyRequestReportNavigation when unnecessary" by @TMisiukiewicz (High confidence)
    Related Issues: #79082 (previously fixed by #79132)

    Recommendation: REVERT

    PR #88714 introduced a SnapshotGuard that gates the MoneyRequestReportNavigation component on snapshotGuard.includesReport — a check that fails as soon as the current report is approved and removed from the search snapshot, causing the carousel to unmount immediately.

    Assigned: @TMisiukiewicz (PR author), @abzokhattab @mountiny (approving reviewers)
    Labels: DeployBlockerCash retained (frontend App PR caused the issue). No label changes made.

    Detailed Analysis

    Evidence

    Verification

    Root Cause

    PR #88714 split MoneyRequestReportNavigation into an outer shell and an inner component. The outer shell added a shouldMount guard:

    const shouldMount =
      isExpenseReportSearch &&
      snapshotGuard.hasMultiple &&
      snapshotGuard.includesReport;
    if (!shouldMount) {
      return null;
    }

    snapshotGuard.includesReport is derived from buildSnapshotGuardSelector, which scans the raw Onyx snapshot for a key matching the current reportID. When the manager approves a report, the report changes state and is removed from the "Needs Approval" search snapshot. At that moment, includesReport becomes false, shouldMount becomes false, and the navigation component unmounts — making the carousel disappear.

    The original MoneyRequestReportNavigation (before PR #88714) relied on currentIndex !== -1 from useSearchSections / allReports to decide whether to show the arrows. PR #79132 had intentionally bypassed action-based filtering so the report would remain in allReports temporarily after approval, keeping the carousel visible long enough to navigate away.

    PR #88714's new snapshot-based guard short-circuits before useSearchSections is consulted, re-introducing the race condition that PR #79132 originally resolved.

  6. 22 remaining items

  7. daledah commented on May 4, 2026

    @daledah
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR:
      Link to the comment on the Issue:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    • Workspace with 2 employee

    Test:

    Test case 1:

    1. Go to https://staging.new.expensify.com/
    2. Create several reports
    3. Employee A and employee B submit to manager C expense
    4. As manager C, go to the Spend page > Needs approval
    5. Approve one report
    6. Verify that: User should be able to navigate to the other reports for approval using report carrousel.

    Test case 2:

    1. Go to staging.new.expensify.com
    2. Go to workspace chat.
    3. Create an expense.
    4. Go to Spend > All reports.
    5. Click on the report.
    6. Click Report field > Create report.
    7. Verify that: The new report will be shown in the background.

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-2ee1-adb9-a844-98c201c30644
  8. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on May 4, 2026
  9. melvin-bot commented on May 10, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  10. melvin-bot commented on May 11, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  11. mallenexpensify commented on May 12, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @daledah due $250 via NewDot

    @daledah plz fully fill out the BZ checklist

    The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to the comment on the PR:
    Link to the comment on the Issue:

    It looks like the offending PR goes back a lil bit. @ZhenjaHorbach if you reviewed and payment on an issue should be reduced, please comment and link to here. Thx

  12. quinthar commented on May 21, 2026

    @quinthar
    Contributor

    Approved $250 to @daledah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions