You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-11] [Due for payment 2026-05-07] Spend - Report carrousel disappears on approve #89255
Version Number: 9.3.64-23 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@JmillsExpensify Slack conversation (hyperlinked to channel name): #expensify_bugs
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #88714 - "Avoid mounting MoneyRequestReportNavigation when unnecessary" by @TMisiukiewicz (High confidence) Related Issues: #79082 (previously fixed by #79132)
Recommendation: REVERT
PR #88714 introduced a SnapshotGuard that gates the MoneyRequestReportNavigation component on snapshotGuard.includesReport — a check that fails as soon as the current report is approved and removed from the search snapshot, causing the carousel to unmount immediately.
Assigned: @TMisiukiewicz (PR author), @abzokhattab@mountiny (approving reviewers) Labels: DeployBlockerCash retained (frontend App PR caused the issue). No label changes made.
Detailed Analysis
Evidence
The bug is staging-only (version 9.3.64-23), not reproducible on production.
This is a regression of an identical bug fixed by PR Fix report carousel disappearing after approve by skipping action filter #79132 ("Fix report carousel disappearing after approve by skipping action filter", merged Jan 12, 2026). That PR's description and QA steps describe exactly the same scenario: approver opens a report from Spend > Needs Approval, approves it, and the carousel should remain visible to navigate to the next report.
snapshotGuard.includesReport is derived from buildSnapshotGuardSelector, which scans the raw Onyx snapshot for a key matching the current reportID. When the manager approves a report, the report changes state and is removed from the "Needs Approval" search snapshot. At that moment, includesReport becomes false, shouldMount becomes false, and the navigation component unmounts — making the carousel disappear.
The original MoneyRequestReportNavigation (before PR #88714) relied on currentIndex !== -1 from useSearchSections / allReports to decide whether to show the arrows. PR #79132 had intentionally bypassed action-based filtering so the report would remain in allReports temporarily after approval, keeping the carousel visible long enough to navigate away.
PR #88714's new snapshot-based guard short-circuits before useSearchSections is consulted, re-introducing the race condition that PR #79132 originally resolved.
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR:
Link to the comment on the Issue:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR:
Link to the comment on the Issue:
It looks like the offending PR goes back a lil bit. @ZhenjaHorbach if you reviewed and payment on an issue should be reduced, please comment and link to here. Thx
Activity
melvin-bot commentedon Apr 30, 2026
Triggered auto assignment to @chiragsalian (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 30, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 30, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Apr 30, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #88714 - "Avoid mounting MoneyRequestReportNavigation when unnecessary" by @TMisiukiewicz (High confidence)
Related Issues: #79082 (previously fixed by #79132)
Recommendation: REVERT
PR #88714 introduced a
SnapshotGuardthat gates theMoneyRequestReportNavigationcomponent onsnapshotGuard.includesReport— a check that fails as soon as the current report is approved and removed from the search snapshot, causing the carousel to unmount immediately.Assigned: @TMisiukiewicz (PR author), @abzokhattab @mountiny (approving reviewers)
Labels:
DeployBlockerCashretained (frontend App PR caused the issue). No label changes made.Detailed Analysis
Evidence
9.3.64-23), not reproducible on production.MoneyRequestReportNavigation.tsx.Verification
src/components/MoneyRequestReportView/MoneyRequestReportNavigation.tsxStagingDeployCashchecklist for release9.3.64-23.Root Cause
PR #88714 split
MoneyRequestReportNavigationinto an outer shell and an inner component. The outer shell added ashouldMountguard:snapshotGuard.includesReportis derived frombuildSnapshotGuardSelector, which scans the raw Onyx snapshot for a key matching the currentreportID. When the manager approves a report, the report changes state and is removed from the "Needs Approval" search snapshot. At that moment,includesReportbecomesfalse,shouldMountbecomesfalse, and the navigation component unmounts — making the carousel disappear.The original
MoneyRequestReportNavigation(before PR #88714) relied oncurrentIndex !== -1fromuseSearchSections/allReportsto decide whether to show the arrows. PR #79132 had intentionally bypassed action-based filtering so the report would remain inallReportstemporarily after approval, keeping the carousel visible long enough to navigate away.PR #88714's new snapshot-based guard short-circuits before
useSearchSectionsis consulted, re-introducing the race condition that PR #79132 originally resolved.22 remaining items
daledah commentedon May 4, 2026
BugZero Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR:
Link to the comment on the Issue:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/635844
Regression Test Proposal
Precondition:
Test:
Test case 1:
Test case 2:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-2ee1-adb9-a844-98c201c30644melvin-bot commentedon May 10, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon May 11, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon May 12, 2026
Payment Summary
Contributor+: @daledah due $250 via NewDot
@daledah plz fully fill out the BZ checklist
It looks like the offending PR goes back a lil bit. @ZhenjaHorbach if you reviewed and payment on an issue should be reduced, please comment and link to here. Thx
quinthar commentedon May 21, 2026
Approved $250 to @daledah