[Due for payment 2026-05-12] [Due for payment 2026-05-11] Expense - Expense with negative account is not displayed on "Existing Expenses" list. #89340

Activity

1. mitarachim

   added this to #expensify-bugson May 1, 2026
2. mitarachim

   added

   DeployBlockerCashThis issue or pull request should block deploymentThis issue or pull request should block deployment

   DailyKSv2KSv2

   BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.

   DeployBlockerIndicates it should block deploying the APIIndicates it should block deploying the API

   on May 1, 2026
3. melvin-bot

   assigned

   puneetlath

   on May 1, 2026
4. melvin-bot commented on May 1, 2026

   

   melvin-botBot

   on May 1, 2026 – with Melvin Bot

   More actions

   You have been assigned to this deploy blocker because you recently merged this PR: #85225
5. melvin-bot commented on May 1, 2026

   

   melvin-botBot

   on May 1, 2026 – with Melvin Bot

   More actions

   💬 A slack conversation has been started in #expensify-open-source
6. github-actions

   added

   Engineering

   HourlyKSv2KSv2

   and removed

   DailyKSv2KSv2

   on May 1, 2026
7. github-actions commented on May 1, 2026

   

   github-actionsBot

   on May 1, 2026 – with GitHub Actions

   Contributor

   More actions

   👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

   1. Identify the pull request that introduced this issue and revert it.
   2. Find someone who can quickly fix the issue.
   3. Fix the issue yourself.
8. OSBotify commented on May 1, 2026

   

   OSBotify

   on May 1, 2026

   Contributor

   More actions

   Investigation Summary

   Classification: Frontend bug
   Causing PR: #85225 - "Feat: Change Add unreported expense to Add existing expense in a report" by @nyomanjyotisa (High confidence)
   Related Issues: #84130

   Recommendation: REVERT

   PR #85225 introduced a regression by expanding the "Add existing expense" flow to include Draft expenses (expenses on open expense reports), but the pre-existing filter that blocks negative-amount transactions still applies to all expense types. This causes negative-amount expenses to be hidden from the list even when they are valid Draft expenses that should be selectable.

   Assigned: @nyomanjyotisa (PR author), @sobitneupane and @puneetlath (approving reviewers)
   Labels: DeployBlockerCash kept (Frontend bug — App PR caused the issue). DeployBlocker kept (already present on the issue, not removing without confirmation this is purely frontend).

   Detailed Analysis

   Evidence

   • The bug report states that expenses with negative amounts are not visible in the "Add existing expense" list, and cannot be added to another report.
   • The melvin-bot immediately identified PR Feat: Change Add unreported expense to Add existing expense in a report #85225 as the causing PR and assigned its author.
   • PR Feat: Change Add unreported expense to Add existing expense in a report #85225 is in the current StagingDeployCash (version 9.3.65-0) and was merged on 2026-04-29, shortly before this blocker was filed.
   • The issue is staging-only ("Reproducible in production? N/A - new feature, doesn't exist in prod"), meaning the cause is in the current staging deploy.

   Verification

   • The affected file is src/pages/AddExistingExpense.tsx (renamed from AddUnreportedExpense.tsx by PR Feat: Change Add unreported expense to Add existing expense in a report #85225).
   • Lines 122-127 of the current file contain this filter logic:

     const transactionAmount = getTransactionDetails(item)?.amount ?? 0;
     // Negative values are not allowed for unreported expenses
     if (transactionAmount < 0) {
         return false;
     }

   • This comment ("Negative values are not allowed for unreported expenses") reveals the filter was designed for the old behavior where only truly unreported expenses were shown. The filter predates PR Feat: Change Add unreported expense to Add existing expense in a report #85225.
   • PR Feat: Change Add unreported expense to Add existing expense in a report #85225 expanded the eligible transactions in getEligibleTransactions to also include Draft expenses (expenses on open expense reports via allOpenReports and openReportDrafts), but did NOT remove or narrow the negative-amount filter.
   • As a result, negative-amount Draft expenses are now incorrectly excluded from the list.
   • The PR diff confirms the negative amount filter was not part of the changes in Feat: Change Add unreported expense to Add existing expense in a report #85225 — it was a pre-existing condition that became a regression when the scope of eligible transactions was widened.

   Root Cause

   Before PR #85225, getEligibleTransactions only returned truly unreported transactions (reportID === CONST.REPORT.UNREPORTED_REPORT_ID or empty). The negative-amount filter was arguably intentional for that context (unreported expenses from the workspace chat cannot be negative). PR #85225 widened the filter to also include Draft expenses (those on any open expense report), but the blanket negative-amount exclusion was not adjusted to account for this expanded set. Draft expenses with negative amounts are valid (e.g., refunds or credits) and should appear in the list. The fix requires either removing the blanket negative-amount guard or scoping it to only apply to truly unreported transactions (not Draft expenses on open reports).
9. OSBotify

   assigned

   nyomanjyotisa

   and

   sobitneupane

   on May 1, 2026
10. 3 remaining items

    Load more

11. m-natarajan commented on May 1, 2026

    

    m-natarajan

    on May 1, 2026

    More actions

    Issue no longer reproducible, Mac/ Chrome, Motorola Moto G60 - Android 12, on Build 9.3.65-4

    screen-20260501-170656.mp4

    Repro.-.issue.89340.mp4
12. puneetlath commented on May 1, 2026

    

    puneetlath

    on May 1, 2026

    Contributor

    More actions

    Great, thanks!
13. puneetlath

    closed this as completedon May 1, 2026
14. github-project-automation

    moved this to Done in #expensify-bugson May 1, 2026
15. github-actions

    removed

    DeployBlockerCashThis issue or pull request should block deploymentThis issue or pull request should block deployment

    on May 4, 2026
16. melvin-bot

    added

    DailyKSv2KSv2

    and removed

    ReviewingHas a PR in reviewHas a PR in review

    HourlyKSv2KSv2

    on May 4, 2026
17. melvin-bot

    changed the title [-]Expense - Expense with negative account is not displayed on "Existing Expenses" list.[/-] [+][Due for payment 2026-05-11] Expense - Expense with negative account is not displayed on "Existing Expenses" list.[/+] on May 4, 2026
18. melvin-bot commented on May 4, 2026

    

    melvin-botBot

    on May 4, 2026 – with Melvin Bot

    More actions

    Reviewing label has been removed, please complete the "BugZero Checklist".
19. melvin-bot commented on May 4, 2026

    

    melvin-botBot

    on May 4, 2026 – with Melvin Bot

    More actions

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.65-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    • fix: correct add existing expense eligibility rules #89357

    If no regressions arise, payment will be issued on 2026-05-11. 🎊

    For reference, here are some details about the assignees on this issue:

    • @sobitneupane requires payment through NewDot Manual Requests
    • @nyomanjyotisa requires payment through NewDot Manual Requests
20. melvin-bot commented on May 4, 2026

    

    melvin-botBot

    on May 4, 2026 – with Melvin Bot

    More actions

    @sobitneupane / @nyomanjyotisa The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
21. melvin-bot

    changed the title [-][Due for payment 2026-05-11] Expense - Expense with negative account is not displayed on "Existing Expenses" list.[/-] [+][Due for payment 2026-05-12] [Due for payment 2026-05-11] Expense - Expense with negative account is not displayed on "Existing Expenses" list.[/+] on May 5, 2026
22. melvin-bot commented on May 5, 2026

    

    melvin-botBot

    on May 5, 2026 – with Melvin Bot

    More actions

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.66-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    • fix: correct add existing expense eligibility rules #89357

    If no regressions arise, payment will be issued on 2026-05-12. 🎊

    For reference, here are some details about the assignees on this issue:

    • @sobitneupane requires payment through NewDot Manual Requests
    • @nyomanjyotisa requires payment through NewDot Manual Requests
23. melvin-bot commented on May 5, 2026

    

    melvin-botBot

    on May 5, 2026 – with Melvin Bot

    More actions

    @sobitneupane / @nyomanjyotisa The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]