Skip to content

[Due for payment 2026-06-09] [IOURequestStepScan Decomposition] chore: remove dead scan MoneyRequest path + hooks + tests #89385

Closed

Description

@cristipaval

Held on #89384

Part of IOURequestStepScan Decomposition Plan — see rinej's split design comment.

Parent: #85583

Problem

After variants own scan behavior, the old centralized participant/navigation hook path and monolith hooks become dead code and maintenance noise.

Solution

Delete handleMoneyRequestStepScanParticipants and related types from MoneyRequest.ts, remove useReceiptScan and useMobileReceiptScan, and drop or rewrite the tests that only covered that stack, as listed in the plan.

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on May 4, 2026

    @melvin-bot

    @bernhardoj Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  2. changed the title [-][IOURequestStepScan Decomposition] chore: remove dead scan MoneyRequest path + hooks + tests[/-] [+][HOLD] [IOURequestStepScan Decomposition] chore: remove dead scan MoneyRequest path + hooks + tests[/+] on May 5, 2026
  3. cristipaval commented on May 5, 2026

    @cristipaval
    ContributorAuthor

    Held on #89384

  4. melvin-bot commented on May 8, 2026

    @melvin-bot

    @rinej Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  5. cristipaval commented on May 11, 2026

    @cristipaval
    ContributorAuthor

    still held

  6. 30 remaining items

  7. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jun 8, 2026
  8. melvin-bot commented on Jun 8, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  9. melvin-bot commented on Jun 8, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @rinej does not require payment (Contractor)
    • Reviewer: @bernhardoj owed $250 via NewDot

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  10. melvin-bot commented on Jun 11, 2026

    @melvin-bot

    @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  11. Julesssss commented on Jun 12, 2026

    @Julesssss
    Contributor

    Ready for payment

  12. mallenexpensify commented on Jun 15, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @bernhardoj due $250 via NewDot

    I'm assuming, since this is part of a project (or for other reasons), I shouldn't deduct for the below. If I should.. please comment/reopen. thx

    Deploy Blocker #92206 was identified to be related to this PR.

  13. flaviadefaria commented on Jun 16, 2026

    @flaviadefaria
    Contributor

    Approved: @bernhardoj due $250 via NewDot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions