Repository navigation
Android - Connect bank account - Unable to connect with Plaid option, page is skipping #8947
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Launch the app
- Log in with expensifail account
- Go to Setting - Preferences
- Enable Secure Staging server
- Go to any Workspace
- Tab connect Bank account
- Tab Connect online with Plaid
- Select Wells Fargo bank account
- Tap user name: user_good
- Tap password: pass_good
- Tap Continue
Expected Result:
Able to move into Company page
Actual Result:
Unable to connect with Plaid, page is skipping
Workaround:
Unknown
Platform:
Where is this issue occurring?
- Android
Version Number: 1.1.57.12
Reproducible in staging?: Yes
Reproducible in production?: No, unable to verify VBA flow in Prod
Email or phone of affected tester (no customers): any expensifail account
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screen_Recording_20220511-124111_New.Expensify.1.mp4
Screen_Recording_20220510-151415_New.Expensify.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
Activity
melvin-bot commentedon May 11, 2022
Triggered auto assignment to @sketchydroide (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.isagoico commentedon May 11, 2022
@luacmartins This issue is failing PR #8808 - I'm adding the deploy blocker label since this behavior was not reproducible before. (we're unable to check if the issue is reproducible in prod bc the test credentials don't work there)
OSBotify commentedon May 11, 2022
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:luacmartins commentedon May 11, 2022
Hmm I took a quick look at this one and I think it may have been introduced here. It seems that dismissing the Plaid modal on mobile makes the app become active, firing the reconnect callbacks. I think that might create the bug with the navigation. Commenting this line out seems to fix the issue. I didn't spend too much time investigating this, so it's possible the cause is elsewhere.
We could just revert that PR for now if the goal is to get a deploy (since we haven't done so in ~3 weeks). If that ends up being the issue, I have a few ideas on how to solve it.
chiragsalian commentedon May 12, 2022
Cool looks like the others blockers are resolved. I could revert this but you have till tomorrow if you would like to investigate a different solution if you do not want to revert. QA is still working on the checklist (their ETA atm is to finish by tomorrow morning) so while they are working on it you can decide if you would rather revert of check another solution 🙂 let me know.
sketchydroide commentedon May 12, 2022
I've assigned you to the GH @luacmartins as you seem to be on top of it
If this is the only blocker, I would say that revert and then fix this withouth the added pressure would be better
luacmartins commentedon May 12, 2022
Trying to test this further.
luacmartins commentedon May 12, 2022
I did some more testing and I'm not sure that the PR I linked before is the issue anymore. Looking at other possibilities now.
luacmartins commentedon May 12, 2022
Nvm my previous comment. It seems that when we fire the reconnect callbacks this line empties the
achDataandsubStep. It happens on mobile because the Plaid modal somehow puts the app in the background. I put up a quick fix here, I'll discuss this further with Marc once he's back since he's been leading these changes.chiragsalian commentedon May 12, 2022
Hi @kbecciv, this should be resolved in version
1.1.57-15or higher.Can you retest and confirm? if its resolved feel free to close the issue.
chiragsalian commentedon May 12, 2022
Passed the checklist, closing isssue.