You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-13] [Due for payment 2026-05-12] Search - "No content to add" error after clicking Ask Concierge with just a space #89522
Version Number: 9.3.66-1 Reproducible in staging?: Yes Reproducible in production?: Unable to validate in Prod - Provide reasoning. If this was caught during regression testing, add the test name, ID and link from BrowserStack:#88727 Email or phone of affected tester (no customers):applausetester+sdodsaf@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Search
Action Performed:
Go to staging.new.expensify.com
Open search.
Enter a space.
Click Ask Concierge.
Expected Result:
Ask Concierge option should not appear when only a space is entered.
Actual Result:
Ask Concierge option shows up when only a space is entered.
"No content to add" error shows up due to the sent empty message.
Root Cause: The search router shows the "Ask Concierge" option based on a bare truthy check of textInputValue at SearchRouter.tsx:203. A single space " " is truthy in JavaScript, so the option renders. When clicked, the untrimmed space is passed through the entire chain — askConcierge() → addComment() → API — and the server rejects it as empty content.
This prevents both the search item and Ask Concierge item from appearing when the input is whitespace-only. As an additional safeguard, useAskConcierge.tsx should also trim the query before passing it to addComment.
Investigation details
Data flow:
User types a space → textInputValue = " "
SearchRouter.tsx:203 — truthy check passes, searchQueryItems array is created with both search and Ask Concierge items, each carrying searchQuery: textInputValue (line 217)
changed the title [-]89508 Search - "No content to add" error after clicking Ask Concierge with just a space[/-][+]Search - "No content to add" error after clicking Ask Concierge with just a space[/+]on May 4, 2026
useSearchPageInput.tsx:201 — same .trim() fix (yes, this needs it too — without it, whitespace-only input still shows a useless "search for a space" item)
useAskConcierge.tsx:26 — trims the query before calling addComment and bails if empty (defense-in-depth)
Please mark it as "Ready for review" when it is ready for review.
⏱️ Ran out of time before I could finish. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in #melvinbot-ai.
changed the title [-]Search - "No content to add" error after clicking Ask Concierge with just a space[/-][+][Due for payment 2026-05-12] Search - "No content to add" error after clicking Ask Concierge with just a space[/+]on May 5, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.66-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@chuckdries / @francoisl The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2026-05-12] Search - "No content to add" error after clicking Ask Concierge with just a space[/-][+][Due for payment 2026-05-13] [Due for payment 2026-05-12] Search - "No content to add" error after clicking Ask Concierge with just a space[/+]on May 6, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.67-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@chuckdries / @francoisl The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon May 4, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #88727
melvin-bot commentedon May 4, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon May 4, 2026
Issue Analysis
Root Cause: The search router shows the "Ask Concierge" option based on a bare truthy check of
textInputValueatSearchRouter.tsx:203. A single space" "is truthy in JavaScript, so the option renders. When clicked, the untrimmed space is passed through the entire chain —askConcierge()→addComment()→ API — and the server rejects it as empty content.Recommended Fix: Add a
.trim()to the condition atSearchRouter.tsx:203:This prevents both the search item and Ask Concierge item from appearing when the input is whitespace-only. As an additional safeguard,
useAskConcierge.tsxshould also trim the query before passing it toaddComment.Investigation details
Data flow:
textInputValue = " "SearchRouter.tsx:203— truthy check passes,searchQueryItemsarray is created with both search and Ask Concierge items, each carryingsearchQuery: textInputValue(line 217)SearchRouter.tsx:324-329callsaskConcierge(" ")useAskConcierge.tsx:30passes the space toaddCommentwith no trimmingReport/index.ts:706—text(space) is truthy, so the API call proceedsConfidence: High — the entire data flow is traced with no ambiguity.
Possible duplicate: #89524 has the same title and appears to track the same issue.
Next Steps: Reply with
@MelvinBot implement thisto create a draft PR, or@MelvinBot <your feedback>to refine this analysis.melvin-bot commentedon May 4, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
[-]89508 Search - "No content to add" error after clicking Ask Concierge with just a space[/-][+]Search - "No content to add" error after clicking Ask Concierge with just a space[/+]nlemma commentedon May 4, 2026
Deploy Blocker #89524 was identified to be related to the PR #88727 that attempted to fix this issue.
francoisl commentedon May 4, 2026
@MelvinBot implement this. Also, what about the same code that's used in
useSearchPageInput? Do we need totrim()there too?App/src/components/Search/SearchPageHeader/useSearchPageInput.tsx
Line 201 in f1a4a92
MelvinBot commentedon May 4, 2026
🤖 Draft PR created: #89563
Changes:
SearchRouter.tsx:203— added.trim()totextInputValuetruthiness checkuseSearchPageInput.tsx:201— same.trim()fix (yes, this needs it too — without it, whitespace-only input still shows a useless "search for a space" item)useAskConcierge.tsx:26— trims the query before callingaddCommentand bails if empty (defense-in-depth)Please mark it as "Ready for review" when it is ready for review.
1 remaining item
MelvinBot commentedon May 4, 2026
⏱️ Ran out of time before I could finish. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in #melvinbot-ai.
Run details
francoisl commentedon May 4, 2026
Fix confirmed on staging
[-]Search - "No content to add" error after clicking Ask Concierge with just a space[/-][+][Due for payment 2026-05-12] Search - "No content to add" error after clicking Ask Concierge with just a space[/+]melvin-bot commentedon May 5, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 5, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.66-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-12. 🎊
melvin-bot commentedon May 5, 2026
@chuckdries / @francoisl The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][Due for payment 2026-05-12] Search - "No content to add" error after clicking Ask Concierge with just a space[/-][+][Due for payment 2026-05-13] [Due for payment 2026-05-12] Search - "No content to add" error after clicking Ask Concierge with just a space[/+]melvin-bot commentedon May 6, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.67-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-13. 🎊
melvin-bot commentedon May 6, 2026
@chuckdries / @francoisl The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]