You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-13] [Due for payment 2026-05-12] Categories - Spend category list opens not here page #89526
Version Number: 9.3.66-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#88842 Email or phone of affected tester (no customers):jsosdjosjndosjodnjno@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Workspace Settings
Classification: Frontend bug Causing PR: #88842 - "BT - Migrate Workspace Categories" by @mananjadhav (High confidence) Related Issues: N/A
Recommendation: REVERT
PR #88842 renamed SCREENS.WORKSPACE.CATEGORIES_SETTINGS to SCREENS.WORKSPACE.DYNAMIC_CATEGORIES_SETTINGS throughout the codebase but missed updating the entryScreens array in DYNAMIC_ROUTES.SPEND_CATEGORY_SELECTOR in src/ROUTES.ts. This causes the dynamic route system to reject navigation to the spend category selector from the categories settings page, resulting in the "Not here" page.
Assigned: @mananjadhav (PR author), @huult@mjasikowski (approving reviewers) from highest-confidence causing PR only Labels: Keeping DeployBlockerCash (frontend bug from App PR). Removing DeployBlocker (no backend involvement).
📋 Detailed Analysis
Evidence
PR BT - Migrate Workspace Categories #88842 was merged on 2026-05-04 and is the last meaningful change to workspace categories navigation before this issue was reported.
The melvin-bot already assigned this PR as the cause in the first comment.
The PR's goal was to migrate workspace categories screens from static routes to dynamic routes (the "BT - Migrate" pattern).
It correctly renamed SCREENS.WORKSPACE.CATEGORIES_SETTINGS → SCREENS.WORKSPACE.DYNAMIC_CATEGORIES_SETTINGS in the screen registry, navigator mapping, linking config, types, and WORKSPACE_TO_RHP relations.
However, it missed one location: the entryScreens array of DYNAMIC_ROUTES.SPEND_CATEGORY_SELECTOR in src/ROUTES.ts (line 321).
Verification
Affected file: src/ROUTES.ts
The SPEND_CATEGORY_SELECTOR dynamic route at line 319–323 reads:
SPEND_CATEGORY_SELECTOR: {
path: 'spend-category-selector/:groupID',
entryScreens: [SCREENS.WORKSPACE.CATEGORIES_SETTINGS, ...], // still uses OLD name
...
}
The entryScreens mechanism is enforced in src/libs/Navigation/helpers/getStateFromPath.ts: when a user navigates to the spend category selector, the dynamic route system checks whether the currently focused screen name matches any value in entryScreens. Since the screen is now named DYNAMIC_CATEGORIES_SETTINGS (new) but entryScreens still lists CATEGORIES_SETTINGS (old), the check fails and the "Not here" page is shown.
The page component (WorkspaceCategoriesSettingsPage.tsx) correctly navigates to createDynamicRoute(DYNAMIC_ROUTES.SPEND_CATEGORY_SELECTOR.getRoute(item.groupID)) on item select — the call-site is correct, but the route guard rejects it.
PR #88842 modifies WorkspaceCategoriesSettingsPage.tsx and src/ROUTES.ts (to add new dynamic routes), confirming it touched the exact files involved in this regression.
Root Cause
In src/ROUTES.ts, the DYNAMIC_ROUTES.SPEND_CATEGORY_SELECTOR.entryScreens array was not updated when SCREENS.WORKSPACE.CATEGORIES_SETTINGS was renamed to SCREENS.WORKSPACE.DYNAMIC_CATEGORIES_SETTINGS by PR #88842. The getStateFromPath helper strictly checks that the focused route's screen name is in entryScreens before permitting navigation; since the name no longer matches, navigation falls through to the "Not here" (not found) page.
The fix is a one-line change: replace SCREENS.WORKSPACE.CATEGORIES_SETTINGS with SCREENS.WORKSPACE.DYNAMIC_CATEGORIES_SETTINGS in the SPEND_CATEGORY_SELECTOR.entryScreens array. A clean revert of PR #88842 is also viable.
PR #88842 ("BT - Migrate Workspace Categories") renamed the categories settings screen from SCREENS.WORKSPACE.CATEGORIES_SETTINGS ('Categories_Settings') to SCREENS.WORKSPACE.DYNAMIC_CATEGORIES_SETTINGS ('Dynamic_Categories_Settings') in the modal stack navigator, linking config, and WORKSPACE_TO_RHP mapping — but did not update the entryScreens array in the SPEND_CATEGORY_SELECTOR dynamic route definition.
When the user opens a spend category from the settings page, getStateFromPath.ts checks the focused route name ('Dynamic_Categories_Settings') against the entryScreens array, which still contains the old name ('Categories_Settings'). The match fails and the "Not Here" page is shown.
What changes do you think we should make in order to solve the problem?
Change SCREENS.WORKSPACE.CATEGORIES_SETTINGS → SCREENS.WORKSPACE.DYNAMIC_CATEGORIES_SETTINGS in the entryScreens array of SPEND_CATEGORY_SELECTOR.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-]Categories - Spend category list opens not here page[/-][+][Due for payment 2026-05-12] Categories - Spend category list opens not here page[/+]on May 5, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.66-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@mananjadhav / @huult The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2026-05-12] Categories - Spend category list opens not here page[/-][+][Due for payment 2026-05-13] [Due for payment 2026-05-12] Categories - Spend category list opens not here page[/+]on May 6, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.67-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@mananjadhav / @huult The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon May 4, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #88842
melvin-bot commentedon May 4, 2026
💬 A slack conversation has been started in #expensify-open-source
OSBotify commentedon May 4, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #88842 - "BT - Migrate Workspace Categories" by @mananjadhav (High confidence)
Related Issues: N/A
Recommendation: REVERT
PR #88842 renamed
SCREENS.WORKSPACE.CATEGORIES_SETTINGStoSCREENS.WORKSPACE.DYNAMIC_CATEGORIES_SETTINGSthroughout the codebase but missed updating theentryScreensarray inDYNAMIC_ROUTES.SPEND_CATEGORY_SELECTORinsrc/ROUTES.ts. This causes the dynamic route system to reject navigation to the spend category selector from the categories settings page, resulting in the "Not here" page.Assigned: @mananjadhav (PR author), @huult @mjasikowski (approving reviewers) from highest-confidence causing PR only
Labels: Keeping
DeployBlockerCash(frontend bug from App PR). RemovingDeployBlocker(no backend involvement).📋 Detailed Analysis
Evidence
SCREENS.WORKSPACE.CATEGORIES_SETTINGS→SCREENS.WORKSPACE.DYNAMIC_CATEGORIES_SETTINGSin the screen registry, navigator mapping, linking config, types, and WORKSPACE_TO_RHP relations.entryScreensarray ofDYNAMIC_ROUTES.SPEND_CATEGORY_SELECTORinsrc/ROUTES.ts(line 321).Verification
Affected file:
src/ROUTES.tsThe
SPEND_CATEGORY_SELECTORdynamic route at line 319–323 reads:The
entryScreensmechanism is enforced insrc/libs/Navigation/helpers/getStateFromPath.ts: when a user navigates to the spend category selector, the dynamic route system checks whether the currently focused screen name matches any value inentryScreens. Since the screen is now namedDYNAMIC_CATEGORIES_SETTINGS(new) butentryScreensstill listsCATEGORIES_SETTINGS(old), the check fails and the "Not here" page is shown.The page component (
WorkspaceCategoriesSettingsPage.tsx) correctly navigates tocreateDynamicRoute(DYNAMIC_ROUTES.SPEND_CATEGORY_SELECTOR.getRoute(item.groupID))on item select — the call-site is correct, but the route guard rejects it.PR #88842 modifies
WorkspaceCategoriesSettingsPage.tsxandsrc/ROUTES.ts(to add new dynamic routes), confirming it touched the exact files involved in this regression.Root Cause
In
src/ROUTES.ts, theDYNAMIC_ROUTES.SPEND_CATEGORY_SELECTOR.entryScreensarray was not updated whenSCREENS.WORKSPACE.CATEGORIES_SETTINGSwas renamed toSCREENS.WORKSPACE.DYNAMIC_CATEGORIES_SETTINGSby PR #88842. ThegetStateFromPathhelper strictly checks that the focused route's screen name is inentryScreensbefore permitting navigation; since the name no longer matches, navigation falls through to the "Not here" (not found) page.The fix is a one-line change: replace
SCREENS.WORKSPACE.CATEGORIES_SETTINGSwithSCREENS.WORKSPACE.DYNAMIC_CATEGORIES_SETTINGSin theSPEND_CATEGORY_SELECTOR.entryScreensarray. A clean revert of PR #88842 is also viable.MelvinBot commentedon May 4, 2026
Proposal
What is the root cause of that problem?
PR #88842 ("BT - Migrate Workspace Categories") renamed the categories settings screen from
SCREENS.WORKSPACE.CATEGORIES_SETTINGS('Categories_Settings') toSCREENS.WORKSPACE.DYNAMIC_CATEGORIES_SETTINGS('Dynamic_Categories_Settings') in the modal stack navigator, linking config, andWORKSPACE_TO_RHPmapping — but did not update theentryScreensarray in theSPEND_CATEGORY_SELECTORdynamic route definition.When the user opens a spend category from the settings page,
getStateFromPath.tschecks the focused route name ('Dynamic_Categories_Settings') against theentryScreensarray, which still contains the old name ('Categories_Settings'). The match fails and the "Not Here" page is shown.What changes do you think we should make in order to solve the problem?
Update
src/ROUTES.ts:321to reference the new screen name:Change
SCREENS.WORKSPACE.CATEGORIES_SETTINGS→SCREENS.WORKSPACE.DYNAMIC_CATEGORIES_SETTINGSin theentryScreensarray ofSPEND_CATEGORY_SELECTOR.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.1 remaining item
MelvinBot commentedon May 4, 2026
🤖 Draft PR created: #89544
Please mark it as "Ready for review" when it is ready for review.
francoisl commentedon May 4, 2026
CP fix confirmed working on staging
[-]Categories - Spend category list opens not here page[/-][+][Due for payment 2026-05-12] Categories - Spend category list opens not here page[/+]melvin-bot commentedon May 5, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 5, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.66-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-12. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 5, 2026
@mananjadhav / @huult The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][Due for payment 2026-05-12] Categories - Spend category list opens not here page[/-][+][Due for payment 2026-05-13] [Due for payment 2026-05-12] Categories - Spend category list opens not here page[/+]melvin-bot commentedon May 6, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.67-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-13. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 6, 2026
@mananjadhav / @huult The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]