Skip to content

[Due for payment 2026-05-13] [Due for payment 2026-05-12] Expense - Category, tag, tax, total column are not aligned correctly #89529

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.66-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #88296
Email or phone of affected tester (no customers): josdjnosdjionjsdonjisod@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Enable tag and taxes in workspace settings.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create two expense with category, tag and tax.
  4. Open the report.

Expected Result:

Category, tag and tax column will be aligned correctly.

Actual Result:

Category, tag and tax column are not aligned correctly.

Same issue also happens with Total column in IOU report.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Image Image

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @Krishna2323

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 4, 2026
  2. melvin-bot commented on May 4, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #88296

  3. melvin-bot commented on May 4, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on May 4, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. JS00001 commented on May 4, 2026

    @JS00001
    Contributor

    @Krishna2323 another blocker

  6. OSBotify commented on May 4, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #88296 - "Update report details view to use compact desktop table styles" by @Krishna2323 (High confidence)
    Related Issues: #86203

    Recommendation: REVERT

    PR #88296 introduced a new shouldRemoveTotalColumnFlex flag and substantially reworked the table layout styles for the compact desktop report view. The column misalignment on MacOS/Chrome in staging (v9.3.66-1) directly matches the scope of changes in this PR — both the table header and the transaction rows were restyled, and any mismatch in how the column flex/width is applied between the header and rows would produce the misalignment seen in the screenshots.

    Assigned: @Krishna2323 (PR author), @JS00001, @luacmartins, @situchan (approving reviewers)
    Labels: No label changes needed — DeployBlockerCash is correct (staging-only frontend bug in Expensify/App); DeployBlocker is not present and should not be added.

    Detailed Analysis

    Evidence

    Verification

    • Affected files per the bug report: the report detail column layout for category, tag, tax, and total on desktop web.
    • PR Update report details view to use compact desktop table styles #88296 modifies:
      • src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx — reworks the table header container styles and removes gap2 between grouped transactions
      • src/components/MoneyRequestReportView/MoneyRequestReportTableHeader.tsx — adds shouldRemoveTotalColumnFlex prop
      • src/components/MoneyRequestReportView/MoneyRequestReportTransactionItem.tsx — passes shouldRemoveTotalColumnFlex to row items
      • src/components/TransactionItemRow/index.tsx — passes shouldRemoveTotalColumnFlex through to getReportTableColumnStyles for TOTAL_AMOUNT, TOTAL_PER_ATTENDEE, and ORIGINAL_AMOUNT columns
      • src/components/MoneyRequestReportView/MoneyRequestReportGroupHeader.tsx — reworks group header height and padding

    Root Cause

    The getReportTableColumnStyles function in src/styles/utils/index.ts at line 1929 applies flex1 to the total/amount columns unless shouldRemoveTotalColumnFlex is true. PR #88296 passes shouldRemoveTotalColumnFlex to the row items (MoneyRequestReportTransactionItem) and the table header (MoneyRequestReportTableHeader), removing the flex1 flex grow from those columns. However, the group header (MoneyRequestReportGroupHeader) does not receive this flag — meaning the group header row may lay out its columns at a different width than the data rows and the table header, producing the visible misalignment between category, tag, tax, and total columns.

  7. 4 remaining items

  8. m-natarajan commented on May 5, 2026

    @m-natarajan

    Issue is reproducible on Windows 11 / Chrome in v9.3.66-5, It's better than before.

    Image Image
  9. francoisl commented on May 5, 2026

    @francoisl
    Contributor

    Not seeing any differences between production and staging on my end. Going to keep closed for now, I'll let the PR author and reviewers confirm if we need to fix something else.

    Staging Prod
    Image Image
  10. added and removed
    ReviewingHas a PR in review
    on May 5, 2026
  11. changed the title [-]Expense - Category, tag, tax, total column are not aligned correctly[/-] [+][Due for payment 2026-05-12] Expense - Category, tag, tax, total column are not aligned correctly[/+] on May 5, 2026
  12. melvin-bot commented on May 5, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on May 5, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.66-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-05-12. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Krishna2323 requires payment through NewDot Manual Requests
    • @situchan requires payment through NewDot Manual Requests
  14. melvin-bot commented on May 5, 2026

    @melvin-bot

    @Krishna2323 / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. changed the title [-][Due for payment 2026-05-12] Expense - Category, tag, tax, total column are not aligned correctly[/-] [+][Due for payment 2026-05-13] [Due for payment 2026-05-12] Expense - Category, tag, tax, total column are not aligned correctly[/+] on May 6, 2026
  16. melvin-bot commented on May 6, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.67-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-05-13. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Krishna2323 requires payment through NewDot Manual Requests
    • @situchan requires payment through NewDot Manual Requests
  17. melvin-bot commented on May 6, 2026

    @melvin-bot

    @Krishna2323 / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions