You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-15] Search - Blank RHP opens on the right, request not sent to Concierge when app loading #89535
Version Number: v9.3.66-1 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#88727 Email or phone of affected tester (no customers):applausetester+sdodsaf@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Search
Action Performed:
Go to staging.new.expensify.com
Go offline.
Go to Account > Troubleshoot > Clear cache and restart > Reset and refresh.
Open search router.
Type anything.
Click Ask anything.
Go to Inbox.
Go online.
Expected Result:
In Step 6, Ask anything option should be hidden when app is loading.
Actual Result:
In Step 6, Ask anything option is shown when app is loading.
In Step 7, blank RHP opens after clicking Ask anything.
In Step 8, the query in Step 5 is not sent to Concierge.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #88727 - " "Ask Concierge" option in the search router" by @mhawryluk (High confidence) Related Issues: None
Recommendation: REVERT
The causing PR introduced the "Ask Concierge" item into the search router without guarding its visibility against app loading state. Reverting this PR cleanly resolves all three reported symptoms.
Assigned: @mhawryluk (PR author), @linhvovan29546@chuckdries (approving reviewers) Labels: DeployBlockerCash kept (frontend fix needed in App repo). DeployBlocker should be removed — the fix does not require backend changes.
The PR adds "Ask Concierge" as a new item in SearchRouter.tsx inside the searchQueryItems array. This item is always included whenever textInputValue is truthy — there is no guard checking whether the app has finished loading its Onyx data.
When the app is loading from a cleared cache while offline, CONCIERGE_REPORT_ID is not yet populated in Onyx. The useAskConcierge hook's returned callback calls openConciergeAnywhere() and then early-returns because targetReport and targetReportID are both undefined. This causes a blank RHP to open (the side panel opens but no report is shown).
After going online (step 8), the query is never sent to Concierge because the addComment call was skipped when the user pressed the item in the loading state.
PR "Ask Concierge" option in the search router #88727 directly modifies SearchRouter.tsx (confirmed via gh pr view 88727 --json files) and adds the useAskConcierge.tsx and useOpenConciergeAnywhere hook files.
The searchQueryItems array in SearchRouter.tsx (lines 203–223 after the merge) adds the ASK_CONCIERGE item unconditionally alongside the search item whenever there is text input. No IS_LOADING_APP, IS_LOADING_REPORT_DATA, or conciergeReportID availability check is performed before including this item.
Root Cause
In SearchRouter.tsx, the searchQueryItems array always includes the "Ask Concierge" item when the user has typed text, regardless of whether the app has finished loading its data. When offline with a cleared cache, CONCIERGE_REPORT_ID in Onyx is undefined, so useAskConcierge's returned callback opens the side panel but immediately returns without sending the message. The fix requires either hiding the "Ask Concierge" option while the app is loading / conciergeReportID is unavailable, or reverting the PR entirely.
I think the best way to go about it is to hide the "Ask Concierge" option from the search router until the concierge report onyx data is loaded from the server. I created a PR implementing this: #89580
changed the title [-]Search - Blank RHP opens on the right, request not sent to Concierge when app loading[/-][+][Due for payment 2026-05-15] Search - Blank RHP opens on the right, request not sent to Concierge when app loading[/+]on May 8, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.68-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@linhvovan29546 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon May 4, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #88727
melvin-bot commentedon May 4, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 4, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon May 4, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #88727 - " "Ask Concierge" option in the search router" by @mhawryluk (High confidence)
Related Issues: None
Recommendation: REVERT
The causing PR introduced the "Ask Concierge" item into the search router without guarding its visibility against app loading state. Reverting this PR cleanly resolves all three reported symptoms.
Assigned: @mhawryluk (PR author), @linhvovan29546 @chuckdries (approving reviewers)
Labels:
DeployBlockerCashkept (frontend fix needed in App repo).DeployBlockershould be removed — the fix does not require backend changes.📋 Detailed Analysis
Evidence
SearchRouter.tsxinside thesearchQueryItemsarray. This item is always included whenevertextInputValueis truthy — there is no guard checking whether the app has finished loading its Onyx data.CONCIERGE_REPORT_IDis not yet populated in Onyx. TheuseAskConciergehook's returned callback callsopenConciergeAnywhere()and then early-returns becausetargetReportandtargetReportIDare both undefined. This causes a blank RHP to open (the side panel opens but no report is shown).addCommentcall was skipped when the user pressed the item in the loading state.Verification
src/components/Search/SearchRouter/SearchRouter.tsx,src/components/Search/SearchRouter/useAskConcierge.tsx,src/hooks/useOpenConciergeAnywhere/index.tsxSearchRouter.tsx(confirmed viagh pr view 88727 --json files) and adds theuseAskConcierge.tsxanduseOpenConciergeAnywherehook files.searchQueryItemsarray inSearchRouter.tsx(lines 203–223 after the merge) adds the ASK_CONCIERGE item unconditionally alongside the search item whenever there is text input. NoIS_LOADING_APP,IS_LOADING_REPORT_DATA, orconciergeReportIDavailability check is performed before including this item.Root Cause
In
SearchRouter.tsx, thesearchQueryItemsarray always includes the "Ask Concierge" item when the user has typed text, regardless of whether the app has finished loading its data. When offline with a cleared cache,CONCIERGE_REPORT_IDin Onyx isundefined, souseAskConcierge's returned callback opens the side panel but immediately returns without sending the message. The fix requires either hiding the "Ask Concierge" option while the app is loading /conciergeReportIDis unavailable, or reverting the PR entirely.9 remaining items
mhawryluk commentedon May 5, 2026
I think the best way to go about it is to hide the "Ask Concierge" option from the search router until the concierge report onyx data is loaded from the server. I created a PR implementing this: #89580
[-]Search - Blank RHP opens on the right, request not sent to Concierge when app loading[/-][+][Due for payment 2026-05-15] Search - Blank RHP opens on the right, request not sent to Concierge when app loading[/+]melvin-bot commentedon May 8, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 8, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.68-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-15. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 8, 2026
@linhvovan29546 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
linhvovan29546 commentedon May 8, 2026
This is a follow-up to #88727, so I think we can close this.