Skip to content

[Due for payment 2026-05-20] Members - Empty state screen is not scrollable on landscape mode when applying role filter. #89554

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.66-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #88293
Email or phone of affected tester (no customers): ibellicotest+2250@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Motorola MotoG60 / Android 12 (Hybrid app)
App Component: Workspace Settings

Action Performed:

Prerequisite: Account has a control workspace.
Prerequisite: Workspace has no member as "Auditor"

  1. Open the Expensify app.
  2. Navigate to "Workspaces" > "Members"
  3. Tap on the members role filter and select "Auditor"
  4. Note that an empty state screen appears if no member applies to the filter.
  5. Switch to landscape mode.
  6. Note that empty state screen is not completelly visible and can´t be scrolled.

Expected Result:

After applying the members role filter while in landscape mode, empty state screen should be scrollable.

Actual Result:

After applying the members role filter while in landscape mode, empty state screen is not completelly visible and can´t be scrolled.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 4, 2026
  2. melvin-bot commented on May 4, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #88293

  3. melvin-bot commented on May 4, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on May 4, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. OSBotify commented on May 4, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #88293 - "feat: Added role filter to workspace members list" by @Uzaifm127 (High confidence)
    Related Issues: #87907

    Recommendation: REVERT

    PR #88293 introduced the role filter and the empty state for filtered member lists. The empty state rendering uses contentContainerStyle: [styles.flex1, styles.mh100] on the SelectionList, where mh100 resolves to maxHeight: '100%'. In landscape mode on Android, the screen height is small enough that this maxHeight: '100%' constraint on the list's content container caps the total scrollable area, causing the empty state (rendered via listFooterContent) to be clipped and non-scrollable.

    Assigned: @Uzaifm127 (PR author), @FitseTLT, @srikarparsi (approving reviewers)
    Labels: DeployBlockerCash kept (frontend App bug); no label changes made.

    Detailed Analysis

    Evidence

    • melvin-bot already identified PR feat: Added role filter to workspace members list #88293 as the cause, having assigned the issue directly to its author.
    • PR feat: Added role filter to workspace members list #88293 is listed in the StagingDeployCash checklist and was merged on 2026-05-04, the same day the issue was reported.
    • The issue is reproduced only on staging (version 9.3.66-1), not production — consistent with a regression introduced by a newly-merged PR.
    • The issue is specific to the empty state shown when no members match the role filter — which is new functionality added entirely by this PR.

    Verification

    • Affected file: src/pages/workspace/WorkspaceMembersPage.tsx
    • PR feat: Added role filter to workspace members list #88293 modifies src/pages/workspace/WorkspaceMembersPage.tsx — confirmed.
    • The PR adds the listFooterContent empty state and applies contentContainerStyle: [styles.flex1, styles.mh100] to the SelectionList when shouldShowRoleFilterEmptyState is true.
    • styles.mh100 is defined in src/styles/utils/sizing.ts as {maxHeight: '100%'}, which constrains the ScrollView's content container height. In landscape mode where the viewport height is reduced, this cap prevents the content from expanding beyond the visible area, removing scrollability from the empty state component.

    Root Cause

    When the role filter empty state is displayed (shouldShowRoleFilterEmptyState === true), the code applies contentContainerStyle: [styles.flex1, styles.mh100] to the SelectionList. The styles.mh100 (maxHeight: '100%') caps the content container to the list's own height rather than allowing it to grow. In landscape orientation, the available vertical space is smaller, so the GenericEmptyStateComponent rendered in listFooterContent is clipped and the scroll gesture has no overflow content to scroll through. Removing styles.mh100 from the contentContainerStyle, or replacing the empty state approach with a non-footer-based rendering, would fix this.

  6. MelvinBot commented on May 4, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    When the role filter empty state is shown (shouldShowRoleFilterEmptyState === true), contentContainerStyle is set to [styles.flex1, styles.mh100]. The mh100 style applies maxHeight: '100%' (sizing.ts:44-46), which caps the FlashList's content container to the visible viewport height. This prevents the scroll area from growing beyond the screen, so when the empty state content (with minHeight: 400) overflows in landscape mode, it gets clipped with no way to scroll.

    In portrait mode the viewport is tall enough (~700px+) to fit the header + empty state card, so the bug doesn't manifest. In landscape the viewport shrinks to ~300-400px, causing overflow that can't be scrolled due to the maxHeight constraint.

    What changes do you think we should make in order to solve the problem?

    Remove styles.mh100 from the contentContainerStyle at WorkspaceMembersPage.tsx:1004. Change from [styles.flex1, styles.mh100] to [styles.flex1]. The flex1 alone allows the empty state to fill available space in portrait while permitting natural scrolling when content overflows in landscape.

    What alternative solutions did you explore? (Optional)

    • Wrapping the empty state in a separate ScrollView — rejected because the FlashList already provides scrolling; the issue is just the maxHeight constraint blocking it.
    • Replacing the listFooterContent approach with conditional rendering outside the list — would work but is more invasive and unnecessary when simply removing the maxHeight cap fixes the issue.
    Investigation details

    Data flow:

    1. User selects "Auditor" filter with no matching members → shouldShowRoleFilterEmptyState becomes true (line 635)
    2. contentContainerStyle set to [styles.flex1, styles.mh100] (line 1004)
    3. FlashList applies this to its content container (BaseSelectionList.tsx:573)
    4. GenericEmptyStateComponent renders as footer with minHeight: 400 (EmptyStateComponent/index.tsx:44)
    5. In landscape, total content exceeds viewport but maxHeight: '100%' prevents scrolling

    Causing PR: #88293


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  7. srikarparsi commented on May 4, 2026

    @srikarparsi
    Contributor

    Demoting this from a blocker as it is a niche flow (landscape mode)

  8. 28 remaining items

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on May 19, 2026
  10. melvin-bot commented on May 19, 2026

    @melvin-bot

    Current assignee @mallenexpensify is eligible for the Awaiting Payment assigner, not assigning anyone new.

  11. FitseTLT commented on May 19, 2026

    @FitseTLT
    Contributor

    No payment needed only checklist @mallenexpensify

  12. robertjchen commented on May 20, 2026

    @robertjchen
    Contributor

    thanks, closing this out! 🙇

  13. FitseTLT commented on May 20, 2026

    @FitseTLT
    Contributor

    But @robertjchen @mallenexpensify should handle the test first before closing.

  14. robertjchen commented on May 20, 2026

    @robertjchen
    Contributor

    ah, my bad- reopening

  15. melvin-bot commented on May 20, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    • ROLE: @FitseTLT paid $(AMOUNT) via Upwork (LINK)

    BugZero Checklist (@mallenexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  16. mallenexpensify commented on May 22, 2026

    @mallenexpensify
    Contributor

    ^ Test case created. Thx thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions