You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-20] Members - Empty state screen is not scrollable on landscape mode when applying role filter. #89554
Version Number: 9.3.66-1 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#88293 Email or phone of affected tester (no customers):ibellicotest+2250@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Motorola MotoG60 / Android 12 (Hybrid app) App Component: Workspace Settings
Action Performed:
Prerequisite: Account has a control workspace.
Prerequisite: Workspace has no member as "Auditor"
Open the Expensify app.
Navigate to "Workspaces" > "Members"
Tap on the members role filter and select "Auditor"
Note that an empty state screen appears if no member applies to the filter.
Switch to landscape mode.
Note that empty state screen is not completelly visible and can´t be scrolled.
Expected Result:
After applying the members role filter while in landscape mode, empty state screen should be scrollable.
Actual Result:
After applying the members role filter while in landscape mode, empty state screen is not completelly visible and can´t be scrolled.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #88293 - "feat: Added role filter to workspace members list" by @Uzaifm127 (High confidence) Related Issues: #87907
Recommendation: REVERT
PR #88293 introduced the role filter and the empty state for filtered member lists. The empty state rendering uses contentContainerStyle: [styles.flex1, styles.mh100] on the SelectionList, where mh100 resolves to maxHeight: '100%'. In landscape mode on Android, the screen height is small enough that this maxHeight: '100%' constraint on the list's content container caps the total scrollable area, causing the empty state (rendered via listFooterContent) to be clipped and non-scrollable.
The PR adds the listFooterContent empty state and applies contentContainerStyle: [styles.flex1, styles.mh100] to the SelectionList when shouldShowRoleFilterEmptyState is true.
styles.mh100 is defined in src/styles/utils/sizing.ts as {maxHeight: '100%'}, which constrains the ScrollView's content container height. In landscape mode where the viewport height is reduced, this cap prevents the content from expanding beyond the visible area, removing scrollability from the empty state component.
Root Cause
When the role filter empty state is displayed (shouldShowRoleFilterEmptyState === true), the code applies contentContainerStyle: [styles.flex1, styles.mh100] to the SelectionList. The styles.mh100 (maxHeight: '100%') caps the content container to the list's own height rather than allowing it to grow. In landscape orientation, the available vertical space is smaller, so the GenericEmptyStateComponent rendered in listFooterContent is clipped and the scroll gesture has no overflow content to scroll through. Removing styles.mh100 from the contentContainerStyle, or replacing the empty state approach with a non-footer-based rendering, would fix this.
When the role filter empty state is shown (shouldShowRoleFilterEmptyState === true), contentContainerStyle is set to [styles.flex1, styles.mh100]. The mh100 style applies maxHeight: '100%' (sizing.ts:44-46), which caps the FlashList's content container to the visible viewport height. This prevents the scroll area from growing beyond the screen, so when the empty state content (with minHeight: 400) overflows in landscape mode, it gets clipped with no way to scroll.
In portrait mode the viewport is tall enough (~700px+) to fit the header + empty state card, so the bug doesn't manifest. In landscape the viewport shrinks to ~300-400px, causing overflow that can't be scrolled due to the maxHeight constraint.
What changes do you think we should make in order to solve the problem?
Remove styles.mh100 from the contentContainerStyle at WorkspaceMembersPage.tsx:1004. Change from [styles.flex1, styles.mh100] to [styles.flex1]. The flex1 alone allows the empty state to fill available space in portrait while permitting natural scrolling when content overflows in landscape.
What alternative solutions did you explore? (Optional)
Wrapping the empty state in a separate ScrollView — rejected because the FlashList already provides scrolling; the issue is just the maxHeight constraint blocking it.
Replacing the listFooterContent approach with conditional rendering outside the list — would work but is more invasive and unnecessary when simply removing the maxHeight cap fixes the issue.
Investigation details
Data flow:
User selects "Auditor" filter with no matching members → shouldShowRoleFilterEmptyState becomes true (line 635)
contentContainerStyle set to [styles.flex1, styles.mh100] (line 1004)
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
Activity
melvin-bot commentedon May 4, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #88293
melvin-bot commentedon May 4, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 4, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon May 4, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #88293 - "feat: Added role filter to workspace members list" by @Uzaifm127 (High confidence)
Related Issues: #87907
Recommendation: REVERT
PR #88293 introduced the role filter and the empty state for filtered member lists. The empty state rendering uses
contentContainerStyle: [styles.flex1, styles.mh100]on the SelectionList, wheremh100resolves tomaxHeight: '100%'. In landscape mode on Android, the screen height is small enough that thismaxHeight: '100%'constraint on the list's content container caps the total scrollable area, causing the empty state (rendered vialistFooterContent) to be clipped and non-scrollable.Assigned: @Uzaifm127 (PR author), @FitseTLT, @srikarparsi (approving reviewers)
Labels:
DeployBlockerCashkept (frontend App bug); no label changes made.Detailed Analysis
Evidence
StagingDeployCashchecklist and was merged on 2026-05-04, the same day the issue was reported.Verification
src/pages/workspace/WorkspaceMembersPage.tsxsrc/pages/workspace/WorkspaceMembersPage.tsx— confirmed.listFooterContentempty state and appliescontentContainerStyle: [styles.flex1, styles.mh100]to the SelectionList whenshouldShowRoleFilterEmptyStateis true.styles.mh100is defined insrc/styles/utils/sizing.tsas{maxHeight: '100%'}, which constrains the ScrollView's content container height. In landscape mode where the viewport height is reduced, this cap prevents the content from expanding beyond the visible area, removing scrollability from the empty state component.Root Cause
When the role filter empty state is displayed (
shouldShowRoleFilterEmptyState === true), the code appliescontentContainerStyle: [styles.flex1, styles.mh100]to the SelectionList. Thestyles.mh100(maxHeight: '100%') caps the content container to the list's own height rather than allowing it to grow. In landscape orientation, the available vertical space is smaller, so theGenericEmptyStateComponentrendered inlistFooterContentis clipped and the scroll gesture has no overflow content to scroll through. Removingstyles.mh100from thecontentContainerStyle, or replacing the empty state approach with a non-footer-based rendering, would fix this.MelvinBot commentedon May 4, 2026
Proposal
What is the root cause of that problem?
When the role filter empty state is shown (
shouldShowRoleFilterEmptyState === true),contentContainerStyleis set to[styles.flex1, styles.mh100]. Themh100style appliesmaxHeight: '100%'(sizing.ts:44-46), which caps the FlashList's content container to the visible viewport height. This prevents the scroll area from growing beyond the screen, so when the empty state content (withminHeight: 400) overflows in landscape mode, it gets clipped with no way to scroll.In portrait mode the viewport is tall enough (~700px+) to fit the header + empty state card, so the bug doesn't manifest. In landscape the viewport shrinks to ~300-400px, causing overflow that can't be scrolled due to the
maxHeightconstraint.What changes do you think we should make in order to solve the problem?
Remove
styles.mh100from thecontentContainerStyleatWorkspaceMembersPage.tsx:1004. Change from[styles.flex1, styles.mh100]to[styles.flex1]. Theflex1alone allows the empty state to fill available space in portrait while permitting natural scrolling when content overflows in landscape.What alternative solutions did you explore? (Optional)
ScrollView— rejected because the FlashList already provides scrolling; the issue is just themaxHeightconstraint blocking it.listFooterContentapproach with conditional rendering outside the list — would work but is more invasive and unnecessary when simply removing themaxHeightcap fixes the issue.Investigation details
Data flow:
shouldShowRoleFilterEmptyStatebecomestrue(line 635)contentContainerStyleset to[styles.flex1, styles.mh100](line 1004)BaseSelectionList.tsx:573)GenericEmptyStateComponentrenders as footer withminHeight: 400(EmptyStateComponent/index.tsx:44)maxHeight: '100%'prevents scrollingCausing PR: #88293
Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.srikarparsi commentedon May 4, 2026
Demoting this from a blocker as it is a niche flow (landscape mode)
28 remaining items
melvin-bot commentedon May 19, 2026
Current assignee @mallenexpensify is eligible for the Awaiting Payment assigner, not assigning anyone new.
FitseTLT commentedon May 19, 2026
No payment needed only checklist @mallenexpensify
robertjchen commentedon May 20, 2026
thanks, closing this out! 🙇
FitseTLT commentedon May 20, 2026
But @robertjchen @mallenexpensify should handle the test first before closing.
robertjchen commentedon May 20, 2026
ah, my bad- reopening
melvin-bot commentedon May 20, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon May 22, 2026
^ Test case created. Thx thanks