Skip to content

[Due for payment 2026-05-18] [Odometer] Edited start reading not reflected on Odometer tab after returning from confirmation page #89633

Closed

Description

@Julesssss

Problem

When a saved-for-later odometer expense is reopened and the start reading is edited from the confirmation page, navigating back to the Odometer tab still shows the old start reading value in the input instead of the edited one.

Steps to reproduce:

  1. Add a start reading and end reading in the Odometer request
  2. Tap Save for later
  3. Reopen the odometer request
  4. Go to the confirmation page
  5. Click on the distance and edit the start reading
  6. Save
  7. From the confirmation page, tap the back button
  8. On the Odometer request page, the old start reading value is displayed in the input

Expected: The Odometer tab should display the edited start reading value, matching what's shown on the confirmation page.

Context: Regression from Odometer save-for-later PR #87726. The ODOMETER_DRAFT Onyx draft is not being updated when readings are edited via the confirmation page's distance edit flow, so the draft hydrates the input with stale data on return.

Repro video: https://github.com/user-attachments/assets/e20a9f15-eb02-42de-8151-c03bc8c46b6f

Originally reported in PR #87726 comment.

Issue OwnerCurrent Issue Owner: @DylanDylann

Activity

  1. jakubkalinski0 commented on May 6, 2026

    @jakubkalinski0
    Member

    Working on this now

  2. Julesssss commented on May 6, 2026

    @Julesssss
    ContributorAuthor

    @DylanDylann ready for your review

  3. Julesssss commented on May 7, 2026

    @Julesssss
    ContributorAuthor

    PR merged, I approved the final changes, but would appreciate a 2nd check @DylanDylann . Thanks

  4. mitarachim commented on May 8, 2026

    @mitarachim

    Deploy Blocker #90026 was identified to be related to the PR #89774 that attempted to fix this issue.

  5. melvin-bot commented on May 8, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  6. changed the title [-][Odometer] Edited start reading not reflected on Odometer tab after returning from confirmation page[/-] [+][Due for payment 2026-05-18] [Odometer] Edited start reading not reflected on Odometer tab after returning from confirmation page[/+] on May 11, 2026
  7. melvin-bot commented on May 11, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  8. melvin-bot commented on May 11, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.69-18 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-05-18. 🎊

    For reference, here are some details about the assignees on this issue:

  9. melvin-bot commented on May 15, 2026

    @melvin-bot

    @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

  10. melvin-bot commented on May 17, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  11. DylanDylann commented on May 18, 2026

    @DylanDylann
    Contributor

    No payment required. Let's close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions