Skip to content

[Due for payment 2026-05-15] [Due for payment 2026-05-13] Android - Odometer - Receipt is not visible after relaunching app and it loads infinitely #89682

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.67-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #87726
Email or phone of affected tester (no customers): josdjnosdjionjsdonjisod@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Samsung Galaxy S25 FE / Android 16
App Component: Money Requests

Action Performed:

  1. Launch Expensify app.
  2. Open FAB > Track distance > Odometer.
  3. Enter start and end reading.
  4. Add a receipt to start reading.
  5. Tap Save for later.
  6. Kill and relaunch the app.
  7. Open FAB > Track distance > Odometer.
  8. Tap on the receipt added from Step 4.

Expected Result:

Receipt will be visible after relaunching app.

Actual Result:

Receipt is not visible after relaunching app and it loads infinitely.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7145317_1778009534012.az_recorder_20260506_032937_1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @DylanDylann

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on May 6, 2026
  2. melvin-bot commented on May 6, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #87726

  3. melvin-bot commented on May 6, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on May 6, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. OSBotify commented on May 6, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #87726 - "Add Save for later to Odometer screen" by @jakubkalinski0 (High confidence)
    Related Issues: None

    Recommendation: REVERT

    PR #87726 introduced a new "Save for later" feature for the Odometer screen that is directly reproducing this bug. The feature does not exist in production, reverting the PR removes the broken behavior entirely without risk of a production regression.

    Assigned: @jakubkalinski0 (PR author), @Julesssss, @DylanDylann (approving reviewers)
    Labels: DeployBlockerCash kept (frontend App PR caused the issue). DeployBlocker removed — no backend change is needed.

    Detailed Analysis

    Evidence

    Verification

    • Affected files from the PR that relate to the bug:
      • src/libs/actions/OdometerTransactionUtils.ts — introduces saveOdometerDraft, hydrateOdometerDraftIntoTransaction, deserializeOdometerDraftImage, and serializeOdometerDraftImage.
      • src/hooks/useOdometerDraftHydrator.ts — new hook responsible for re-hydrating persisted draft images back into the transaction on mount.
      • src/hooks/useRestartOnOdometerImagesFailure/index.ts — significantly modified to co-operate with the new draft; now waits for odometerDraftStatus to resolve before proceeding.
      • src/pages/iou/request/step/IOURequestStepDistanceOdometer.tsx — wires the "Save for later" button and integrates useOdometerDraftHydrator.
      • src/ONYXKEYS.ts — adds the new ODOMETER_DRAFT Onyx key.
    • The PR modifies all files in the distance-odometer request flow that handle receipt images and draft persistence.

    Root Cause

    On Android (native), the PR stores image file URIs directly in the persisted ODOMETER_DRAFT Onyx key (the code path getPlatform() !== CONST.PLATFORM.WEB returns the URI as-is rather than converting to base64). After the app is killed and relaunched, the draft URI is rehydrated into the transaction via hydrateOdometerDraftIntoTransaction. However, when the user taps the receipt thumbnail, the image viewer attempts to load from that URI. The useRestartOnOdometerImagesFailure hook guards on hasVerifiedBlobs, and the blob-check path for native file URIs (not blob: prefixed) may never mark asyncVerificationPassed as true — specifically the updated code now filters urlsToCheck only to entries with blob: prefixed paths, meaning an empty array flows through Promise.all immediately, yet the component may still render a stuck loading indicator because the receipt source URI from the draft is a stale Android content URI that is no longer resolvable after a full app restart. The infinite loading is the fallback UI when the image cannot be fetched.

  6. removed
    DeployBlockerIndicates it should block deploying the API
    on May 6, 2026
  7. 7 remaining items

  8. allgandalf commented on May 6, 2026

    @allgandalf
    Contributor

    tffff, sorry didn't mean to post

  9. IuliiaHerets commented on May 6, 2026

    @IuliiaHerets

    Xiaomi Redmi Note 10 / Android 12
    App 9.3.67-11
    Not repro

    Screenrecorder-2026-05-06-21-30-24-689.mp4
  10. added and removed
    ReviewingHas a PR in review
    on May 6, 2026
  11. changed the title [-]Android - Odometer - Receipt is not visible after relaunching app and it loads infinitely[/-] [+][Due for payment 2026-05-13] Android - Odometer - Receipt is not visible after relaunching app and it loads infinitely[/+] on May 6, 2026
  12. melvin-bot commented on May 6, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on May 6, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.67-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-05-13. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on May 6, 2026

    @melvin-bot

    @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. changed the title [-][Due for payment 2026-05-13] Android - Odometer - Receipt is not visible after relaunching app and it loads infinitely[/-] [+][Due for payment 2026-05-15] [Due for payment 2026-05-13] Android - Odometer - Receipt is not visible after relaunching app and it loads infinitely[/+] on May 8, 2026
  16. melvin-bot commented on May 8, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.68-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-05-15. 🎊

    For reference, here are some details about the assignees on this issue:

  17. melvin-bot commented on May 8, 2026

    @melvin-bot

    @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions