Skip to content

[Due for payment 2026-07-08] [Odometer] Show discard changes modal when switching tabs with unsaved values #89940

Closed

Description

@Julesssss

Problem

When a user has filled in values in the odometer flow and switches tabs without saving, the values are lost without warning. This is inconsistent with the existing close-flow behavior, which shows a discard confirmation modal when users click outside to close.

Solution

Display the discard changes confirmation modal when the user switches tabs with unsaved filled-in values, matching the existing close-flow behavior.

WIP PR: #89612

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. Julesssss commented on May 18, 2026

    @Julesssss
    ContributorAuthor

    PR was blocked, now underway again

  2. jakubkalinski0 commented on May 22, 2026

    @jakubkalinski0
    Member

    Still holding PR on #90445 -> good progress being done there

  3. jakubkalinski0 commented on May 26, 2026

    @jakubkalinski0
    Member

    We are close to getting #90445 merged. After that, work on this issue will be resumed

  4. Julesssss commented on May 27, 2026

    @Julesssss
    ContributorAuthor

    #90445 merged 🎉

  5. 21 remaining items

  6. Julesssss commented on Jul 7, 2026

    @Julesssss
    ContributorAuthor

    Deployed, due for payment tomorrow

  7. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jul 7, 2026
  8. melvin-bot commented on Jul 7, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  9. melvin-bot commented on Jul 7, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  10. mallenexpensify commented on Jul 9, 2026

    @mallenexpensify
    Contributor

    @DylanDylann from the C+ doc

    If there are posts on the PR or issue that reference a regression or deploy blocker, C+ posts on the issue and confirms regression (which will reduce pay by 50%) or provides reasoning why they shouldn’t be considered. If the C+ doesn’t update the issue, the contributor manager making the payment will assume any mention of a regression or deploy blockers reduces the issue amount.

  11. DylanDylann commented on Jul 9, 2026

    @DylanDylann
    Contributor

    @mallenexpensify sorry, we don't require payment here. Please close this issue

  12. DylanDylann commented on Jul 13, 2026

    @DylanDylann
    Contributor

    @Julesssss Could you help to close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions