[$250] IOS/Android - App crashed after tap on download in optional menu

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Launch the app
Log in with any account
Find the chat where you can download the file
Hold the finger on any type of file (mp4, png., mov)
Tap download

Expected Result:

Able to download the file in optional menu

Actual Result:

App crashed after tap on download in optional menu

Workaround:

Unknown

Platform:

Where is this issue occurring?

iOS

Version Number: 1.1.61.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Image.from.iOS.20.MP4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

@MariaHCD

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Seems like this crash is relevant. Worth noting that this crash is only reported on Android realme devices, but the bug is reproduced in iOS as well.

Found a couple seemingly related issues:

App is crashing when i try to download in realme devices (Android 9) joltup/rn-fetch-blob#694
Error receiving broadcast Intent act=android.intent.action.DOWNLOAD_COMPLETE joltup/rn-fetch-blob#236

@roryabraham

Thanks, @roryabraham! From those issues, it looks this needs some more investigation:

If adding android:requestLegacyExternalStorage="true" to the Android manifest would help solved this and/or;
Whether the package rn-fetch-blob has released a fix for this.

@arielgreen

Triggered auto assignment to @arielgreen (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

https://www.upwork.com/jobs/~015cbb750a025a202d

@chiragsalian

Triggered auto assignment to @chiragsalian (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Proposal:

App/src/libs/fileDownload/getAttachmentDetails.js

Lines 21 to 24 in 20c1174

    
           const previewSourceURL = html.match(PREVIEW_SOURCE_REGEX)[1].replace( 
        
               Config.EXPENSIFY.EXPENSIFY_URL, 
        
               Config.EXPENSIFY.URL_API_ROOT, 
        
           );

crash is happening because of these lines, anchor tag does not have ATTACHMENT_PREVIEW_ATTRIBUTE = "src", and also we are not using previewSourceURL from the getAttachmentName anywhere, so we can remove these lines,

and anchor tag has no data-name attribute, so we have to remove this line from here,

App/src/libs/fileDownload/getAttachmentDetails.js

Line 29 in 20c1174

const originalFileName = html.match(ORIGINAL_FILENAME_REGEX)[1];

and can get filename for anchor tag as we are getting here

App/src/components/HTMLEngineProvider/HTMLRenderers/AnchorRenderer.js

Line 20 in 5096dea

const displayName = lodashGet(props.tnode, 'domNode.children[0].data', '');

@kbecciv

@kbecciv I've been trying to reproduce this but I am just not able to. I've attempted to download pdf, png, and mp4 files. My installed version is 1.1.62-0 and my local version is 1.1.64-0.

@jayeshmangwani Thank you for the proposal, are you able to reproduce it at your end?

@mananjadhav

@mananjadhav Yes, I am able to reproduce on my side,
I have tried with zip and mp4 files and both are crashing, latest main branch ( "version": "1.1.62-0")
please check this video for reference

9010-crash-issue.mov

@mananjadhav

@mananjadhav yes this issue has been handled in "version": "1.1.64-0", it was happening in "version": "1.1.62-0" and now it's fixed

@jayeshmangwani

Thanks for responding @jayeshmangwani. Appreciate your help.

@arielgreen We can wait for one KI test and then close this one out.

@mananjadhav

@mananjadhav are we good to close?

@arielgreen

Yeah @arielgreen, good to close.

Issue not reproducible during KI retests. (First week)

Navigation Menu

Repository navigation

[$250] IOS/Android - App crashed after tap on download in optional menu #9010

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

7 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const previewSourceURL = html.match(PREVIEW_SOURCE_REGEX)[1].replace(
	Config.EXPENSIFY.EXPENSIFY_URL,
	Config.EXPENSIFY.URL_API_ROOT,
	);

[$250] IOS/Android - App crashed after tap on download in optional menu #9010

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

Activity

melvin-bot commented on May 13, 2022

roryabraham commented on May 15, 2022

roryabraham commented on May 15, 2022

MariaHCD commented on May 17, 2022

melvin-bot commented on May 17, 2022

arielgreen commented on May 17, 2022

7 remaining items

melvin-bot commented on May 17, 2022

jayeshmangwani commented on May 18, 2022

mananjadhav commented on May 19, 2022

jayeshmangwani commented on May 19, 2022

jayeshmangwani commented on May 19, 2022

mananjadhav commented on May 20, 2022

arielgreen commented on May 27, 2022

mananjadhav commented on Jun 2, 2022

mvtglobally commented on Jun 7, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions