You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-20] [Due for payment 2026-05-18] Expense - Distance error remains after updating again to original amount. #90105
Version Number: 9.3.69-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#89858 Email or phone of affected tester (no customers):ibellicotest+2250@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome App Component: Money Requests
Action Performed:
Prerequisite: Account has at least one workspace.
Open the staging.new.expensify.com website.
Open any workspace chat.
Create a map distance expense.
Open the just created expense.
Click on "DIstance" > "Manual"
Edit the distance and save.
After being redirected to report, note that after some time, a "Distance exceeds the calculated route of XX" error appears.
Click on "DIstance" > "Map"
Click on any waypoint and on suggestions list, select the same waypoint again.
Click on "Save"
Note that when redirected to report, distance is updated to original value again, but error remains displayed.
Expected Result:
"Distance exceeds the calculated route of XX" error message should be cleared after updating distance to original value again.
Actual Result:
"Distance exceeds the calculated route of XX" error message remains visible after distance is updated to original value again.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #89858 - "fixed manual distance tab blockers" by @mukhrr (High confidence) Related Issues: #83781
Recommendation: REVERT
PR #89858 introduced a regression in the submitWaypoints (map tab save) logic: when the user re-selects the same waypoints, the code short-circuits and navigates back without clearing the increasedDistance violation that was previously set by a manual distance edit. Reverting this PR is the cleanest fix.
PR fixed manual distance tab blockers #89858 substantially rewrote src/pages/iou/request/step/IOURequestStepDistance.tsx, adding new submitWaypoints and submitManualDistance callback functions.
The bug reproduces as follows: editing distance manually (via the Manual tab) sets an increasedDistance violation on the transaction. Then switching to the Map tab and re-selecting the same waypoint triggers submitWaypoints. Inside submitWaypoints, line 524 checks haveWaypointAddressesChanged(transactionBackup?.comment?.waypoints, waypoints) — since the user re-selected the identical waypoint, this returns false, causing an early return at line 525-527 without calling updateMoneyRequestDistance. Because updateMoneyRequestDistance was never called, the violation-clearing logic in getUpdateMoneyRequestParams (which filters out INCREASED_DISTANCE violations optimistically) is never executed, so the error banner persists.
Bug is staging-only (new feature, does not exist in production).
PR fixed manual distance tab blockers #89858 also modifies src/libs/actions/IOU/UpdateMoneyRequest.ts (73 additions, 12 deletions), which contains the violation-clearing logic for INCREASED_DISTANCE violations.
The increasedDistance violation string ("Distance exceeds the calculated route of XX") is defined at src/languages/en.ts:8421 and resolved in src/libs/Violations/ViolationsUtils.ts:761.
The clearing of INCREASED_DISTANCE violations happens at src/libs/actions/IOU/UpdateMoneyRequest.ts:1396-1400, which is only reached when updateMoneyRequestDistance is called — but this call is skipped when waypoints are unchanged.
Root Cause
In submitWaypoints (the map tab save handler added by PR #89858), when the user re-selects the same waypoint address, haveWaypointAddressesChanged returns false and the function returns early without making an API call. This is correct for the no-change case in isolation, but it fails to account for the fact that a prior manual distance edit may have set an increasedDistance violation that now needs to be cleared. The fix should either: (a) check for a pending increasedDistance violation and still call updateMoneyRequestDistance to trigger server re-evaluation, or (b) revert the PR so the old logic handles the case.
changed the title [-]Expense - Distance error remains after updating again to original amount.[/-][+][Due for payment 2026-05-18] Expense - Distance error remains after updating again to original amount.[/+]on May 11, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.69-18 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@aimane-chnaif The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2026-05-18] Expense - Distance error remains after updating again to original amount.[/-][+][Due for payment 2026-05-20] [Due for payment 2026-05-18] Expense - Distance error remains after updating again to original amount.[/+]on May 13, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.72-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@aimane-chnaif The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon May 9, 2026
@youssef-lr recently merged #89858, but they are OOO right now, so I'll auto-assign someone else.
melvin-bot commentedon May 9, 2026
Triggered auto assignment to @Valforte (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 9, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 9, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon May 9, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #89858 - "fixed manual distance tab blockers" by @mukhrr (High confidence)
Related Issues: #83781
Recommendation: REVERT
PR #89858 introduced a regression in the
submitWaypoints(map tab save) logic: when the user re-selects the same waypoints, the code short-circuits and navigates back without clearing theincreasedDistanceviolation that was previously set by a manual distance edit. Reverting this PR is the cleanest fix.Assigned: @mukhrr (PR author), @aimane-chnaif (approving reviewer), @youssef-lr (approving reviewer)
Labels:
DeployBlockerCashkept (Frontend bug in Expensify/App). No label changes made.📋 Detailed Analysis
Evidence
src/pages/iou/request/step/IOURequestStepDistance.tsx, adding newsubmitWaypointsandsubmitManualDistancecallback functions.increasedDistanceviolation on the transaction. Then switching to the Map tab and re-selecting the same waypoint triggerssubmitWaypoints. InsidesubmitWaypoints, line 524 checkshaveWaypointAddressesChanged(transactionBackup?.comment?.waypoints, waypoints)— since the user re-selected the identical waypoint, this returnsfalse, causing an early return at line 525-527 without callingupdateMoneyRequestDistance. BecauseupdateMoneyRequestDistancewas never called, the violation-clearing logic ingetUpdateMoneyRequestParams(which filters outINCREASED_DISTANCEviolations optimistically) is never executed, so the error banner persists.Verification
src/pages/iou/request/step/IOURequestStepDistance.tsxgh pr view).src/libs/actions/IOU/UpdateMoneyRequest.ts(73 additions, 12 deletions), which contains the violation-clearing logic forINCREASED_DISTANCEviolations.increasedDistanceviolation string ("Distance exceeds the calculated route of XX") is defined atsrc/languages/en.ts:8421and resolved insrc/libs/Violations/ViolationsUtils.ts:761.INCREASED_DISTANCEviolations happens atsrc/libs/actions/IOU/UpdateMoneyRequest.ts:1396-1400, which is only reached whenupdateMoneyRequestDistanceis called — but this call is skipped when waypoints are unchanged.Root Cause
In
submitWaypoints(the map tab save handler added by PR #89858), when the user re-selects the same waypoint address,haveWaypointAddressesChangedreturnsfalseand the function returns early without making an API call. This is correct for the no-change case in isolation, but it fails to account for the fact that a prior manual distance edit may have set anincreasedDistanceviolation that now needs to be cleared. The fix should either: (a) check for a pendingincreasedDistanceviolation and still callupdateMoneyRequestDistanceto trigger server re-evaluation, or (b) revert the PR so the old logic handles the case.5 remaining items
melvin-bot commentedon May 11, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon May 11, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
Beamanator commentedon May 11, 2026
closing since feature was hidden by #90178 in production - fixes being handled in #83781
[-]Expense - Distance error remains after updating again to original amount.[/-][+][Due for payment 2026-05-18] Expense - Distance error remains after updating again to original amount.[/+]melvin-bot commentedon May 11, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.69-18 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-18. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 11, 2026
@aimane-chnaif The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][Due for payment 2026-05-18] Expense - Distance error remains after updating again to original amount.[/-][+][Due for payment 2026-05-20] [Due for payment 2026-05-18] Expense - Distance error remains after updating again to original amount.[/+]melvin-bot commentedon May 13, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.72-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 13, 2026
@aimane-chnaif The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
lanitochka17 commentedon May 13, 2026
Deploy Blocker ##90558 was identified to be related to the PR ##90131 that attempted to fix this issue.