Skip to content

[Due for payment 2026-05-20] [Due for payment 2026-05-18] Spend - Not here page opens after navigating to expense via arrow #90180

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.69-4
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #88527
Email or phone of affected tester (no customers): jsdonijsdoijsodnjsod@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Search

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create two expenses.
  4. Go to Spend > Reports.
  5. Open the report.
  6. Open any expense.
  7. Send a message in transaction thread.
  8. Right click on the message > Reply in thread.
  9. Click on the parent message.
  10. Click next or previous arrow.

Expected Result:

Expense report will load without issue.

Actual Result:

Not here page opens after navigating to expense via arrow.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7150620_1778500114011.21.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on May 11, 2026
  2. melvin-bot commented on May 11, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #88527

  3. melvin-bot commented on May 11, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on May 11, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. OSBotify commented on May 11, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #88527 - "Navigate to report thread in RHP when viewing a report in a right docked modal" by @WojtekBoman (High confidence)
    Related Issues: #88532

    Recommendation: REVERT

    PR #88527 introduced a navigation change in ParentNavigationSubtitle.tsx that routes to ROUTES.SEARCH_REPORT whenever isReportInRHP is true and the focused navigator is RIGHT_MODAL_NAVIGATOR. This change is too broad and causes incorrect navigation state when the "Not Here" page is triggered after clicking next/previous arrows in the expense report carousel.

    Assigned: @WojtekBoman (PR author), @mountiny (approving reviewer) from highest-confidence causing PR only
    Labels: DeployBlockerCash kept (frontend App PR is the cause). DeployBlocker removed — the fix requires changes to the App repo, not the backend.

    Detailed Analysis

    Evidence

    Verification

    • Affected files: src/components/ParentNavigationSubtitle.tsx and src/libs/Navigation/helpers/isSearchTopmostFullScreenRoute.ts — both modified by PR Navigate to report thread in RHP when viewing a report in a right docked modal #88527.
    • The PR added a new code path in ParentNavigationSubtitle.tsx (lines 194–200 in the current file): when isReportInRHP is true (i.e., the current route is SCREENS.RIGHT_MODAL.SEARCH_REPORT), it unconditionally navigates to ROUTES.SEARCH_REPORT with the parentReportID. The previous version of this block only triggered this when lastRoute?.name === SCREENS.RIGHT_MODAL.EXPENSE_REPORT, which was a much narrower condition.
    • The PR also changed isSearchTopmostFullScreenRoute.ts and isReportTopmostSplitNavigator.ts to use a new getTopmostFullScreenRoute helper that looks at TAB_NAVIGATOR routes instead of full-screen routes. This changes which navigator is considered "topmost" in various states.

    Root Cause

    When the user navigates to a reply thread inside a SEARCH_REPORT RHP and then clicks the parent message link, PR #88527's new code calls Navigation.navigate(ROUTES.SEARCH_REPORT.getRoute({reportID: parentReportID, ...})). This pushes a new SEARCH_REPORT entry on the RHP stack with the parent expense report's ID.

    The expense report loaded via this new SEARCH_REPORT route is the transaction thread's parent report — a regular expense report — but it ends up in a SEARCH_REPORT screen that also hosts the next/previous carousel (MoneyRequestReportNavigation). When the user clicks the next or previous arrow, Navigation.setParams({reportID: nextReportId}) updates the route's reportID parameter to a different expense report from the search list. However, the navigation state is now in a configuration where the new reportID either (a) does not match what the SearchMoneyRequestReportPage expects for its report type, or (b) triggers shouldShowAccessErrorPage to become true because the report data does not satisfy the validity checks (e.g., doesReportIDLookValid, hasAnyTransactions). The result is FullPageNotFoundView being rendered — the "Not here" page.

    The root issue is that the new isReportInRHP branch in ParentNavigationSubtitle.tsx does not account for the case where the SEARCH_REPORT being navigated to is a thread report (not an expense report directly addressable in the search carousel), leaving the arrow navigation in a broken state.

  6. 5 remaining items

  7. changed the title [-]Spend - Not here page opens after navigating to expense via arrow[/-] [+][Due for payment 2026-05-18] Spend - Not here page opens after navigating to expense via arrow[/+] on May 11, 2026
  8. melvin-bot commented on May 11, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  9. melvin-bot commented on May 11, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.69-18 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-05-18. 🎊

    For reference, here are some details about the assignees on this issue:

  10. melvin-bot commented on May 11, 2026

    @melvin-bot

    @mountiny @WojtekBoman The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  11. changed the title [-][Due for payment 2026-05-18] Spend - Not here page opens after navigating to expense via arrow[/-] [+][Due for payment 2026-05-20] [Due for payment 2026-05-18] Spend - Not here page opens after navigating to expense via arrow[/+] on May 13, 2026
  12. melvin-bot commented on May 13, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.72-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-05-20. 🎊

    For reference, here are some details about the assignees on this issue:

  13. melvin-bot commented on May 13, 2026

    @melvin-bot

    @mountiny @WojtekBoman The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. mitarachim commented on May 25, 2026

    @mitarachim
    Author

    Deploy Blocker #91603 was identified to be related to the PR #90680 that attempted to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions