You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-29] Expense - Partial skeleton loader briefly appears in the report after creating expense #90270
Version Number: 9.3.70-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#89791 Email or phone of affected tester (no customers):sdsdjoijdoisnjodis@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat.
Create an empty report.
Open the report.
Create an expense.
Expected Result:
Skeleton loader will not appear in the report after creating expense (production).
Actual Result:
Partial skeleton loader briefly appears in the report after creating expense.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #89791 - "Re-land smooth post-submit Spend tab navigation with Android skeleton fix" by @JakubKorytko (High confidence) Related Issues: #89669 (prior deploy blocker that this PR attempted to fix)
Recommendation: REVERT
PR #89791 introduced new skeleton loading logic in MoneyRequestReportActionsList.tsx (the isAwaitingDeferredTransaction + ReportActionsListLoadingSkeleton path) that causes a partial skeleton loader to briefly appear in the report after creating an expense. The bug is staging-only and directly tied to this PR which merged on 2026-05-10.
Assigned: @JakubKorytko (PR author), @ShridharGoel, @mountiny (approving reviewers) Labels: DeployBlockerCash is already present and should remain (Frontend bug). No label changes needed — DeployBlocker is not present.
The bug reproduces on staging but NOT on production — staging version is 9.3.70-0 which includes this PR (merged 2026-05-10T19:10:21Z)
The issue describes a "partial skeleton loader briefly appears in the report after creating expense," which is the exact behavior introduced by the new deferred skeleton logic in this PR
Verification
The PR modifies src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx — the file that directly controls the skeleton loader rendering in the report view
The PR introduced ReportActionsListLoadingSkeleton rendering gated on isAwaitingDeferredTransaction, which is a new non-reactive check (hasDeferredWriteForReport reads a module-level Map)
The PR also introduced src/pages/inbox/report/MoneyReportContentCreated.tsx and modified MoneyReportView.tsx with isTotalPending logic — changes to the exact components involved in the expense creation flow
Root Cause
The PR added isAwaitingDeferredTransaction logic in MoneyRequestReportActionsList.tsx that renders a ReportActionsListLoadingSkeleton when a deferred write is pending for the report and the transaction list is empty. Because hasDeferredWriteForReport is non-reactive (reads a module-level Map), there are timing windows where the skeleton renders briefly before React reconciles the Onyx state update that populates transactions. This causes the observable "partial skeleton loader" flash after creating an expense on an empty report.
PR #89791 introduced a deferred-write mechanism for smooth post-submit navigation. When an expense is created on an empty report, there's a brief window where:
The deferred write has been reserved (via reserveDeferredWriteChannel) but hasn't flushed yet, so transactions are still empty
shouldWaitForTransactions returns true because transactions.length === 0 and hasPendingDismissWrite is true
Once the deferred write flushes and the optimistic transaction lands in Onyx, the skeleton disappears — but it's visible for a frame or two, producing the reported flash.
The same PR also added a parallel skeleton path in MoneyRequestReportActionsList (isAwaitingDeferredTransaction → ReportActionsListLoadingSkeleton with FadeIn/FadeOut animation), which can produce a second brief flash if that code path is reached first.
What changes do you think we should make in order to solve the problem?
The skeleton in MoneyRequestReportView should not be shown when the only reason shouldWaitForTransactions is true is a pending deferred write (hasPendingDismissWrite). The deferred-write skeleton is already handled downstream by MoneyRequestReportActionsList (via isAwaitingDeferredTransaction), so shouldWaitForTransactions is double-covering this case and producing the flash at a higher level.
In shouldWaitForTransactions, the hasPendingDismissWrite condition should be removed from the isStillLoadingData check. The deferred-write case is already guarded by MoneyRequestReportActionsList's isAwaitingDeferredTransaction check, which renders its own skeleton at the correct level without triggering the full-page InitialLoadingSkeleton.
What alternative solutions did you explore? (Optional)
An alternative would be to suppress the InitialLoadingSkeleton render in MoneyRequestReportView when shouldWaitForTransactions is true solely due to hasPendingDismissWrite (i.e., add a separate flag and skip the skeleton at the view level). However, removing hasPendingDismissWrite from shouldWaitForTransactions is cleaner since the deferred-write skeleton is already handled at the correct layer.
Investigation details
Related issue:#87032 ("Skeleton loading, then empty state is shown in Reports after creating expense via FAB") is open and may share the same root cause around the shouldWaitForTransactions / deferred-write interaction.
Evidence chain:
shouldWaitForTransactions includes hasPendingDismissWrite (line 142-145) as a condition for isStillLoadingData
Independently, MoneyRequestReportActionsList already handles the deferred-write case with its own skeleton, making the higher-level skeleton redundant for this path
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.79-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@ShridharGoel The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon May 11, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #89791
melvin-bot commentedon May 11, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 12, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon May 12, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #89791 - "Re-land smooth post-submit Spend tab navigation with Android skeleton fix" by @JakubKorytko (High confidence)
Related Issues: #89669 (prior deploy blocker that this PR attempted to fix)
Recommendation: REVERT
PR #89791 introduced new skeleton loading logic in
MoneyRequestReportActionsList.tsx(theisAwaitingDeferredTransaction+ReportActionsListLoadingSkeletonpath) that causes a partial skeleton loader to briefly appear in the report after creating an expense. The bug is staging-only and directly tied to this PR which merged on 2026-05-10.Assigned: @JakubKorytko (PR author), @ShridharGoel, @mountiny (approving reviewers)
Labels:
DeployBlockerCashis already present and should remain (Frontend bug). No label changes needed —DeployBlockeris not present.Detailed Analysis
Evidence
9.3.70-0which includes this PR (merged 2026-05-10T19:10:21Z)Verification
src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx— the file that directly controls the skeleton loader rendering in the report viewReportActionsListLoadingSkeletonrendering gated onisAwaitingDeferredTransaction, which is a new non-reactive check (hasDeferredWriteForReportreads a module-level Map)src/pages/inbox/report/MoneyReportContentCreated.tsxand modifiedMoneyReportView.tsxwithisTotalPendinglogic — changes to the exact components involved in the expense creation flowRoot Cause
The PR added
isAwaitingDeferredTransactionlogic inMoneyRequestReportActionsList.tsxthat renders aReportActionsListLoadingSkeletonwhen a deferred write is pending for the report and the transaction list is empty. BecausehasDeferredWriteForReportis non-reactive (reads a module-level Map), there are timing windows where the skeleton renders briefly before React reconciles the Onyx state update that populates transactions. This causes the observable "partial skeleton loader" flash after creating an expense on an empty report.MelvinBot commentedon May 12, 2026
Proposal
What is the root cause of that problem?
PR #89791 introduced a deferred-write mechanism for smooth post-submit navigation. When an expense is created on an empty report, there's a brief window where:
reserveDeferredWriteChannel) but hasn't flushed yet, so transactions are still emptyshouldWaitForTransactionsreturnstruebecausetransactions.length === 0andhasPendingDismissWriteistrueshouldShowOpenReportLoadingSkeletonevaluate totrue, rendering the fullInitialLoadingSkeletonOnce the deferred write flushes and the optimistic transaction lands in Onyx, the skeleton disappears — but it's visible for a frame or two, producing the reported flash.
The same PR also added a parallel skeleton path in
MoneyRequestReportActionsList(isAwaitingDeferredTransaction→ReportActionsListLoadingSkeletonwithFadeIn/FadeOutanimation), which can produce a second brief flash if that code path is reached first.What changes do you think we should make in order to solve the problem?
The skeleton in
MoneyRequestReportViewshould not be shown when the only reasonshouldWaitForTransactionsistrueis a pending deferred write (hasPendingDismissWrite). The deferred-write skeleton is already handled downstream byMoneyRequestReportActionsList(viaisAwaitingDeferredTransaction), soshouldWaitForTransactionsis double-covering this case and producing the flash at a higher level.In
shouldWaitForTransactions, thehasPendingDismissWritecondition should be removed from theisStillLoadingDatacheck. The deferred-write case is already guarded byMoneyRequestReportActionsList'sisAwaitingDeferredTransactioncheck, which renders its own skeleton at the correct level without triggering the full-pageInitialLoadingSkeleton.What alternative solutions did you explore? (Optional)
An alternative would be to suppress the
InitialLoadingSkeletonrender inMoneyRequestReportViewwhenshouldWaitForTransactionsistruesolely due tohasPendingDismissWrite(i.e., add a separate flag and skip the skeleton at the view level). However, removinghasPendingDismissWritefromshouldWaitForTransactionsis cleaner since the deferred-write skeleton is already handled at the correct layer.Investigation details
Related issue: #87032 ("Skeleton loading, then empty state is shown in Reports after creating expense via FAB") is open and may share the same root cause around the
shouldWaitForTransactions/ deferred-write interaction.Evidence chain:
shouldWaitForTransactionsincludeshasPendingDismissWrite(line 142-145) as a condition forisStillLoadingDatashouldShowOpenReportLoadingSkeletonwhich rendersInitialLoadingSkeletonMoneyRequestReportActionsListalready handles the deferred-write case with its own skeleton, making the higher-level skeleton redundant for this pathNext Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.21 remaining items
melvin-bot commentedon May 22, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 22, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.79-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-29. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 22, 2026
@ShridharGoel The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon May 26, 2026
@ShridharGoel Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon May 28, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon May 28, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon May 29, 2026
@ShridharGoel appears to be from a regression, is it due payment? If so, why? Thx
ShridharGoel commentedon May 29, 2026
Yes, we can close this