You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-20] [Due for payment 2026-05-20] Invoice - Invoice report loads infinitely when sent offline #90293
Version Number: 9.3.70-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#90072 Email or phone of affected tester (no customers):sidojsndijsonjdoisjo@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Invoice is enabled.
Go to staging.new.expensify.com
Go offline.
Open FAB > Send invoice.
Send invoice to any user.
Open the invoice report.
Expected Result:
Invoice report will load when sent offline.
Actual Result:
Invoice report loads infinitely when sent offline.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
PR #90072 introduced a new loading gate (isUnreadMessagePageLoadingInitially) in ReportActionsView.tsx that blocks report rendering while offline, causing the infinite loading spinner when opening a newly-sent invoice report offline.
Assigned: @chrispader (PR author), @rlinoz (approving reviewer) Labels: DeployBlockerCash retained (frontend App bug). DeployBlocker removed — fix is needed in Expensify/App, not in the backend.
📋 Detailed Analysis
Evidence
PR #90072 added the following new logic to src/pages/inbox/report/ReportActionsView.tsx:
When a user sends an invoice while offline and then opens the invoice report, all four conditions that make isUnreadMessagePageLoadingInitially = true are satisfied simultaneously:
!reportActionIDFromRoute — true, no deep-link action ID is provided
isReportUnread — true, the newly-created invoice report has lastReadTime < lastVisibleActionCreated (or no lastReadTime at all)
!oldestUnreadReportAction — true, no OpenReport API response has arrived yet (device is offline)
!hasOnceLoadedReportActions — true, the report has never successfully completed an OpenReport call
This makes isReportReady = false, causing ReportActionsSkeletonView to render indefinitely because while offline, neither oldestUnreadReportAction nor hasOnceLoadedReportActions will ever become truthy.
Before this PR, the skeleton was only shown via shouldShowSkeleton, which included the guard shouldShowSkeletonForInitialLoad = !!isLoadingInitialReportActions && ... && !isOffline. This explicitly excluded offline scenarios. The new isUnreadMessagePageLoadingInitially gate has no !isOffline guard, so it incorrectly blocks rendering while offline.
The bug is staging-only (not reproducible in production), consistent with PR #90072 being a staging-only change.
The changes directly relate to the reported symptom: The new loading gate blocks the invoice report view from rendering while offline
Bug is staging-only: Confirmed — not reproducible in production
Root Cause
isUnreadMessagePageLoadingInitially was designed to wait for the OpenReport API response before displaying the unread anchor position. However, it does not handle the offline case: when the device is offline, the API call is queued but never resolves, so oldestUnreadReportAction stays undefined and hasOnceLoadedReportActions stays false indefinitely. The fix should add an || isOffline escape hatch to isUnreadMessagePageLoadingInitially, or revert the PR and ship the fix separately.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.72-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@rlinoz@chrispader The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2026-05-20] Invoice - Invoice report loads infinitely when sent offline[/-][+][Due for payment 2026-05-20] [Due for payment 2026-05-20] Invoice - Invoice report loads infinitely when sent offline[/+]on May 13, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.73-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@rlinoz@chrispader The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon May 12, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #90072
melvin-bot commentedon May 12, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 12, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon May 12, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #90072 - "feat: Open reports at first unread action V2" by @chrispader (High confidence)
Related Issues: #35011, #90030, #90032, #90052, #90064
Recommendation: REVERT
PR #90072 introduced a new loading gate (
isUnreadMessagePageLoadingInitially) inReportActionsView.tsxthat blocks report rendering while offline, causing the infinite loading spinner when opening a newly-sent invoice report offline.Assigned: @chrispader (PR author), @rlinoz (approving reviewer)
Labels:
DeployBlockerCashretained (frontend App bug).DeployBlockerremoved — fix is needed inExpensify/App, not in the backend.📋 Detailed Analysis
Evidence
PR #90072 added the following new logic to
src/pages/inbox/report/ReportActionsView.tsx:When a user sends an invoice while offline and then opens the invoice report, all four conditions that make
isUnreadMessagePageLoadingInitially = trueare satisfied simultaneously:!reportActionIDFromRoute— true, no deep-link action ID is providedisReportUnread— true, the newly-created invoice report haslastReadTime < lastVisibleActionCreated(or nolastReadTimeat all)!oldestUnreadReportAction— true, no OpenReport API response has arrived yet (device is offline)!hasOnceLoadedReportActions— true, the report has never successfully completed an OpenReport callThis makes
isReportReady = false, causingReportActionsSkeletonViewto render indefinitely because while offline, neitheroldestUnreadReportActionnorhasOnceLoadedReportActionswill ever become truthy.Before this PR, the skeleton was only shown via
shouldShowSkeleton, which included the guardshouldShowSkeletonForInitialLoad = !!isLoadingInitialReportActions && ... && !isOffline. This explicitly excluded offline scenarios. The newisUnreadMessagePageLoadingInitiallygate has no!isOfflineguard, so it incorrectly blocks rendering while offline.The bug is staging-only (not reproducible in production), consistent with PR #90072 being a staging-only change.
Verification
src/pages/inbox/report/ReportActionsView.tsxReportActionsView.tsxand introduced theisUnreadMessagePageLoadingInitiallyconditionRoot Cause
isUnreadMessagePageLoadingInitiallywas designed to wait for the OpenReport API response before displaying the unread anchor position. However, it does not handle the offline case: when the device is offline, the API call is queued but never resolves, sooldestUnreadReportActionstaysundefinedandhasOnceLoadedReportActionsstaysfalseindefinitely. The fix should add an|| isOfflineescape hatch toisUnreadMessagePageLoadingInitially, or revert the PR and ship the fix separately.13 remaining items
melvin-bot commentedon May 13, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.72-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 13, 2026
@rlinoz @chrispader The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][Due for payment 2026-05-20] Invoice - Invoice report loads infinitely when sent offline[/-][+][Due for payment 2026-05-20] [Due for payment 2026-05-20] Invoice - Invoice report loads infinitely when sent offline[/+]melvin-bot commentedon May 13, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.73-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 13, 2026
@rlinoz @chrispader The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
abzokhattab commentedon Aug 8, 2026
Looks like the payment is missing here, can we please reopen? I reviewed the PR @Beamanator @rlinoz
melvin-bot commentedon Aug 10, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Aug 10, 2026
Payment Summary
Resolving PRs:
[CP Staging] fix: Invoice report loading infinitely #90323
Contributor: @chrispader does not require payment (Contractor)
Reviewer: @abzokhattab owed $250 via NewDot
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Aug 10, 2026
Payment Summary
Contributor+: @abzokhattab due $250 via NewDot
quinthar commentedon Aug 19, 2026
Approved $250 to @abzokhattab