Skip to content

[Due for payment 2026-05-29] [INP] Remove redundant Onyx subscriptions when editing IOURequest #90356

Closed

Description

@mountiny

Problem

When editing an IOU expense (e.g. editing the description from the Search page), the IOURequest step components subscribe to Onyx data that is not needed for their operation. These redundant subscriptions cause unnecessary re-renders and contribute to slow INP (Interaction to Next Paint) on the Form-SubmitButton.

This is the same pattern identified and fixed in #88417 for other components.

Fix

Remove redundant Onyx subscriptions from IOURequestStepDescription and other IOURequest step components so that they only subscribe to the data they actually need.

Related

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on May 19, 2026

    @melvin-bot

    📣 @Ilya0527! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  2. changed the title [-][INP] Remove redundant Onyx subscriptions when editing IOURequest[/-] [+][Due for payment 2026-05-29] [INP] Remove redundant Onyx subscriptions when editing IOURequest[/+] on May 22, 2026
  3. melvin-bot commented on May 22, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  4. melvin-bot commented on May 22, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.79-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-05-29. 🎊

    For reference, here are some details about the assignees on this issue:

  5. melvin-bot commented on May 26, 2026

    @melvin-bot

    @ShridharGoel Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  6. OlGierd03 commented on May 27, 2026

    @OlGierd03
    Contributor

    All the redundant Onyx subscriptions when editing IOURequest I found have been removed in #90338. I have not found any new Onyx redundancies.

  7. melvin-bot commented on May 28, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  8. melvin-bot commented on May 28, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  9. mallenexpensify commented on May 29, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @ShridharGoel due $250 via NewDot

    don't think a test in needed.

  10. garrettmknight commented on Jun 1, 2026

    @garrettmknight
    Contributor

    $250 approved for @ShridharGoel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions