You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-22] [Due for payment 2026-05-20] Android - Expense - Unable to delete expense, saved search, category, tag etc #90442
Version Number: 9.3.73-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#89609 Email or phone of affected tester (no customers):sdsdjoijdoisnjodis@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Samsung Galaxy S25 FE / Android 16 App Component: Money Requests
Action Performed:
Launch Expensify app.
Go to workspace chat.
Create an expense.
Open the expense report.
Tap More > Delete > Delete.
Expected Result:
Expense can be deleted.
Actual Result:
Expense cannot be deleted.
This issue also happens in many areas of the app - delete save search, remove member, delete category, tag, distance rate, tax, per diem rate etc
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #90358 - "Refactor ReanimatedModal/index.tsx to follow Rules of React and compile with React Compiler" by @roryabraham (High confidence) Related Issues: N/A
Recommendation: REVERT
PR #90358 introduced a regression on Android where onModalHide never fires after a confirmation modal is dismissed, causing all confirmation-gated actions (delete expense, remove member, delete category, delete tag, etc.) to silently fail.
The bug is reproducible on staging only (not production), and version 9.3.73-0 is the staging version
All affected operations (delete expense, delete saved search, remove member, delete category, tag, distance rate, tax, per diem rate) share one common pattern: they use the global showConfirmModal() API, which resolves its Promise only inside handleModalHide in ConfirmModalWrapper
ConfirmModalWrapper.handleModalHide calls closeModal({action: closeAction}) which resolves the Promise; if this never runs, the .then() callback (which actually executes the delete/remove API call) is never reached
Bug is Android-native only, which is consistent with the Android-specific onModalHide path in ReanimatedModal
PR #90358 modifies exactly this file, removing useCallback wrappers from onOpenCallBack and onCloseCallBack.
Root Cause
PR #90358 is a React Compiler compliance refactor that removes useCallback wrappers from all functions inside ReanimatedModal, including onCloseCallBack and onOpenCallBack. These callbacks are passed to the native Container component (src/components/Modal/ReanimatedModal/Container/index.tsx), where they are captured in useMemo-computed Reanimated Keyframe animations:
Because onCloseCallBack is now a plain function (new reference on every render, not stabilized by useCallback), this useMemo recomputes and creates a new Exiting animation keyframe on every render. Replacing the exiting prop on an Animated.View while an exit animation is in progress on Android causes the animation to be interrupted or the completion callback (scheduleOnRN(onCloseCallBack)) to never fire.
On Android, onModalHide is called exclusively from onCloseCallBack (due to unreliable onDismiss). When onCloseCallBack never fires:
onModalHide is never called
ConfirmModalWrapper.handleModalHide never runs
closeModal({action: closeAction}) never resolves the Promise
The .then() handler that runs the delete/remove action is never reached
The user sees the modal close (the UI updates because isVisible becomes false), but the actual operation silently does not execute
The problem is in dismissToModalStack at line 946-948: when RIGHT_MODAL_NAVIGATOR exists in the root state but its .state property is not hydrated (which can happen on narrow layouts), the function silently returns without calling dismissModal or the afterTransition callback. This leaves the user stuck — the confirmation/action screen never dismisses, making it appear that delete (and similar actions) don't work.
This affects all flows that use dismissToSuperWideRHP, which is why the bug manifests across delete expense, saved search, categories, tags, distance rates, taxes, per diem rates, etc.
What changes do you think we should make in order to solve the problem?
Restore the narrow-layout guard in dismissToSuperWideRHP that was removed by PR #89609:
function dismissToSuperWideRHP(options) {
if (getIsNarrowLayout()) {
dismissModal(options);
return;
}
navigateBackToLastSuperWideRHPScreen(options);
}
The Super Wide RHP concept doesn't apply on narrow/mobile layouts, so the direct dismissModal call is the correct behavior there. The original PR's intent to clean up code was valid for wide layouts, but the narrow-layout path still needs special handling.
Investigation details
Evidence chain:
dismissToSuperWideRHP is called by ~13 call sites including navigateBackOnDeleteTransaction and various workspace settings delete flows
On narrow layout, dismissToModalStack checks for rhpState at Navigation.ts:944-948 — if the RHP route's .state is unhydrated, it returns without action
The old guard (getIsNarrowLayout() → dismissModal) bypassed this entirely, which is why the bug only appeared after the guard was removed
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-]Android - Expense - Unable to delete expense, saved search, category, tag etc[/-][+][Due for payment 2026-05-20] Android - Expense - Unable to delete expense, saved search, category, tag etc[/+]on May 13, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.73-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@abzokhattab The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2026-05-20] Android - Expense - Unable to delete expense, saved search, category, tag etc[/-][+][Due for payment 2026-05-22] [Due for payment 2026-05-20] Android - Expense - Unable to delete expense, saved search, category, tag etc[/+]on May 15, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.74-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@abzokhattab The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon May 13, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #89609
melvin-bot commentedon May 13, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 13, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon May 13, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #90358 - "Refactor ReanimatedModal/index.tsx to follow Rules of React and compile with React Compiler" by @roryabraham (High confidence)
Related Issues: N/A
Recommendation: REVERT
PR #90358 introduced a regression on Android where
onModalHidenever fires after a confirmation modal is dismissed, causing all confirmation-gated actions (delete expense, remove member, delete category, delete tag, etc.) to silently fail.Assigned: @roryabraham (PR author), @abzokhattab @carlosmiceli (approving reviewers)
Labels:
DeployBlockerCashkept (frontend App bug). No label changes made.Details
Evidence
showConfirmModal()API, which resolves its Promise only insidehandleModalHideinConfirmModalWrapperConfirmModalWrapper.handleModalHidecallscloseModal({action: closeAction})which resolves the Promise; if this never runs, the.then()callback (which actually executes the delete/remove API call) is never reachedonModalHidepath inReanimatedModalVerification
Affected file:
src/components/Modal/ReanimatedModal/index.tsxPR #90358 modifies exactly this file, removing
useCallbackwrappers fromonOpenCallBackandonCloseCallBack.Root Cause
PR #90358 is a React Compiler compliance refactor that removes
useCallbackwrappers from all functions insideReanimatedModal, includingonCloseCallBackandonOpenCallBack. These callbacks are passed to the nativeContainercomponent (src/components/Modal/ReanimatedModal/Container/index.tsx), where they are captured inuseMemo-computed ReanimatedKeyframeanimations:Because
onCloseCallBackis now a plain function (new reference on every render, not stabilized byuseCallback), thisuseMemorecomputes and creates a newExitinganimation keyframe on every render. Replacing theexitingprop on anAnimated.Viewwhile an exit animation is in progress on Android causes the animation to be interrupted or the completion callback (scheduleOnRN(onCloseCallBack)) to never fire.On Android,
onModalHideis called exclusively fromonCloseCallBack(due to unreliableonDismiss). WhenonCloseCallBacknever fires:onModalHideis never calledConfirmModalWrapper.handleModalHidenever runscloseModal({action: closeAction})never resolves the Promise.then()handler that runs the delete/remove action is never reachedisVisiblebecomesfalse), but the actual operation silently does not executeMelvinBot commentedon May 13, 2026
Proposal
What is the root cause of that problem?
PR #89609 removed the narrow-layout guard from
dismissToSuperWideRHP. Previously, on narrow/mobile layouts, this function calleddismissModal(options)directly. Now it unconditionally delegates tonavigateBackToLastSuperWideRHPScreen→dismissToModalStack.The problem is in
dismissToModalStackat line 946-948: whenRIGHT_MODAL_NAVIGATORexists in the root state but its.stateproperty is not hydrated (which can happen on narrow layouts), the function silently returns without callingdismissModalor theafterTransitioncallback. This leaves the user stuck — the confirmation/action screen never dismisses, making it appear that delete (and similar actions) don't work.This affects all flows that use
dismissToSuperWideRHP, which is why the bug manifests across delete expense, saved search, categories, tags, distance rates, taxes, per diem rates, etc.What changes do you think we should make in order to solve the problem?
Restore the narrow-layout guard in
dismissToSuperWideRHPthat was removed by PR #89609:The Super Wide RHP concept doesn't apply on narrow/mobile layouts, so the direct
dismissModalcall is the correct behavior there. The original PR's intent to clean up code was valid for wide layouts, but the narrow-layout path still needs special handling.Investigation details
Evidence chain:
dismissToSuperWideRHPis called by ~13 call sites includingnavigateBackOnDeleteTransactionand various workspace settings delete flowsdismissToModalStackchecks forrhpStateat Navigation.ts:944-948 — if the RHP route's.stateis unhydrated, it returns without actiongetIsNarrowLayout() → dismissModal) bypassed this entirely, which is why the bug only appeared after the guard was removedNext Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.3 remaining items
test(ReanimatedModal): add regression tests for transition state machine
[-]Android - Expense - Unable to delete expense, saved search, category, tag etc[/-][+][Due for payment 2026-05-20] Android - Expense - Unable to delete expense, saved search, category, tag etc[/+]melvin-bot commentedon May 13, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 13, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.73-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 13, 2026
@abzokhattab The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
fix(ReanimatedModal): stabilize back handler with useEffectEvent
[-][Due for payment 2026-05-20] Android - Expense - Unable to delete expense, saved search, category, tag etc[/-][+][Due for payment 2026-05-22] [Due for payment 2026-05-20] Android - Expense - Unable to delete expense, saved search, category, tag etc[/+]melvin-bot commentedon May 15, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.74-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-22. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 15, 2026
@abzokhattab The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]