You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-09-03] Tags-Android-Click "Switch Tag Levels" Import spreadsheet modal is not displayed #90463
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
After tapping "Switch Tag Levels", the confirm modal sets isVisible=false and waits for onModalHide to fire before resolving the promise and navigating to the import spreadsheet page. On Android, onModalHide is called exclusively from onCloseCallBack — which fires only after the Container's Reanimated exit animation completes via scheduleOnRN(onCloseCallBack).
PR #90358 (merged May 13) refactored ReanimatedModal and introduced two changes that affect this callback chain on Android:
onCloseCallBack lost its useCallback wrapper — it is now recreated every render. The Container's Exiting animation is memoized with onCloseCallBack as a dependency, so it also recreates every render. The worklet closure that calls scheduleOnRN(onCloseCallBack) now captures a potentially stale or unstable function reference on the UI thread.
The Container now unmounts one render earlier — the old code used an intermediate isVisibleState that lagged the isVisible prop by one render, giving Reanimated an extra render cycle to prepare the exit animation. The new code renders the Container directly with {isVisible && containerView}, so the Container is removed from the tree in the same render where isVisible flips to false. On Android (where LayoutAnimationConfig skipExiting is true), this can prevent the exit animation callback from firing entirely.
When onCloseCallBack doesn't fire on Android, onModalHide is never called → handleModalHide never runs → closeModal never resolves the promise → the startMultiLevelTagImportFlow code after await showConfirmModal(...) never executes → Navigation.navigate to the import spreadsheet page is never called.
What changes do you think we should make in order to solve the problem?
Revert the two behavioral changes from PR #90358 that affect the Android exit animation callback:
Restore useCallback on onCloseCallBack (and onOpenCallBack) in ReanimatedModal/index.tsx so the Container's Exiting animation has a stable function reference for the worklet.
Restore the one-render lag for Container unmount on Android — either bring back isVisibleState or add an equivalent mechanism so the Container isn't removed from the render tree in the same render where isVisible flips to false. This gives Reanimated time to register and play the exit animation before the component unmounts.
The rest of the React Compiler compliance changes from PR #90358 (derived isTransitioning, useEffectEvent for lifecycle callbacks, etc.) can remain.
What alternative solutions did you explore? (Optional)
Add a fallback onModalHide call on Android when the exit animation doesn't fire: e.g., in a useEffect cleanup that detects when isTransitioning changes but onCloseCallBack was never invoked. This is more fragile and adds complexity.
The react-native-screens upgrade (PR [No QA] chore: upgrade react-native-screens to 4.25.0 #89199, 4.15.4 → 4.25.0) was also investigated as a potential contributor, but the code trace points squarely at the modal callback chain rather than screen transition behavior.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-]Tags-Android-Click "Switch Tag Levels" Import spreadsheet modal is not displayed[/-][+][Due for payment 2026-09-03] Tags-Android-Click "Switch Tag Levels" Import spreadsheet modal is not displayed[/+]on Sep 3, 2026
Thx @dmkt9 , I updated the price in Upwork but once I clicked outside the box to scroll down, it reset to $250 :rafefist: so I overpaid. I requested a refund for half, please accept it and confirm here once you have. Thx
Thx @dmkt9 , I updated the price in Upwork but once I clicked outside the box to scroll down, it reset to $250 :rafefist: so I overpaid. I requested a refund for half, please accept it and confirm here once you have. Thx
@mallenexpensify Sure. Can you resend it? I don't see it in my list anymore.
Activity
melvin-bot commentedon May 13, 2026
Triggered auto assignment to @carlosmiceli (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 13, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 13, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon May 13, 2026
Proposal
What is the root cause of that problem?
After tapping "Switch Tag Levels", the confirm modal sets
isVisible=falseand waits foronModalHideto fire before resolving the promise and navigating to the import spreadsheet page. On Android,onModalHideis called exclusively fromonCloseCallBack— which fires only after the Container's Reanimated exit animation completes viascheduleOnRN(onCloseCallBack).PR #90358 (merged May 13) refactored ReanimatedModal and introduced two changes that affect this callback chain on Android:
onCloseCallBacklost itsuseCallbackwrapper — it is now recreated every render. The Container'sExitinganimation is memoized withonCloseCallBackas a dependency, so it also recreates every render. The worklet closure that callsscheduleOnRN(onCloseCallBack)now captures a potentially stale or unstable function reference on the UI thread.The Container now unmounts one render earlier — the old code used an intermediate
isVisibleStatethat lagged theisVisibleprop by one render, giving Reanimated an extra render cycle to prepare the exit animation. The new code renders the Container directly with{isVisible && containerView}, so the Container is removed from the tree in the same render whereisVisibleflips to false. On Android (whereLayoutAnimationConfig skipExitingistrue), this can prevent the exit animation callback from firing entirely.When
onCloseCallBackdoesn't fire on Android,onModalHideis never called →handleModalHidenever runs →closeModalnever resolves the promise → thestartMultiLevelTagImportFlowcode afterawait showConfirmModal(...)never executes →Navigation.navigateto the import spreadsheet page is never called.What changes do you think we should make in order to solve the problem?
Revert the two behavioral changes from PR #90358 that affect the Android exit animation callback:
Restore
useCallbackononCloseCallBack(andonOpenCallBack) inReanimatedModal/index.tsxso the Container'sExitinganimation has a stable function reference for the worklet.Restore the one-render lag for Container unmount on Android — either bring back
isVisibleStateor add an equivalent mechanism so the Container isn't removed from the render tree in the same render whereisVisibleflips to false. This gives Reanimated time to register and play the exit animation before the component unmounts.The rest of the React Compiler compliance changes from PR #90358 (derived
isTransitioning,useEffectEventfor lifecycle callbacks, etc.) can remain.What alternative solutions did you explore? (Optional)
onModalHidecall on Android when the exit animation doesn't fire: e.g., in auseEffectcleanup that detects whenisTransitioningchanges butonCloseCallBackwas never invoked. This is more fragile and adds complexity.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.IuliiaHerets commentedon May 13, 2026
Issue is not reproducible on Samsung S23FE/ Android 16 in v9.3.73-4
90463.mp4
51 remaining items
[-]Tags-Android-Click "Switch Tag Levels" Import spreadsheet modal is not displayed[/-][+][Due for payment 2026-09-03] Tags-Android-Click "Switch Tag Levels" Import spreadsheet modal is not displayed[/+]melvin-bot commentedon Sep 3, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)mallenexpensify commentedon Sep 3, 2026
Payment Summary
Contributor+: @dmkt9 due $125 via Upwork
@dmkt9 can you please accept the job below? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~022095621056770199053
dmkt9 commentedon Sep 4, 2026
@mallenexpensify Thanks! I noticed that the job amount is $250, so I've submitted a $125 payment request
mallenexpensify commentedon Sep 4, 2026
Thx @dmkt9 , I updated the price in Upwork but once I clicked outside the box to scroll down, it reset to $250 :rafefist: so I overpaid. I requested a refund for half, please accept it and confirm here once you have. Thx
dmkt9 commentedon Sep 7, 2026
@mallenexpensify Sure. Can you resend it? I don't see it in my list anymore.
mallenexpensify commentedon Sep 7, 2026
@dmkt9 I tried again with a regund request for $125, let me know if it doesn't work. Thx
https://www.upwork.com/jobs/~022095621056770199053
dmkt9 commentedon Sep 8, 2026
@mallenexpensify I've accepted the refund request
mallenexpensify commentedon Sep 8, 2026
Thanks @dmkt9 confirming refund was received.