Skip to content

[Due for payment 2026-07-13] [Workspace Roles] Release 3: People Admin — member management UI and elevated role assignment #90502

Closed

Description

@flodnv

Part of the Workspace Roles project. Depends on Release 0 frontend and Release 3 Auth C++ backend.

Goal: Surface the "People Admin" role in the workspace UI and gate member-management write actions on FEATURE.MEMBERS write access. People Admin can invite/remove members and assign any role except full Admin; they cannot grant Admin.

Member list & role picker (src/pages/workspace/WorkspaceMembersPage.tsx)

  • Add "People Admin" as a selectable role in the role dropdown
  • Add a "People Admin" badge/label for members with role === CONST.POLICY.ROLE.PEOPLE_ADMIN
  • Migrate the "Invite member", "Remove member" CTA visibility check from isPolicyAdmin → hasPolicyPermission(..., FEATURE.MEMBERS, FEATURE_ACCESS.WRITE)
  • The role-assignment picker for People Admin should offer all roles except admin (since FEATURE.ASSIGN_ELEVATED_ROLES is required to grant Admin, which People Admin does not have)

Role assignment guard (src/libs/PolicyUtils.ts)

  • Add canAssignRole(policy, actorLogin, targetRole): boolean — returns false if targetRole === 'admin' and actor does not have FEATURE.ASSIGN_ELEVATED_ROLES write access

Imported-members CSV (src/pages/workspace/members/ImportedMembersConfirmationPage.tsx)

  • Add peopleAdmin as a selectable option in the role picker during CSV import

Member invite flow

  • In the invite member modal/page, filter available roles using canAssignRole so People Admin cannot accidentally offer Admin as an option
Issue OwnerCurrent Issue Owner: @Pujan92

Activity

  1. melvin-bot commented on May 13, 2026

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

  2. melvin-bot commented on Jun 5, 2026

    @melvin-bot

    This issue has not been updated in over 15 days. @flodnv, @dannymcclain, @Pujan92, @ShridharGoel eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  3. 48 remaining items

  4. lanitochka17 commented on Jul 1, 2026

    @lanitochka17

    Deploy Blocker #95091 was identified to be related to the PR #92875 that attempted to fix this issue.

  5. melvin-bot commented on Jul 1, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  6. melvin-bot commented on Jul 1, 2026

    @melvin-bot

    @flodnv, @LLPeckham, @dannymcclain, @Pujan92, @ShridharGoel Whoops! This issue is 2 days overdue. Let's get this updated quick!

  7. mitarachim commented on Jul 1, 2026

    @mitarachim

    Deploy Blocker #95098 was identified to be related to the PR #92875 that attempted to fix this issue.

  8. flodnv commented on Jul 2, 2026

    @flodnv
    ContributorAuthor

    @ShridharGoel is working through the 3 reported issues, which we demoted from blockers.

  9. lanitochka17 commented on Jul 2, 2026

    @lanitochka17

    Deploy Blocker #95223 was identified to be related to the PR #92875 that attempted to fix this issue.

  10. changed the title [-][Workspace Roles] Release 3: People Admin — member management UI and elevated role assignment[/-] [+][Due for payment 2026-07-13] [Workspace Roles] Release 3: People Admin — member management UI and elevated role assignment[/+] on Jul 6, 2026
  11. melvin-bot commented on Jul 6, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.27-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-07-13. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Pujan92 requires payment through NewDot Manual Requests
    • @ShridharGoel does not require payment (Contractor)
  12. melvin-bot commented on Jul 6, 2026

    @melvin-bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@Pujan92] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

    If no checklist is needed for this issue and you have the K2 extension, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions