You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Travel invoicing is not displayed in Sage/ Export after enabling Central invoicing #90551
Version Number: 9.3.73-4 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#88483 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: MacBook Air 15.7.4 Chrome, iPhone 15 iOS 26.3.1 App Component: Workspace Settings
Action Performed:
Sign in to ND with expensifail account
Create a workspace
Enable Accounting in More features, connect to Sage Intacct
Enable Travel in More features, click "Lets's go", fill the required information
Open the Travel page, toggle on "Central invoicing", connect to bank account
Navigate to the Accounting - Sage - Export
Expected Result:
"Travel Invoicing" menu item appears in the Sage Export RHP after enabling Central invoicing in Travel
Actual Result:
"Travel Invoicing" menu item does not appear in the Sage Export RHP after enabling Central invoicing in Travel. Only
"Export Expensify Travel Payable To" row appears in Export
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
PR #88483 introduced the Travel Invoicing menu item to the Sage Intacct export page but the item never appears, meaning the feature is completely non-functional. The fix lives entirely in the App repo — reverting the PR restores the previous working state with no impact on other functionality.
Assigned: @brunovjk (PR author), @ishpaul777 (approving reviewer), @blimpich (approving reviewer) Labels: DeployBlockerCash kept (Frontend bug — App PR is the cause). DeployBlocker not present, no change needed.
The condition is: isBetaEnabled(CONST.BETAS.TRAVEL_INVOICING) && getIsTravelInvoicingEnabled(travelSettings)
travelSettings is derived from getCardSettings(cardSettings, CONST.TRAVEL.PROGRAM_TRAVEL_US), which looks for data nested under the TRAVEL_US key in the card settings Onyx object.
Root Cause
The most likely root cause is that isTravelInvoicingEnabled evaluates to false during QA even after enabling Central Invoicing through the Travel page. Two possible sub-causes:
The TRAVEL_INVOICING beta (isBetaEnabled(CONST.BETAS.TRAVEL_INVOICING)) may not be enabled for the test account, even though Central Invoicing can be toggled on via the Travel page (which uses a different beta check). This would cause the condition to short-circuit to false.
If the beta is enabled, getCardSettings(cardSettings, CONST.TRAVEL.PROGRAM_TRAVEL_US) may return undefined because the Travel Invoicing card settings for this test account are not nested under the TRAVEL_US key, causing getIsTravelInvoicingEnabled to return false.
Either way, the Travel Invoicing menu item is never rendered in the Sage Intacct Export RHP, making the feature completely broken for the QA test case linked in the issue. Reverting PR #88483 is the safe path forward.
The Sage Intacct Export page (DynamicSageIntacctExportPage.tsx:33-35) reads the travel invoicing enabled state from PRIVATE_EXPENSIFY_CARD_SETTINGS via useOnyx, but no API call is made from this page to fetch that data. The only place that fetches card settings is openPolicyTravelPage on the Travel page.
Additionally, configureTravelInvoicingForPolicy does not optimistically set isEnabled: true in the TRAVEL_US nested key — it only sets loading/pending flags at the top level. In contrast, deactivateTravelInvoicing correctly sets isEnabled: false in the nested key. This asymmetry means getIsTravelInvoicingEnabled returns false because cardSettings is either undefined (never fetched) or missing the isEnabled field.
What changes do you think we should make in order to solve the problem?
Two changes are needed:
Ensure the Export page has access to card settings data. Either call openPolicyTravelPage (or an equivalent fetch) from the accounting export pages that need travel invoicing state, or ensure the backend includes PRIVATE_EXPENSIFY_CARD_SETTINGS in the OpenPolicyAccountingPage response.
Fix the optimistic data in configureTravelInvoicingForPolicy to include [CONST.TRAVEL.PROGRAM_TRAVEL_US]: { isEnabled: true } in the optimistic update, matching the pattern already used by deactivateTravelInvoicing. This ensures the UI reflects the enabled state immediately.
What alternative solutions did you explore? (Optional)
An alternative is relying solely on the paymentBankAccountID fallback in getIsTravelInvoicingEnabled — but this still requires the card settings data to be fetched first, so the data availability problem must be solved regardless.
The Travel Invoicing row is conditionally rendered at DynamicSageIntacctExportPage.tsx:56-67 — when isTravelInvoicingEnabled is false, the row is omitted entirely
configureTravelInvoicingForPolicy optimistic data at line 281-297 only sets isLoading, pendingAction, etc. — never TRAVEL_US.isEnabled
deactivateTravelInvoicing correctly sets the nested key at line 347-349
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
Activity
melvin-bot commentedon May 13, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #88483
melvin-bot commentedon May 13, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 13, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon May 13, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #88483 - "Sage Intacct - Add Travel Invoicing vendor & payable account selectors" by @brunovjk (High confidence)
Related Issues: #88269
Recommendation: REVERT
PR #88483 introduced the Travel Invoicing menu item to the Sage Intacct export page but the item never appears, meaning the feature is completely non-functional. The fix lives entirely in the App repo — reverting the PR restores the previous working state with no impact on other functionality.
Assigned: @brunovjk (PR author), @ishpaul777 (approving reviewer), @blimpich (approving reviewer)
Labels:
DeployBlockerCashkept (Frontend bug — App PR is the cause).DeployBlockernot present, no change needed.Detailed Analysis
Evidence
DynamicSageIntacctExportPage.tsxand adds the Travel Invoicing conditional section.Verification
src/pages/workspace/accounting/intacct/export/DynamicSageIntacctExportPage.tsxisTravelInvoicingEnabledguard and conditional section for the "Travel Invoicing" menu item.isBetaEnabled(CONST.BETAS.TRAVEL_INVOICING) && getIsTravelInvoicingEnabled(travelSettings)travelSettingsis derived fromgetCardSettings(cardSettings, CONST.TRAVEL.PROGRAM_TRAVEL_US), which looks for data nested under theTRAVEL_USkey in the card settings Onyx object.Root Cause
The most likely root cause is that
isTravelInvoicingEnabledevaluates tofalseduring QA even after enabling Central Invoicing through the Travel page. Two possible sub-causes:The
TRAVEL_INVOICINGbeta (isBetaEnabled(CONST.BETAS.TRAVEL_INVOICING)) may not be enabled for the test account, even though Central Invoicing can be toggled on via the Travel page (which uses a different beta check). This would cause the condition to short-circuit tofalse.If the beta is enabled,
getCardSettings(cardSettings, CONST.TRAVEL.PROGRAM_TRAVEL_US)may returnundefinedbecause the Travel Invoicing card settings for this test account are not nested under theTRAVEL_USkey, causinggetIsTravelInvoicingEnabledto returnfalse.Either way, the Travel Invoicing menu item is never rendered in the Sage Intacct Export RHP, making the feature completely broken for the QA test case linked in the issue. Reverting PR #88483 is the safe path forward.
MelvinBot commentedon May 13, 2026
Proposal
What is the root cause of that problem?
The Sage Intacct Export page (
DynamicSageIntacctExportPage.tsx:33-35) reads the travel invoicing enabled state fromPRIVATE_EXPENSIFY_CARD_SETTINGSviauseOnyx, but no API call is made from this page to fetch that data. The only place that fetches card settings isopenPolicyTravelPageon the Travel page.Additionally,
configureTravelInvoicingForPolicydoes not optimistically setisEnabled: truein theTRAVEL_USnested key — it only sets loading/pending flags at the top level. In contrast,deactivateTravelInvoicingcorrectly setsisEnabled: falsein the nested key. This asymmetry meansgetIsTravelInvoicingEnabledreturnsfalsebecausecardSettingsis either undefined (never fetched) or missing theisEnabledfield.What changes do you think we should make in order to solve the problem?
Two changes are needed:
Ensure the Export page has access to card settings data. Either call
openPolicyTravelPage(or an equivalent fetch) from the accounting export pages that need travel invoicing state, or ensure the backend includesPRIVATE_EXPENSIFY_CARD_SETTINGSin theOpenPolicyAccountingPageresponse.Fix the optimistic data in
configureTravelInvoicingForPolicyto include[CONST.TRAVEL.PROGRAM_TRAVEL_US]: { isEnabled: true }in the optimistic update, matching the pattern already used bydeactivateTravelInvoicing. This ensures the UI reflects the enabled state immediately.What alternative solutions did you explore? (Optional)
An alternative is relying solely on the
paymentBankAccountIDfallback ingetIsTravelInvoicingEnabled— but this still requires the card settings data to be fetched first, so the data availability problem must be solved regardless.Investigation details
DynamicSageIntacctExportPage.tsx:33but never triggers a fetchDynamicSageIntacctExportPage.tsx:56-67— whenisTravelInvoicingEnabledis false, the row is omitted entirelyconfigureTravelInvoicingForPolicyoptimistic data at line 281-297 only setsisLoading,pendingAction, etc. — neverTRAVEL_US.isEnableddeactivateTravelInvoicingcorrectly sets the nested key at line 347-349Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.Beamanator commentedon May 13, 2026
Not a blocker b/c this is behind a beta - but let me know if i'm misunderstanding @blimpich @brunovjk @ishpaul777 🙏
blimpich commentedon May 13, 2026
You are correct, not a blocker 👍
blimpich commentedon May 13, 2026
@brunovjk you mind implementing a fix? And then @ishpaul777 @rlinoz and I can review?
blimpich commentedon May 13, 2026
https://expensify.slack.com/archives/C01GTK53T8Q/p1778702949234619?thread_ts=1778696013.106269&cid=C01GTK53T8Q