You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-02] Expense - Expense report RHP animates expectedly when expense flow RHP opens #90657
Version Number: 9.3.74-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#87920 Email or phone of affected tester (no customers):sdsdjoijdoisnjodis@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Run Onyx.merge('betas', ['newManualExpenseFlow']); in console.
Go to staging.new.expensify.com
Go to workspace chat.
Create two expenses.
Open the report.
Click + > Create expense.
Expected Result:
Expense report RHP will not animate when expense flow RHP opens.
Actual Result:
Expense report RHP animates expectedly when expense flow RHP opens.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
PR #87920 embeds IOURequestStepConfirmation directly inside IOURequestStartPage when the newManualExpenseFlow beta is enabled (IOURequestStartPage.tsx:251-256). This causes a preInsertFullscreenUnderRHP effect (IOURequestStepConfirmation.tsx:443-509) to evaluate immediately when the create-expense RHP opens—rather than later when the user would have navigated to a separate confirmation step.
The isReportOpenInRHP guard at line 467 only inspects the last route in the root navigation state (isReportOpenInRHP.ts:7). When the money-request RHP has been pushed on top of the expense-report RHP, the last route is the money-request navigator—so isReportOpenInRHP returns false, the guard passes, and preInsertFullscreenUnderRHP fires. This dispatches DISABLE_RHP_ANIMATION / RESTORE_RHP_ANIMATION events (RightModalNavigator.tsx:122-127), toggling the RHP animation from NONE → SLIDE_FROM_RIGHT and causing the expense-report RHP to visibly slide/animate when it shouldn't.
What changes do you think we should make in order to solve the problem?
Skip the preInsertFullscreenUnderRHP effect entirely when IOURequestStepConfirmation is rendered in embedded mode (i.e., when shouldHideHeader is true). The pre-insert logic exists for the standalone confirmation screen that will dismiss back to a fullscreen route—when the confirmation is embedded inside IOURequestStartPage within the RHP, the pre-insert is never needed and actively harmful.
This is the minimal change: it prevents the pre-insert from firing when the component is embedded, without modifying the standalone flow at all.
What alternative solutions did you explore? (Optional)
An alternative would be to fix isReportOpenInRHP to scan all routes in the root state (not just the last one) for wide RHP screens. This would make the existing guard catch the case correctly, but it changes the semantics of isReportOpenInRHP globally and could have unintended side effects in other call sites. The shouldHideHeader guard is more targeted and safer.
Investigation details
Navigation flow during repro:
User opens expense report → RIGHT_MODAL_NAVIGATOR with EXPENSE_REPORT screen is on the root stack
User taps "+ Create expense" → linkTo pushes a NEW RIGHT_MODAL_NAVIGATOR with MONEY_REQUEST on the root stack
IOURequestStartPage mounts with IOURequestStepConfirmation embedded (beta enabled)
The pre-insert effect evaluates: isReportOpenInRHP checks only state.routes.at(-1) which is the NEW money-request RHP → returns false → isOutsideRHP = true
shouldPreInsertReport evaluates to true → preInsertFullscreenUnderRHP fires after a delay
This emits DISABLE_RHP_ANIMATION, then on cleanup emits RESTORE_RHP_ANIMATION which sets animation to SLIDE_FROM_RIGHT
The expense report RHP underneath visibly animates
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
@dukenv0307 same for you too? Payment via the project?
If so, I'll remove the payment summary (and.. I think I paid a handful of others too that likely need updating)
@mallenexpensify I didn't handle the whole project, I was assigned this issue to help speed up the project. I think that's fair to pay me here cc @trjExpensify
Activity
applause-bot commentedon May 14, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/9a09653ea8960d7ce9a5290049734b8ce25819018328be9151b8abc0d0add246
melvin-bot commentedon May 14, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #87920
melvin-bot commentedon May 14, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 14, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon May 14, 2026
Proposal
What is the root cause of that problem?
PR #87920 embeds
IOURequestStepConfirmationdirectly insideIOURequestStartPagewhen thenewManualExpenseFlowbeta is enabled (IOURequestStartPage.tsx:251-256). This causes apreInsertFullscreenUnderRHPeffect (IOURequestStepConfirmation.tsx:443-509) to evaluate immediately when the create-expense RHP opens—rather than later when the user would have navigated to a separate confirmation step.The
isReportOpenInRHPguard at line 467 only inspects the last route in the root navigation state (isReportOpenInRHP.ts:7). When the money-request RHP has been pushed on top of the expense-report RHP, the last route is the money-request navigator—soisReportOpenInRHPreturnsfalse, the guard passes, andpreInsertFullscreenUnderRHPfires. This dispatchesDISABLE_RHP_ANIMATION/RESTORE_RHP_ANIMATIONevents (RightModalNavigator.tsx:122-127), toggling the RHP animation fromNONE→SLIDE_FROM_RIGHTand causing the expense-report RHP to visibly slide/animate when it shouldn't.What changes do you think we should make in order to solve the problem?
Skip the
preInsertFullscreenUnderRHPeffect entirely whenIOURequestStepConfirmationis rendered in embedded mode (i.e., whenshouldHideHeaderistrue). The pre-insert logic exists for the standalone confirmation screen that will dismiss back to a fullscreen route—when the confirmation is embedded insideIOURequestStartPagewithin the RHP, the pre-insert is never needed and actively harmful.Add
shouldHideHeaderas an early return guard in the effect atIOURequestStepConfirmation.tsx:444:This is the minimal change: it prevents the pre-insert from firing when the component is embedded, without modifying the standalone flow at all.
What alternative solutions did you explore? (Optional)
An alternative would be to fix
isReportOpenInRHPto scan all routes in the root state (not just the last one) for wide RHP screens. This would make the existing guard catch the case correctly, but it changes the semantics ofisReportOpenInRHPglobally and could have unintended side effects in other call sites. TheshouldHideHeaderguard is more targeted and safer.Investigation details
Navigation flow during repro:
RIGHT_MODAL_NAVIGATORwithEXPENSE_REPORTscreen is on the root stacklinkTopushes a NEWRIGHT_MODAL_NAVIGATORwithMONEY_REQUESTon the root stackIOURequestStartPagemounts withIOURequestStepConfirmationembedded (beta enabled)isReportOpenInRHPchecks onlystate.routes.at(-1)which is the NEW money-request RHP → returnsfalse→isOutsideRHP=trueshouldPreInsertReportevaluates totrue→preInsertFullscreenUnderRHPfires after a delayDISABLE_RHP_ANIMATION, then on cleanup emitsRESTORE_RHP_ANIMATIONwhich sets animation toSLIDE_FROM_RIGHTKey code references:
IOURequestStartPage.tsx:251-256IOURequestStepConfirmation.tsx:443-509isReportOpenInRHP.ts:6-18RightModalNavigator.tsx:118-132Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.puneetlath commentedon May 14, 2026
Demoting since this only affects those in beta.
21 remaining items
melvin-bot commentedon Jun 1, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Jun 1, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Jun 3, 2026
Payment Summary
Contributor: @dukenv0307 due $250 via NewDot
@ChavdaSachin plz complete the BZ checklist and tag me in a post once you have. Thx
ChavdaSachin commentedon Jun 3, 2026
This was a regression from my own PR - #91004
I am not due payment here.
My payment would be handled at #82586 at the end
mallenexpensify commentedon Jun 3, 2026
@dukenv0307 same for you too? Payment via the project?
If so, I'll remove the payment summary (and.. I think I paid a handful of others too that likely need updating)
dukenv0307 commentedon Jun 4, 2026
@mallenexpensify I didn't handle the whole project, I was assigned this issue to help speed up the project. I think that's fair to pay me here cc @trjExpensify
mallenexpensify commentedon Jun 4, 2026
Thx, updated the payment summary to denote @dukenv0307 is only one due payment
quinthar commentedon Jun 13, 2026
Approved $250 to @dukenv0307