Skip to content

[Due for payment 2026-06-16] Missing Tag, Tax, Tax amount, Billable and Reimbursable on confirm page when opened from FAB #90673

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.74-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #87920
Email or phone of affected tester (no customers): sdsdjoijdoisnjodis@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Run Onyx.merge('betas', ['newManualExpenseFlow']); in console.
  • Enable Rules, Tags and Taxes in workspace settings.
  • Set Billable default to Billable.
  • Create a tag in Tags settings.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Click + > Create expense > Manual.
    → Tag, Tax, Tax amount, Billable and Reimbursable fields are shown on confirm page.
  4. Close the RHP.
  5. Open FAB > Create expense > Manual.

Expected Result:

Tag, Tax, Tax amount, Billable and Reimbursable fields will be shown on confirm page when opened from FAB.

Actual Result:

Tag, Tax, Tax amount, Billable and Reimbursable fields are missing on confirm page when opened from FAB.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @ShridharGoel

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 14, 2026
  2. melvin-bot commented on May 14, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #87920

  3. melvin-bot commented on May 14, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on May 14, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. OSBotify commented on May 14, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #87920 - "Feat: Manual expense flow UI refactor - r3" by @ChavdaSachin (High confidence)
    Related Issues: #82586 (original issue this PR was fixing)

    Recommendation: REVERT

    PR #87920 introduced a regression where Tag, Tax, Tax amount, Billable, and Reimbursable fields are missing from the confirmation page when creating a manual expense from the FAB (global create), while they appear correctly when creating from workspace chat. Reverting this PR is the most straightforward fix since the bug is confined to this PR's changes.

    Assigned: @ChavdaSachin (PR author), @ShridharGoel (approving reviewer), @puneetlath (approving reviewer) from highest-confidence causing PR only
    Labels: No label changes needed — DeployBlockerCash is correctly applied as this is a frontend App bug.

    Detailed Analysis

    Evidence

    • The melvin-bot comment on this issue directly flags PR Feat: Manual expense flow UI refactor - r3 #87920 as the likely cause.
    • PR Feat: Manual expense flow UI refactor - r3 #87920 is listed in the StagingDeployCash checklist for version 9.3.74-1 and was merged on 2026-05-13, aligning with the bug appearing in version 9.3.74-0.
    • The bug is staging-only and described as a new feature (Reproducible in production?: N/A - new feature), confirming the regression was introduced in this staging cycle.
    • The issue is scoped to the newManualExpenseFlow beta, which is the exact feature this PR implements.

    Verification

    • The affected files are src/pages/iou/request/step/IOURequestStepConfirmation.tsx and src/components/MoneyRequestConfirmationListFooter/fieldGroups/TransactionDetailsFields.tsx, both of which are directly modified by PR Feat: Manual expense flow UI refactor - r3 #87920.
    • The PR adds a new defaultParticipants memo in IOURequestStepConfirmation.tsx that attempts to resolve participants for the global-create (FAB) flow using transaction?.reportID. When opening from FAB, the transaction has no reportID set initially, so defaultParticipants returns an empty array.
    • policyExpenseChatPolicyID is derived from transaction?.participants, defaultParticipants, and report. When both transaction?.participants and defaultParticipants are empty (as happens in the FAB flow before the user selects a participant), policyExpenseChatPolicyID is undefined.
    • Without a valid policyExpenseChatPolicyID, the policy prop used in MoneyRequestConfirmationList is null/undefined, causing the field visibility logic to hide Tag, Tax, Billable, and Reimbursable fields.
    • In contrast, when opening from workspace chat (+ button), the reportID is available on the transaction from the start (the workspace is the source report), so defaultParticipants resolves correctly and the policy fields appear.

    Root Cause

    PR #87920 changed how participants and the effective policy are determined on the confirmation page. The new defaultParticipants memo early-returns an empty array if transaction?.reportID is falsy, which is the case in the FAB/global-create flow before the user selects a participant. This leaves policyExpenseChatPolicyID as undefined, so the policy Onyx entry is never loaded, and all policy-dependent fields (Tag, Tax, Tax amount, Billable, Reimbursable) are hidden. The old code read policyExpenseChatPolicyID directly from the participants prop passed in from the parent, which was correctly populated for the workspace-chat case and was not expected to be empty for the FAB case.

  6. MelvinBot commented on May 14, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    When creating an expense from FAB, the route's reportID is empty (no workspace context yet). The function getIOURequestPolicyID only extracts a policyID from isSender participants (invoices) or from report?.policyID. It never checks isPolicyExpenseChat participants.

    So even after the user selects a workspace in the participant picker, the participant's policyID (stored with isPolicyExpenseChat: true) is ignored by the policy resolution chain. This means policy remains undefined in IOURequestStepConfirmation, and all policy-dependent fields (Tag, Tax, Billable, Reimbursable) are hidden.

    In the workspace chat flow, report?.policyID is already set from the start, so the policy resolves correctly and the fields appear.

    Notably, policyExpenseChatPolicyID already correctly extracts the participant's policyID -- but it's only used for DraftWorkspaceOpener, not for the main policy resolution.

    What changes do you think we should make in order to solve the problem?

    Update getIOURequestPolicyID in MoneyRequest.ts:1114 to also check for isPolicyExpenseChat participants as a fallback:

    workspaceSender?.policyID ?? report?.policyID ?? policyExpenseChatParticipant?.policyID
    

    Where policyExpenseChatParticipant is found via transaction?.participants?.find((p) => p.isPolicyExpenseChat). This ensures that when a workspace is selected via the participant picker (FAB flow), the policy is resolved from the selected participant, making all policy-dependent fields visible.

    What alternative solutions did you explore? (Optional)

    An alternative would be to have IOURequestStepConfirmation fall back to policyExpenseChatPolicyID when realPolicyID/draftPolicyID are undefined. However, fixing getIOURequestPolicyID is cleaner since it's the central function for this purpose and would fix the issue for all callers, not just the confirmation page.

    Investigation details

    Evidence chain:

    1. FAB flow sets an empty reportID in the route, so reportReal has no policyID
    2. getIOURequestPolicyID(initialTransaction, reportReal) returns undefined (IOURequestStepConfirmation.tsx:144)
    3. usePolicyForTransaction receives reportPolicyID: undefined, returns policy: undefined
    4. Field visibility depends on policy:
      • shouldShowTax requires policy?.tax?.trackingEnabled
      • shouldShowBillable requires policy?.disabledFields?.defaultBillable === false
      • shouldShowReimbursable requires !!policy
      • shouldShowTags requires hasEnabledTags(policyTagLists) but policyTagLists is empty since it's loaded by policyID which is undefined
    5. setMoneyRequestParticipants (called when participant is selected) updates transaction.participants but does NOT update transaction.reportID for non-test transactions (MoneyRequest.ts:1048-1055)

    Confidence: High -- the code path is fully traced and the gap is clear.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  7. ChavdaSachin commented on May 14, 2026

    @ChavdaSachin
    Contributor

    NAB: only happens on beta accounts

  8. puneetlath commented on May 14, 2026

    @puneetlath
    Contributor

    Demoting.

  9. 49 remaining items

  10. melvin-bot commented on Jun 15, 2026

    @melvin-bot

    Current assignee @mallenexpensify is eligible for the Awaiting Payment assigner, not assigning anyone new.

  11. melvin-bot commented on Jun 15, 2026

    @melvin-bot

    @ShridharGoel 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  12. mallenexpensify commented on Jun 17, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @dukenv0307 due $375 via NewDot
    Contributor+: @thelullabyy due $125 via NewDot

    @dukenv0307 is that correct? It looks like two of the PRs were reviewed by @ShridharGoel and the other by @thelullabyy

    What test cases do we want here?

  13. ShridharGoel commented on Jun 17, 2026

    @ShridharGoel
    Contributor

    @mallenexpensify I'll be paid together as part of the project, so I'll not be due payment here

  14. mallenexpensify commented on Jun 17, 2026

    @mallenexpensify
    Contributor

    @ShridharGoel removed your details from the payment summary.

  15. dukenv0307 commented on Jun 18, 2026

    @dukenv0307
    Contributor

    @thelullabyy can you please complete the checklist?

  16. thelullabyy commented on Jun 18, 2026

    @thelullabyy
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: NA
      Link to the comment on the Issue: NA

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: NA

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Test:

    Precondition:

    • Run Onyx.merge('betas', ['newManualExpenseFlow']); in console.
    • Enable Rules, Tags and Taxes in workspace settings.
    • Set Billable default to Billable.
    • Create a tag in Tags settings.

    Test 1:

    1. Go to staging.new.expensify.com
    2. Go to workspace chat.
    3. Click + > Create expense > Manual → Tag, Tax, Tax amount, Billable and Reimbursable fields are shown on confirm page.
    4. Close the RHP.
    5. Open FAB > Create expense > Manual.
    6. Verify that: Tag, Tax, Tax amount, Billable and Reimbursable fields will be shown on confirm page when opened from FAB.

    Test 2:

    1. Create a tag in Tags settings.
    2. Go to staging.new.expensify.com
    3. Go to workspace chat.
    4. Click + > Create expense > Manual.
    5. Verify that the tax amount input should be inline
    6. Enter the invalid amount
    7. Create expense
    8. Verify the error message is shown

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-4c5f-a10f-70a8-9a4203be0424
  17. mallenexpensify commented on Jun 18, 2026

    @mallenexpensify
    Contributor

    Test cases created, think we're good to close

  18. quinthar commented on Jun 29, 2026

    @quinthar
    Contributor

    Approved $375 to @dukenv0307

  19. laurenreidexpensify commented on Aug 12, 2026

    @laurenreidexpensify
    Contributor

    Approved $125 to @thelullabyy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions