You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-16] Missing Tag, Tax, Tax amount, Billable and Reimbursable on confirm page when opened from FAB #90673
Version Number: 9.3.74-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#87920 Email or phone of affected tester (no customers):sdsdjoijdoisnjodis@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Run Onyx.merge('betas', ['newManualExpenseFlow']); in console.
Enable Rules, Tags and Taxes in workspace settings.
Set Billable default to Billable.
Create a tag in Tags settings.
Go to staging.new.expensify.com
Go to workspace chat.
Click + > Create expense > Manual.
→ Tag, Tax, Tax amount, Billable and Reimbursable fields are shown on confirm page.
Close the RHP.
Open FAB > Create expense > Manual.
Expected Result:
Tag, Tax, Tax amount, Billable and Reimbursable fields will be shown on confirm page when opened from FAB.
Actual Result:
Tag, Tax, Tax amount, Billable and Reimbursable fields are missing on confirm page when opened from FAB.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #87920 - "Feat: Manual expense flow UI refactor - r3" by @ChavdaSachin (High confidence) Related Issues: #82586 (original issue this PR was fixing)
Recommendation: REVERT
PR #87920 introduced a regression where Tag, Tax, Tax amount, Billable, and Reimbursable fields are missing from the confirmation page when creating a manual expense from the FAB (global create), while they appear correctly when creating from workspace chat. Reverting this PR is the most straightforward fix since the bug is confined to this PR's changes.
Assigned: @ChavdaSachin (PR author), @ShridharGoel (approving reviewer), @puneetlath (approving reviewer) from highest-confidence causing PR only Labels: No label changes needed — DeployBlockerCash is correctly applied as this is a frontend App bug.
PR Feat: Manual expense flow UI refactor - r3 #87920 is listed in the StagingDeployCash checklist for version 9.3.74-1 and was merged on 2026-05-13, aligning with the bug appearing in version 9.3.74-0.
The bug is staging-only and described as a new feature (Reproducible in production?: N/A - new feature), confirming the regression was introduced in this staging cycle.
The issue is scoped to the newManualExpenseFlow beta, which is the exact feature this PR implements.
Verification
The affected files are src/pages/iou/request/step/IOURequestStepConfirmation.tsx and src/components/MoneyRequestConfirmationListFooter/fieldGroups/TransactionDetailsFields.tsx, both of which are directly modified by PR Feat: Manual expense flow UI refactor - r3 #87920.
The PR adds a new defaultParticipants memo in IOURequestStepConfirmation.tsx that attempts to resolve participants for the global-create (FAB) flow using transaction?.reportID. When opening from FAB, the transaction has no reportID set initially, so defaultParticipants returns an empty array.
policyExpenseChatPolicyID is derived from transaction?.participants, defaultParticipants, and report. When both transaction?.participants and defaultParticipants are empty (as happens in the FAB flow before the user selects a participant), policyExpenseChatPolicyID is undefined.
Without a valid policyExpenseChatPolicyID, the policy prop used in MoneyRequestConfirmationList is null/undefined, causing the field visibility logic to hide Tag, Tax, Billable, and Reimbursable fields.
In contrast, when opening from workspace chat (+ button), the reportID is available on the transaction from the start (the workspace is the source report), so defaultParticipants resolves correctly and the policy fields appear.
Root Cause
PR #87920 changed how participants and the effective policy are determined on the confirmation page. The new defaultParticipants memo early-returns an empty array if transaction?.reportID is falsy, which is the case in the FAB/global-create flow before the user selects a participant. This leaves policyExpenseChatPolicyID as undefined, so the policy Onyx entry is never loaded, and all policy-dependent fields (Tag, Tax, Tax amount, Billable, Reimbursable) are hidden. The old code read policyExpenseChatPolicyID directly from the participants prop passed in from the parent, which was correctly populated for the workspace-chat case and was not expected to be empty for the FAB case.
When creating an expense from FAB, the route's reportID is empty (no workspace context yet). The function getIOURequestPolicyID only extracts a policyID from isSender participants (invoices) or from report?.policyID. It never checks isPolicyExpenseChat participants.
So even after the user selects a workspace in the participant picker, the participant's policyID (stored with isPolicyExpenseChat: true) is ignored by the policy resolution chain. This means policy remains undefined in IOURequestStepConfirmation, and all policy-dependent fields (Tag, Tax, Billable, Reimbursable) are hidden.
In the workspace chat flow, report?.policyID is already set from the start, so the policy resolves correctly and the fields appear.
Notably, policyExpenseChatPolicyID already correctly extracts the participant's policyID -- but it's only used for DraftWorkspaceOpener, not for the main policy resolution.
What changes do you think we should make in order to solve the problem?
Update getIOURequestPolicyID in MoneyRequest.ts:1114 to also check for isPolicyExpenseChat participants as a fallback:
Where policyExpenseChatParticipant is found via transaction?.participants?.find((p) => p.isPolicyExpenseChat). This ensures that when a workspace is selected via the participant picker (FAB flow), the policy is resolved from the selected participant, making all policy-dependent fields visible.
What alternative solutions did you explore? (Optional)
An alternative would be to have IOURequestStepConfirmation fall back to policyExpenseChatPolicyID when realPolicyID/draftPolicyID are undefined. However, fixing getIOURequestPolicyID is cleaner since it's the central function for this purpose and would fix the issue for all callers, not just the confirmation page.
Investigation details
Evidence chain:
FAB flow sets an empty reportID in the route, so reportReal has no policyID
shouldShowTags requires hasEnabledTags(policyTagLists) but policyTagLists is empty since it's loaded by policyID which is undefined
setMoneyRequestParticipants (called when participant is selected) updates transaction.participants but does NOT update transaction.reportID for non-test transactions (MoneyRequest.ts:1048-1055)
Confidence: High -- the code path is fully traced and the gap is clear.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: NA
Link to the comment on the Issue: NA
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Test:
Precondition:
Run Onyx.merge('betas', ['newManualExpenseFlow']); in console.
Enable Rules, Tags and Taxes in workspace settings.
Set Billable default to Billable.
Create a tag in Tags settings.
Test 1:
Go to staging.new.expensify.com
Go to workspace chat.
Click + > Create expense > Manual → Tag, Tax, Tax amount, Billable and Reimbursable fields are shown on confirm page.
Close the RHP.
Open FAB > Create expense > Manual.
Verify that: Tag, Tax, Tax amount, Billable and Reimbursable fields will be shown on confirm page when opened from FAB.
Activity
melvin-bot commentedon May 14, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #87920
melvin-bot commentedon May 14, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 14, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon May 14, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #87920 - "Feat: Manual expense flow UI refactor - r3" by @ChavdaSachin (High confidence)
Related Issues: #82586 (original issue this PR was fixing)
Recommendation: REVERT
PR #87920 introduced a regression where Tag, Tax, Tax amount, Billable, and Reimbursable fields are missing from the confirmation page when creating a manual expense from the FAB (global create), while they appear correctly when creating from workspace chat. Reverting this PR is the most straightforward fix since the bug is confined to this PR's changes.
Assigned: @ChavdaSachin (PR author), @ShridharGoel (approving reviewer), @puneetlath (approving reviewer) from highest-confidence causing PR only
Labels: No label changes needed —
DeployBlockerCashis correctly applied as this is a frontend App bug.Detailed Analysis
Evidence
StagingDeployCashchecklist for version9.3.74-1and was merged on 2026-05-13, aligning with the bug appearing in version9.3.74-0.Reproducible in production?: N/A - new feature), confirming the regression was introduced in this staging cycle.newManualExpenseFlowbeta, which is the exact feature this PR implements.Verification
src/pages/iou/request/step/IOURequestStepConfirmation.tsxandsrc/components/MoneyRequestConfirmationListFooter/fieldGroups/TransactionDetailsFields.tsx, both of which are directly modified by PR Feat: Manual expense flow UI refactor - r3 #87920.defaultParticipantsmemo inIOURequestStepConfirmation.tsxthat attempts to resolve participants for the global-create (FAB) flow usingtransaction?.reportID. When opening from FAB, the transaction has noreportIDset initially, sodefaultParticipantsreturns an empty array.policyExpenseChatPolicyIDis derived fromtransaction?.participants,defaultParticipants, andreport. When bothtransaction?.participantsanddefaultParticipantsare empty (as happens in the FAB flow before the user selects a participant),policyExpenseChatPolicyIDisundefined.policyExpenseChatPolicyID, thepolicyprop used inMoneyRequestConfirmationListisnull/undefined, causing the field visibility logic to hide Tag, Tax, Billable, and Reimbursable fields.+button), thereportIDis available on the transaction from the start (the workspace is the source report), sodefaultParticipantsresolves correctly and the policy fields appear.Root Cause
PR #87920 changed how participants and the effective policy are determined on the confirmation page. The new
defaultParticipantsmemo early-returns an empty array iftransaction?.reportIDis falsy, which is the case in the FAB/global-create flow before the user selects a participant. This leavespolicyExpenseChatPolicyIDasundefined, so thepolicyOnyx entry is never loaded, and all policy-dependent fields (Tag, Tax, Tax amount, Billable, Reimbursable) are hidden. The old code readpolicyExpenseChatPolicyIDdirectly from theparticipantsprop passed in from the parent, which was correctly populated for the workspace-chat case and was not expected to be empty for the FAB case.MelvinBot commentedon May 14, 2026
Proposal
What is the root cause of that problem?
When creating an expense from FAB, the route's
reportIDis empty (no workspace context yet). The functiongetIOURequestPolicyIDonly extracts apolicyIDfromisSenderparticipants (invoices) or fromreport?.policyID. It never checksisPolicyExpenseChatparticipants.So even after the user selects a workspace in the participant picker, the participant's
policyID(stored withisPolicyExpenseChat: true) is ignored by the policy resolution chain. This meanspolicyremainsundefinedinIOURequestStepConfirmation, and all policy-dependent fields (Tag, Tax, Billable, Reimbursable) are hidden.In the workspace chat flow,
report?.policyIDis already set from the start, so the policy resolves correctly and the fields appear.Notably,
policyExpenseChatPolicyIDalready correctly extracts the participant'spolicyID-- but it's only used forDraftWorkspaceOpener, not for the main policy resolution.What changes do you think we should make in order to solve the problem?
Update
getIOURequestPolicyIDinMoneyRequest.ts:1114to also check forisPolicyExpenseChatparticipants as a fallback:Where
policyExpenseChatParticipantis found viatransaction?.participants?.find((p) => p.isPolicyExpenseChat). This ensures that when a workspace is selected via the participant picker (FAB flow), the policy is resolved from the selected participant, making all policy-dependent fields visible.What alternative solutions did you explore? (Optional)
An alternative would be to have
IOURequestStepConfirmationfall back topolicyExpenseChatPolicyIDwhenrealPolicyID/draftPolicyIDare undefined. However, fixinggetIOURequestPolicyIDis cleaner since it's the central function for this purpose and would fix the issue for all callers, not just the confirmation page.Investigation details
Evidence chain:
reportIDin the route, soreportRealhas nopolicyIDgetIOURequestPolicyID(initialTransaction, reportReal)returnsundefined(IOURequestStepConfirmation.tsx:144)usePolicyForTransactionreceivesreportPolicyID: undefined, returnspolicy: undefinedpolicy:shouldShowTaxrequirespolicy?.tax?.trackingEnabledshouldShowBillablerequirespolicy?.disabledFields?.defaultBillable === falseshouldShowReimbursablerequires!!policyshouldShowTagsrequireshasEnabledTags(policyTagLists)butpolicyTagListsis empty since it's loaded bypolicyIDwhich isundefinedsetMoneyRequestParticipants(called when participant is selected) updatestransaction.participantsbut does NOT updatetransaction.reportIDfor non-test transactions (MoneyRequest.ts:1048-1055)Confidence: High -- the code path is fully traced and the gap is clear.
Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.ChavdaSachin commentedon May 14, 2026
NAB: only happens on beta accounts
puneetlath commentedon May 14, 2026
Demoting.
49 remaining items
melvin-bot commentedon Jun 15, 2026
Current assignee @mallenexpensify is eligible for the Awaiting Payment assigner, not assigning anyone new.
melvin-bot commentedon Jun 15, 2026
@ShridharGoel 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
mallenexpensify commentedon Jun 17, 2026
Payment Summary
Contributor: @dukenv0307 due $375 via NewDot
Contributor+: @thelullabyy due $125 via NewDot
@dukenv0307 is that correct? It looks like two of the PRs were reviewed by @ShridharGoel and the other by @thelullabyy
What test cases do we want here?
ShridharGoel commentedon Jun 17, 2026
@mallenexpensify I'll be paid together as part of the project, so I'll not be due payment here
mallenexpensify commentedon Jun 17, 2026
@ShridharGoel removed your details from the payment summary.
dukenv0307 commentedon Jun 18, 2026
@thelullabyy can you please complete the checklist?
thelullabyy commentedon Jun 18, 2026
BugZero Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: NA
Link to the comment on the Issue: NA
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Test:
Precondition:
Test 1:
Test 2:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-4c5f-a10f-70a8-9a4203be0424mallenexpensify commentedon Jun 18, 2026
Test cases created, think we're good to close
quinthar commentedon Jun 29, 2026
Approved $375 to @dukenv0307
laurenreidexpensify commentedon Aug 12, 2026
Approved $125 to @thelullabyy