You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Send Money - Incorrect chat conversation displayed after send money to non-existing account #9084
This bug isn't only about non-existing accounts. We just don't navigate to the report when a user sends money.
Proposal
When a user sends money payIOUReport gets called, inside the function after the api request we get two reports in the response the first one contains the reportID of the report that the user send money to we can just access that and we need to navigate user to that report.
@thesahindia Your proposal is half of the needed solution. We indeed navigate after sendMoney request is completed but it does not navigate to the report that we sent money. So Instead of your solution we need to correct the existing navigation logic (If this change is needed).
I dunno I'm not seeing the bug seems more like a feature request. If you send someone money it just sends them money. Is the expectation that we will switch you to that chat? Why and where was it decided?
Oh damn, when I looked at it I thought the same thing, but then for some reason thought the request was showing in the chat you had selected. I now realize that request was already there. I agree to close this out as this is not a bug.
@iwiznia why did you put 👎🏽 on the regression comment? The issue that it mentioned (#10902) is the same as this one no?
So there was a regression somewhere right?
Activity
melvin-bot commentedon May 18, 2022
Triggered auto assignment to @iwiznia (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.iwiznia commentedon May 19, 2022
Oh wow... yes, terrible bug.
melvin-bot commentedon May 19, 2022
Triggered auto assignment to @adelekennedy (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.thesahindia commentedon May 19, 2022
This bug isn't only about non-existing accounts. We just don't navigate to the report when a user sends money.
Proposal
When a user sends money payIOUReport gets called, inside the function after the api request we get two reports in the response the first one contains the reportID of the report that the user send money to we can just access that and we need to navigate user to that report.
To do this we can use this code -
(not sure what should be the variable name)
After this -
App/src/libs/actions/IOU.js
Lines 312 to 325 in 11a1f0d
adelekennedy commentedon May 20, 2022
Internal
External
11 remaining items
parasharrajat commentedon May 30, 2022
#6992 shows that this is expected behavior. cc: @flodnv @iwiznia
@thesahindia Your proposal is half of the needed solution. We indeed navigate after sendMoney request is completed but it does not navigate to the report that we sent money. So Instead of your solution we need to correct the existing navigation logic (If this change is needed).
flodnv commentedon May 30, 2022
😕 @marcaaron any thoughts on that?
marcaaron commentedon May 31, 2022
I dunno I'm not seeing the bug seems more like a feature request. If you send someone money it just sends them money. Is the expectation that we will switch you to that chat? Why and where was it decided?
iwiznia commentedon May 31, 2022
Oh damn, when I looked at it I thought the same thing, but then for some reason thought the request was showing in the chat you had selected. I now realize that request was already there. I agree to close this out as this is not a bug.
flodnv commentedon Jun 1, 2022
Agree
Justicea83 commentedon Jun 6, 2022
Agree
adelekennedy commentedon Jun 6, 2022
@flodnv @iwiznia @marcaaron @parasharrajat are we good to close this if it's expected behavior?
iwiznia commentedon Jun 6, 2022
Yep
melvin-bot commentedon Sep 8, 2022
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
madmax330 commentedon Sep 12, 2022
@iwiznia why did you put 👎🏽 on the regression comment? The issue that it mentioned (#10902) is the same as this one no?
So there was a regression somewhere right?
iwiznia commentedon Sep 12, 2022
This issue was closed with no changes, so it can't have caused a regression. We decided this is not a bug.
melvin-bot commentedon Sep 12, 2022
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.