Skip to content

[Due for payment 2026-05-26] [No QA] perf: replace lodash mapKeys with native loop in usePersonalDetailsByEmail #90946

Closed

Description

@mountiny

Problem

The usePersonalDetailsByEmail hook uses lodash/mapKeys to build a map of personal details keyed by login. Lodash's mapKeys carries internal type-checking and iteration overhead that is unnecessary for this straightforward transformation, and it introduces an additional lodash dependency into the hook.

Solution

Replace the lodash/mapKeys call with a native for...of loop over Object.entries. This removes the lodash dependency and avoids its internal overhead, producing the same result — a map keyed by each personal detail's login (falling back to the original key if login is absent). A similar replacement was done in WorkflowUtils in PR #89477 and showed around a 4x performance improvement.

PR

#90944

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on May 19, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  2. changed the title [-][No QA] perf: replace lodash mapKeys with native loop in usePersonalDetailsByEmail[/-] [+][Due for payment 2026-05-26] [No QA] perf: replace lodash mapKeys with native loop in usePersonalDetailsByEmail[/+] on May 19, 2026
  3. melvin-bot commented on May 19, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.77-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-05-26. 🎊

    For reference, here are some details about the assignees on this issue:

  4. melvin-bot commented on May 20, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  5. melvin-bot commented on May 25, 2026

    @melvin-bot

    @mallenexpensify Eep! 4 days overdue now. Issues have feelings too...

  6. melvin-bot commented on May 26, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  7. mallenexpensify commented on May 27, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @abzokhattab due $125 via NewDot

    No tests needed, perf

  8. quinthar commented on Jun 29, 2026

    @quinthar
    Contributor

    Approved $125 to @abzokhattab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Task

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions