Skip to content

[Due for payment 2026-07-23] [$500] [R1] Show pending BYOC transactions in NewDot #91098

Closed

Description

@amyevans

Project: Pending BYOC transactions

Project tracking issue: https://github.com/Expensify/Expensify/issues/570780

Design doc section

Implement the linked section of the design doc!

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on May 19, 2026

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

  2. amyevans commented on May 19, 2026

    @amyevans
    ContributorAuthor

    @daledah will handle implementation here. I've shared the doc, hit us up with any questions as you go!

  3. daledah commented on May 20, 2026

    @daledah
    Contributor

    Thanks @amyevans! I’ll go through the docs and raise a PR soon.

  4. daledah commented on May 21, 2026

    @daledah
    Contributor
    Image

    @amyevans I already have a draft PR here, but we still need to run the auto translations here. Could you help me with that? I’ll open the PR afterward.

  5. dannymcclain commented on May 21, 2026

    @dannymcclain
    Contributor

    @daledah will you add Expensify/design as a reviewer when the PR is ready for review please? 🙏

  6. daledah commented on May 21, 2026

    @daledah
    Contributor

    @amyevans The PR is complete and ready for review now. Should I open the PR already, or wait until we have a reviewer assigned first?

  7. amyevans commented on May 21, 2026

    @amyevans
    ContributorAuthor

    Let's wait til we have a reviewer first. I'll source one tomorrow!

  8. amyevans commented on May 22, 2026

    @amyevans
    ContributorAuthor

    Assigning @sobitneupane for C+ reviewer as they've got some recent related experience. They're available to review the PR early next week

  9. 36 remaining items

  10. sobitneupane commented on Jul 23, 2026

    @sobitneupane
    Contributor

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@sobitneupane] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

    • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

  11. daledah commented on Jul 23, 2026

    @daledah
    Contributor

    @mallenexpensify @amyevans cc @sobitneupane

    I want to propose amount to increase the price to: $500

    • Multiple PRs:
      • #91231 - Show pending BYOC transactions in NewDot (25 files, +177/-40, 41 commits)
      • #95923 - Fix pending transaction message in money request header (12 files, +13/-2)
    • Scope expansion: Changes span multiple core areas - MoneyReportHeader actions, MoneyRequestReportPreview provider, TransactionItemRow TypeCell, bulk actions hook (useSearchBulkActions), expense actions hook, TransactionUtils with new pending BYOC logic, DynamicReportDetailsPage, and translations across 10 locales. An additional fix PR was needed post-merge.
    • Core flow changes: Modifies money request headers, report preview provider, transaction type display, expense action menus, and search bulk actions - all high-traffic user flows requiring careful review to prevent regressions.
    • Test coverage: Unit tests added in TransactionUtilsTest.
    • Files touched: 37 files across 2 PRs
  12. amyevans commented on Jul 24, 2026

    @amyevans
    ContributorAuthor

    👍 to price increase

    The regression test proposal also looks fine, but we'll add them as part of the project, so no need to do anything with them now.

  13. changed the title [-][Due for payment 2026-07-23] [R1] Show pending BYOC transactions in NewDot[/-] [+][Due for payment 2026-07-23] [$500] [R1] Show pending BYOC transactions in NewDot[/+] on Jul 24, 2026
  14. melvin-bot commented on Jul 24, 2026

    @melvin-bot

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  15. amyevans commented on Jul 24, 2026

    @amyevans
    ContributorAuthor

    So this one should be ready for you @mallenexpensify!

  16. mallenexpensify commented on Jul 27, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @daledah due $500 via NewDot
    Contributor+: @sobitneupane due $500 via NewDot

    ^ Test case created. Thx

  17. JmillsExpensify commented on Jul 28, 2026

    @JmillsExpensify
    Contributor

    $500 approved for @sobitneupane

  18. quinthar commented on Aug 19, 2026

    @quinthar
    Contributor

    Approved $500 to @daledah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringNewFeatureSomething to build that is a new item.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions