Skip to content

[Due for payment 2026-06-08] Company cards - User name is white on white card image #91139

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.78-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #89379
Email or phone of affected tester (no customers): applausetester+ssndjois2jd@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Add Region direct feed on workspace settings > Company cards.
  • Assign one of the cards to yourself.
  • Disable High contrast mode in Account > Preferences > Theme.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Company cards.
  3. Open the assigned card.
  4. Highlight user name on the card image.

Expected Result:

User name should be black on white card image.

Actual Result:

User name is white on white card image.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7158365_1779231510892.5.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7158365

Activity

  1. applause-bot commented on May 19, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/fd3f2ac6fc1fa4f44600733cea721e440c7f021b30b596f7210769e112456f8c

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 19, 2026
  3. melvin-bot commented on May 19, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #89379

  4. melvin-bot commented on May 19, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 19, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on May 19, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    PR #89379 moved cardholder names onto card artwork. The name text uses the walletCardHolder style, which hardcodes color: theme.textLight. In light theme, textLight resolves to colors.white (#FFFFFF).

    This works fine for Expensify cards (dark green background), but company cards (e.g. Region direct feed) can have white/light card images. The name is rendered as white text directly over the card image with no adaptation for the background color — producing invisible white-on-white text.

    What changes do you think we should make in order to solve the problem?

    Add a textShadow (or shadow properties on native) to the walletCardHolder style so the text remains legible on any card background. A subtle dark text shadow (e.g. 0 0 4px rgba(0,0,0,0.6)) would make white text readable on both light and dark card images without needing per-card color logic.

    Alternatively, accept an optional cardHolderStyle override in WorkspaceCompanyCardDetailsPage and pass color: theme.text (dark text) specifically for company cards that use light card images, while keeping theme.textLight for Expensify-branded cards.

    What alternative solutions did you explore? (Optional)

    Dynamically detecting the card image luminance at runtime would be more robust but adds unnecessary complexity. The text shadow approach is simpler and handles all card backgrounds uniformly.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  7. nkuoch commented on May 20, 2026

    @nkuoch
    Contributor

    Probably not a deploy blocker since they are related to high contrast mode setting? @ShridharGoel will work on this

  8. roryabraham commented on May 20, 2026

    @roryabraham
    Contributor

    This is actually not on high contrast mode.

  9. Pujan92 commented on May 20, 2026

    @Pujan92
    Contributor

    I think this is not a DB, as the background image depends on the selected bank. For most of the banks, I believe white text will be visible. Member displayname is shown in the list so we can demote this and need to get inputs from @Expensify/design.

  10. dannymcclain commented on May 20, 2026

    @dannymcclain
    Contributor

    Agree this probably isn't a deploy blocker, but it definitely needs fixing. Does this happen with all card images coming from Plaid? If so I wonder if we could change the text color if we know that this will happen. @Expensify/design any other ideas come to mind?

  11. 9 remaining items

  12. added and removed
    ReviewingHas a PR in review
    on Jun 1, 2026
  13. changed the title [-]Company cards - User name is white on white card image[/-] [+][Due for payment 2026-06-08] Company cards - User name is white on white card image[/+] on Jun 1, 2026
  14. melvin-bot commented on Jun 1, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Jun 1, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.89-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-08. 🎊

  16. melvin-bot commented on Jun 1, 2026

    @melvin-bot

    @roryabraham The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  17. roryabraham commented on Jun 3, 2026

    @roryabraham
    Contributor

    This is fixed, payment will be handled in another issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions