You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-01] [$250] [Internal] [Domain Control] Adjust illustration area size in the SAML settings page #91312
Fix: Add height: variables.sectionIllustrationHeight to the emptyStateCardIllustrationContainer style in src/styles/index.ts:5407-5410, which is passed as the illustrationContainerStyle for the outer blue container. This keeps the SVG at 218×190 but ensures the blue background area is 220px, matching the expected design.
DomainSamlPage passes illustrationStyle={styles.emptyStateSamlIllustration} (width: 218, height: 190) and illustrationContainerStyle={[styles.emptyStateCardIllustrationContainer, styles.justifyContentCenter]}
Section renders the outer blue container with illustrationContainerStyle (no height set) and the inner illustration View with [cardSectionIllustration, illustrationStyle]
Outer container auto-sizes to child → blue area = 190px
Why emptyStateCardIllustrationContainer is the right place: Other illustration containers (e.g., cardSectionIllustrationContainer) already set height: variables.sectionIllustrationHeight on the outer container. The emptyStateCardIllustrationContainer is missing this, which is the inconsistency causing this bug.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-][Internal] [Domain Control] Adjust illustration area size in the SAML settings page[/-][+][$250] [Internal] [Domain Control] Adjust illustration area size in the SAML settings page[/+]on May 21, 2026
changed the title [-][$250] [Internal] [Domain Control] Adjust illustration area size in the SAML settings page[/-][+][Due for payment 2026-06-01] [$250] [Internal] [Domain Control] Adjust illustration area size in the SAML settings page[/+]on May 25, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.81-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@ZhenjaHorbach / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
rayane-d commentedon May 21, 2026
Note: This is not open for external proposals
MelvinBot commentedon May 21, 2026
Proposal
Problem
The blue illustration area on the SAML settings page is 190px tall instead of the expected 220px.
Solution
The root cause is in
DomainSamlPage.tsx:145-164, which passesillustrationStyle={styles.emptyStateSamlIllustration}toFeatureList→Section.In the
Sectioncomponent (line 162), the inner illustrationViewreceivesstyle={[styles.cardSectionIllustration, illustrationStyle]}. The base stylecardSectionIllustrationsetsheight: 220(viavariables.sectionIllustrationHeight), butemptyStateSamlIllustrationoverrides it withheight: 190. Since the outer blue container (lines 152-160) has no explicit height, it auto-sizes to 190px.Fix: Add
height: variables.sectionIllustrationHeightto theemptyStateCardIllustrationContainerstyle insrc/styles/index.ts:5407-5410, which is passed as theillustrationContainerStylefor the outer blue container. This keeps the SVG at 218×190 but ensures the blue background area is 220px, matching the expected design.emptyStateCardIllustrationContainer: { ...flex.alignItemsCenter, ...flex.justifyContentCenter, + height: variables.sectionIllustrationHeight, },Investigation details
Style merge chain:
DomainSamlPagepassesillustrationStyle={styles.emptyStateSamlIllustration}(width: 218, height: 190) andillustrationContainerStyle={[styles.emptyStateCardIllustrationContainer, styles.justifyContentCenter]}Sectionrenders the outer blue container withillustrationContainerStyle(no height set) and the inner illustrationViewwith[cardSectionIllustration, illustrationStyle]illustrationStyle.height(190) overridescardSectionIllustration.height(220)Why
emptyStateCardIllustrationContaineris the right place: Other illustration containers (e.g.,cardSectionIllustrationContainer) already setheight: variables.sectionIllustrationHeighton the outer container. TheemptyStateCardIllustrationContaineris missing this, which is the inconsistency causing this bug.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.rayane-d commentedon May 21, 2026
@MelvinBot implement this
MelvinBot commentedon May 21, 2026
🤖 Draft PR created: #91313
Please mark it as "Ready for review" when it is ready for review.
[-][Internal] [Domain Control] Adjust illustration area size in the SAML settings page[/-][+][$250] [Internal] [Domain Control] Adjust illustration area size in the SAML settings page[/+]melvin-bot commentedon May 21, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022057474917325256050
[-][$250] [Internal] [Domain Control] Adjust illustration area size in the SAML settings page[/-][+][Due for payment 2026-06-01] [$250] [Internal] [Domain Control] Adjust illustration area size in the SAML settings page[/+]melvin-bot commentedon May 25, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 25, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.81-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-01. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 25, 2026
@ZhenjaHorbach / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
rayane-d commentedon May 26, 2026
done