Skip to content

[Due for payment 2026-06-01] [$250] [Internal] [Domain Control] Adjust illustration area size in the SAML settings page #91312

Closed

Description

@rayane-d

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.3.78-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from BrowserStack: N/A
Email or phone of affected tester (no customers): N/A
Logs: https://stackoverflow.com/c/expensify/questions/4856 N/A
Expensify/Expensify Issue URL: N/A
Issue reported by: @shawnborton
Slack conversation (hyperlinked to channel name): https://expensify.slack.com/archives/C0A1VKRKEE9/p1779197374514199?thread_ts=1774958577.226549&cid=C0A1VKRKEE9

Action Performed:

  1. Create an unvalidated domain
  2. Open SAML settings

Expected Result:

The illustration should be 218×190, and the height of the blue area of the illustration should be 220px

Actual Result:

The illustration is 218×190, and the blue area has a height of 190px

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
N/A

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Image Image

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @ZhenjaHorbach
Upwork Automation - Do Not Edit

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 21, 2026
  2. rayane-d commented on May 21, 2026

    @rayane-d
    ContributorAuthor

    Note: This is not open for external proposals

  3. MelvinBot commented on May 21, 2026

    @MelvinBot
    Contributor

    Proposal

    Problem

    The blue illustration area on the SAML settings page is 190px tall instead of the expected 220px.

    Solution

    The root cause is in DomainSamlPage.tsx:145-164, which passes illustrationStyle={styles.emptyStateSamlIllustration} to FeatureList → Section.

    In the Section component (line 162), the inner illustration View receives style={[styles.cardSectionIllustration, illustrationStyle]}. The base style cardSectionIllustration sets height: 220 (via variables.sectionIllustrationHeight), but emptyStateSamlIllustration overrides it with height: 190. Since the outer blue container (lines 152-160) has no explicit height, it auto-sizes to 190px.

    Fix: Add height: variables.sectionIllustrationHeight to the emptyStateCardIllustrationContainer style in src/styles/index.ts:5407-5410, which is passed as the illustrationContainerStyle for the outer blue container. This keeps the SVG at 218×190 but ensures the blue background area is 220px, matching the expected design.

     emptyStateCardIllustrationContainer: {
         ...flex.alignItemsCenter,
         ...flex.justifyContentCenter,
    +    height: variables.sectionIllustrationHeight,
     },
    Investigation details

    Style merge chain:

    1. DomainSamlPage passes illustrationStyle={styles.emptyStateSamlIllustration} (width: 218, height: 190) and illustrationContainerStyle={[styles.emptyStateCardIllustrationContainer, styles.justifyContentCenter]}
    2. Section renders the outer blue container with illustrationContainerStyle (no height set) and the inner illustration View with [cardSectionIllustration, illustrationStyle]
    3. RN style array merge: illustrationStyle.height (190) overrides cardSectionIllustration.height (220)
    4. Outer container auto-sizes to child → blue area = 190px

    Why emptyStateCardIllustrationContainer is the right place: Other illustration containers (e.g., cardSectionIllustrationContainer) already set height: variables.sectionIllustrationHeight on the outer container. The emptyStateCardIllustrationContainer is missing this, which is the inconsistency causing this bug.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  4. rayane-d commented on May 21, 2026

    @rayane-d
    ContributorAuthor

    @MelvinBot implement this

  5. MelvinBot commented on May 21, 2026

    @MelvinBot
    Contributor

    🤖 Draft PR created: #91313
    Please mark it as "Ready for review" when it is ready for review.

  6. changed the title [-][Internal] [Domain Control] Adjust illustration area size in the SAML settings page[/-] [+][$250] [Internal] [Domain Control] Adjust illustration area size in the SAML settings page[/+] on May 21, 2026
  7. melvin-bot commented on May 21, 2026

    @melvin-bot
  8. changed the title [-][$250] [Internal] [Domain Control] Adjust illustration area size in the SAML settings page[/-] [+][Due for payment 2026-06-01] [$250] [Internal] [Domain Control] Adjust illustration area size in the SAML settings page[/+] on May 25, 2026
  9. melvin-bot commented on May 25, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on May 25, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.81-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-01. 🎊

    For reference, here are some details about the assignees on this issue:

    • @ZhenjaHorbach requires payment through NewDot Manual Requests
    • @rayane-d does not require payment (Contractor)
    • @situchan requires payment through NewDot Manual Requests
  11. melvin-bot commented on May 25, 2026

    @melvin-bot

    @ZhenjaHorbach / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  12. rayane-d commented on May 26, 2026

    @rayane-d
    ContributorAuthor

    done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions