Skip to content

[Due for payment 2026-06-01] [$250] Don't show agent timezone #91346

Closed

Description

@puneetlath

Right now, we show the "local time" when looking at an agent's profile. Let's remove that.

Image

And we also show the current time above the composer in the agent DM. Let's also remove that.

Image
Issue OwnerCurrent Issue Owner: @ShridharGoel
Upwork Automation - Do Not Edit

Activity

  1. NicolasBonet commented on May 21, 2026

    @NicolasBonet
    Contributor

    @MelvinBot investigate this

  2. MelvinBot commented on May 21, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    Agent accounts (matching agent_\d+@expensify.ai) are not filtered out from the local time displays. The profile page only excludes automated Expensify bot accounts via hasAutomatedExpensifyAccountIDs, and the composer time display in canShowReportRecipientLocalTime has no agent filtering at all.

    What changes do you think we should make in order to solve the problem?

    Two locations need an isAgentEmail check on the viewed user's login:

    1. Profile page (ProfilePage.tsx:127): Add !isAgentEmail(login) to the shouldShowLocalTime condition, using the login variable already available at line 120.

    2. Composer local time (ComposerLocalTime.tsx:22-24): After resolving reportRecipient, add an early return if isAgentEmail(reportRecipient?.login).

    isAgentEmail is already exported from SessionUtils.ts:113.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  3. NicolasBonet commented on May 21, 2026

    @NicolasBonet
    Contributor

    @MelvinBot implement this

  4. NicolasBonet commented on May 21, 2026

    @NicolasBonet
    Contributor

    @MelvinBot implement this

  5. MelvinBot commented on May 21, 2026

    @MelvinBot
    Contributor

    🤖 Draft PR created: #91347
    Please mark it as "Ready for review" when it is ready for review.

  6. MelvinBot commented on May 21, 2026

    @MelvinBot
    Contributor

    🤖 The draft PR already exists: #91347

    All CI checks are passing. Please mark it as "Ready for review" when it is ready for review.

  7. changed the title [-]Don't show agent timezone[/-] [+][$250] Don't show agent timezone[/+] on May 22, 2026
  8. melvin-bot commented on May 22, 2026

    @melvin-bot
  9. NicolasBonet commented on May 25, 2026

    @NicolasBonet
    Contributor

    @MelvinBot this was already merged with a PR, why are you adding it to Upwork? Remove it

  10. MelvinBot commented on May 25, 2026

    @MelvinBot
    Contributor

    The Upwork job was posted by the legacy melvin-bot automation at 05:19 UTC on May 22, before PR #91347 was merged at 13:03 UTC that same day. I (MelvinBot) didn't post it.

    I don't have the ability to remove Upwork job postings — that needs to be done manually or by the Upwork automation system. Since the PR is already merged, this issue can likely be closed.

  11. changed the title [-][$250] Don't show agent timezone[/-] [+][Due for payment 2026-06-01] [$250] Don't show agent timezone[/+] on May 25, 2026
  12. melvin-bot commented on May 25, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on May 25, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.81-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-01. 🎊

    For reference, here are some details about the assignees on this issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions