Skip to content

[Due for payment 2026-06-01] Workspaces - "Select All" checkbox not aligned with remaining checkboxes on "Copy Settings" #91381

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.79-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #90079
Email or phone of affected tester (no customers): ibellicotest+2250@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Windows 11 / Chrome
App Component: Workspace Settings

Action Performed:

Prerequisite: Account has at least five workspaces created.

  1. Open the staging.new.expensify.com website.
  2. Navigate to "Workspaces"
  3. Click on the three dots icon on a workspace and select "Copy Settings"
  4. Note that during workspace selection step, "Select All" checkbox is not aligned with the rest of workspaces checkboxes.

Expected Result:

"Select All" checkbox should be aligned with the rest of the checkboxes during workspace selection on "Copy Settings" process.

Actual Result:

"Select All" checkbox is not aligned with the rest of the checkboxes furing workspace selection on "Copy Settings" process.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7160192_1779408889706.Misaligned.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7160192

Issue OwnerCurrent Issue Owner: @fedirjh

Activity

  1. applause-bot commented on May 22, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/f145124889504cdd2b7835ad875089bc4b4dad412e75996905a2b0f54b4d7cc1

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 22, 2026
  3. melvin-bot commented on May 22, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #90079

  4. melvin-bot commented on May 22, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 22, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on May 22, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    The "Select All" header in CopyPolicySettingsSelectWorkspacesPage.tsx renders a SelectionList without setting shouldHeaderBeInsideList. This defaults to false (BaseSelectionList.tsx:86), which places the header outside the FlashList's ScrollView (line 612) while list items are rendered inside it. On Windows Chrome, the scrollbar reduces the content width inside the ScrollView, making list item checkboxes narrower/offset compared to the header checkbox.

    What changes do you think we should make in order to solve the problem?

    Add shouldHeaderBeInsideList to the SelectionList in CopyPolicySettingsSelectWorkspacesPage.tsx:182. This moves the header inside the FlashList so it shares the same width context as the list items, keeping checkboxes aligned.

    This is the same pattern used by other workspace pages with multi-select lists (WorkspaceMembersPage, WorkspaceCategoriesPage, WorkspaceTagsPage, PolicyDistanceRatesPage, WorkspaceTaxesPage, etc.).


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  7. self-assigned this
    on May 22, 2026
  8. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on May 22, 2026
  9. 3 remaining items

  10. changed the title [-]Workspaces - "Select All" checkbox not aligned with remaining checkboxes on "Copy Settings"[/-] [+][Due for payment 2026-06-01] Workspaces - "Select All" checkbox not aligned with remaining checkboxes on "Copy Settings"[/+] on May 25, 2026
  11. melvin-bot commented on May 25, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on May 25, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.81-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-01. 🎊

    For reference, here are some details about the assignees on this issue:

    • @fedirjh does not require payment (Contractor)
  13. melvin-bot commented on May 25, 2026

    @melvin-bot

    @francoisl @fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. melvin-bot commented on May 29, 2026

    @melvin-bot

    @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

  15. melvin-bot commented on Jun 2, 2026

    @melvin-bot

    @fedirjh 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  16. fedirjh commented on Jun 3, 2026

    @fedirjh
    Contributor

    This was fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions