You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-01] Workspaces - "Select All" checkbox not aligned with remaining checkboxes on "Copy Settings" #91381
Version Number: 9.3.79-1 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#90079 Email or phone of affected tester (no customers):ibellicotest+2250@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Windows 11 / Chrome App Component: Workspace Settings
Action Performed:
Prerequisite: Account has at least five workspaces created.
Open the staging.new.expensify.com website.
Navigate to "Workspaces"
Click on the three dots icon on a workspace and select "Copy Settings"
Note that during workspace selection step, "Select All" checkbox is not aligned with the rest of workspaces checkboxes.
Expected Result:
"Select All" checkbox should be aligned with the rest of the checkboxes during workspace selection on "Copy Settings" process.
Actual Result:
"Select All" checkbox is not aligned with the rest of the checkboxes furing workspace selection on "Copy Settings" process.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The "Select All" header in CopyPolicySettingsSelectWorkspacesPage.tsx renders a SelectionList without setting shouldHeaderBeInsideList. This defaults to false (BaseSelectionList.tsx:86), which places the header outside the FlashList's ScrollView (line 612) while list items are rendered inside it. On Windows Chrome, the scrollbar reduces the content width inside the ScrollView, making list item checkboxes narrower/offset compared to the header checkbox.
What changes do you think we should make in order to solve the problem?
Add shouldHeaderBeInsideList to the SelectionList in CopyPolicySettingsSelectWorkspacesPage.tsx:182. This moves the header inside the FlashList so it shares the same width context as the list items, keeping checkboxes aligned.
This is the same pattern used by other workspace pages with multi-select lists (WorkspaceMembersPage, WorkspaceCategoriesPage, WorkspaceTagsPage, PolicyDistanceRatesPage, WorkspaceTaxesPage, etc.).
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-]Workspaces - "Select All" checkbox not aligned with remaining checkboxes on "Copy Settings"[/-][+][Due for payment 2026-06-01] Workspaces - "Select All" checkbox not aligned with remaining checkboxes on "Copy Settings"[/+]on May 25, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.81-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@francoisl@fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
applause-bot commentedon May 22, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/f145124889504cdd2b7835ad875089bc4b4dad412e75996905a2b0f54b4d7cc1
melvin-bot commentedon May 22, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #90079
melvin-bot commentedon May 22, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 22, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon May 22, 2026
Proposal
What is the root cause of that problem?
The "Select All" header in
CopyPolicySettingsSelectWorkspacesPage.tsxrenders aSelectionListwithout settingshouldHeaderBeInsideList. This defaults tofalse(BaseSelectionList.tsx:86), which places the header outside the FlashList's ScrollView (line 612) while list items are rendered inside it. On Windows Chrome, the scrollbar reduces the content width inside the ScrollView, making list item checkboxes narrower/offset compared to the header checkbox.What changes do you think we should make in order to solve the problem?
Add
shouldHeaderBeInsideListto theSelectionListinCopyPolicySettingsSelectWorkspacesPage.tsx:182. This moves the header inside the FlashList so it shares the same width context as the list items, keeping checkboxes aligned.This is the same pattern used by other workspace pages with multi-select lists (WorkspaceMembersPage, WorkspaceCategoriesPage, WorkspaceTagsPage, PolicyDistanceRatesPage, WorkspaceTaxesPage, etc.).
Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.3 remaining items
[-]Workspaces - "Select All" checkbox not aligned with remaining checkboxes on "Copy Settings"[/-][+][Due for payment 2026-06-01] Workspaces - "Select All" checkbox not aligned with remaining checkboxes on "Copy Settings"[/+]melvin-bot commentedon May 25, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 25, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.81-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-01. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 25, 2026
@francoisl @fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon May 29, 2026
@fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Jun 2, 2026
@fedirjh 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
fedirjh commentedon Jun 3, 2026
This was fixed.