You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-08] Web - Expense - Currency RHP opens without animation #91382
Version Number: 9.3.79-1 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#90212 Email or phone of affected tester (no customers):sdsdjoijdoisnjodis@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Money Requests
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
PR #90212 changed the default web animation timing (DEFAULT_IN) from 300ms to 1ms (src/libs/Animation/animationTiming/index.ts). The intent was for each navigator to explicitly opt into the new RHP_DURATION_IN_WEB (150ms) / RHP_DURATION_OUT_WEB (100ms) constants via a transitionSpec override.
The inner RHP modal stack screens correctly received the explicit transitionSpec in useModalStackScreenOptions.ts:58-61. However, the outer rightModalNavigator in useRootNavigatorScreenOptions.ts:43-51 only sets presentation: TRANSPARENT_MODAL and a custom cardStyleInterpolator in its web options — no transitionSpec. While animation: SLIDE_FROM_RIGHT resolves to a config with 150ms via slideFromRight/index.ts, the presentation: 'transparentModal' mode causes React Navigation to apply its own transition preset defaults which depend on the now-1ms DEFAULT_IN, effectively making the RHP appear instantly.
Additionally, the cardStyleInterpolator was changed from CardStyleInterpolators.forHorizontalIOS (full-width slide) to a slide-and-fade with only 60px travel — which would be far subtler even if the timing were correct.
What changes do you think we should make in order to solve the problem?
Add an explicit transitionSpec to the rightModalNavigator's web options in useRootNavigatorScreenOptions.ts, matching the pattern already used in useModalStackScreenOptions.ts:
This ensures the rightModalNavigator uses the intended 150ms/100ms durations instead of falling back to the 1ms web default.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not needed.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
applause-bot commentedon May 22, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/c3dc9f768906d04fd9c21a82a6a814ef6d1517cc08690bf6fb8a4c937eed4c04
melvin-bot commentedon May 22, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #90212
melvin-bot commentedon May 22, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 22, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon May 22, 2026
Proposal
What is the root cause of that problem?
PR #90212 changed the default web animation timing (
DEFAULT_IN) from 300ms to 1ms (src/libs/Animation/animationTiming/index.ts). The intent was for each navigator to explicitly opt into the newRHP_DURATION_IN_WEB(150ms) /RHP_DURATION_OUT_WEB(100ms) constants via atransitionSpecoverride.The inner RHP modal stack screens correctly received the explicit
transitionSpecinuseModalStackScreenOptions.ts:58-61. However, the outerrightModalNavigatorinuseRootNavigatorScreenOptions.ts:43-51only setspresentation: TRANSPARENT_MODALand a customcardStyleInterpolatorin itsweboptions — notransitionSpec. Whileanimation: SLIDE_FROM_RIGHTresolves to a config with 150ms viaslideFromRight/index.ts, thepresentation: 'transparentModal'mode causes React Navigation to apply its own transition preset defaults which depend on the now-1msDEFAULT_IN, effectively making the RHP appear instantly.Additionally, the
cardStyleInterpolatorwas changed fromCardStyleInterpolators.forHorizontalIOS(full-width slide) to aslide-and-fadewith only 60px travel — which would be far subtler even if the timing were correct.What changes do you think we should make in order to solve the problem?
Add an explicit
transitionSpecto therightModalNavigator'sweboptions inuseRootNavigatorScreenOptions.ts, matching the pattern already used inuseModalStackScreenOptions.ts:This ensures the
rightModalNavigatoruses the intended 150ms/100ms durations instead of falling back to the 1ms web default.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.mjasikowski commentedon May 22, 2026
@adhorodyski I think this is one for you
mjasikowski commentedon May 22, 2026
But it's a minor UI issue, so removing the blocker label
18 remaining items
parasharrajat commentedon Jun 5, 2026
BugZero Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: [No QA] Tune web modal, dropdown and RHP animations #90212
Link to the comment on the Issue: [No QA] Tune web modal, dropdown and RHP animations #90212
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not needed.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Not needed.
Do we agree 👍 or 👎
melvin-bot commentedon Jun 7, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Jun 7, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Jun 8, 2026
Payment Summary
Contributor+: @parasharrajat due $250 via NewDot
parasharrajat commentedon Jul 5, 2026
Payment requested as per #91382 (comment)
garrettmknight commentedon Jul 6, 2026
$250 approved for @parasharrajat