Skip to content

Onboarding - Onboarding task are not shown when select Manage my team (11-50 employee or more) #91384

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: V9.3.79-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176677/test-cases/41237662
Email or phone of affected tester (no customers): dreamnitethedragon+vegst@gmail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Win 10 chrome
App Component: Chat Report View

Action Performed:

  1. Go to staging.new.expensify.com
  2. Login with + gmail account
  3. Select Manage my team > 11-50 employee or more > QBD
  4. Open Concierge

Expected Result:

Onboarding tasks must be shown in concierge.

Actual Result:

Onboarding tasks are not shown in concierge.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7160307_1779420344952.bandicam_2026-05-22_08-47-33-251.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Rizky Gunawan
Bug ID: 7160307

Activity

  1. applause-bot commented on May 22, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/1ac940b709a1ac9866cdd105bcff49044ec3a3b0adea602977c8b30686bdd008

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 22, 2026
  3. melvin-bot commented on May 22, 2026

    @melvin-bot

    Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on May 22, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 22, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. changed the title [-]Onboarding-Onboarding task are not shown when select Manage my team (11-50 employee or more)[/-] [+]Onboarding - Onboarding task are not shown when select Manage my team (11-50 employee or more)[/+] on May 22, 2026
  7. MelvinBot commented on May 22, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    Two PRs merged on May 21 created a partially-deployed multi-step rollout that breaks onboarding for MANAGE_TEAM users:

    1. PR [Payment due @ChavdaSachin] Onboarding: drop cohort gate now that server generates per-tier welcome #89469 removed the cohort gate so ALL MANAGE_TEAM signups (not just micro companies) set shouldUseFollowupsInsteadOfTasks = true at ReportUtils.ts:11622. Previously, 11-50+ employee signups got client-side optimistic tasks.

    2. PR [Payment due @hungvu193] [No QA] Add inbAdminsWel onboarding variant + send MANAGE_TEAM tasks to server without optimistic flash #91263 (Step 1 of a 4-step rollout) then removed all client-side optimistic task data for these users at ReportUtils.ts:11960, relying on the server to create the visible welcome and tasks. The PR explicitly states: "No user-visible change until Step 2 deploys."

    Step 2 (a Web-Expensify server-side PR) has not deployed to staging yet, so the server doesn't create the tasks either — resulting in nothing appearing for the user.

    Additionally, shouldUseFollowupsInsteadOfTasks now overrides the isPostingTasksInAdminsRoom() check (which was designed to keep + alias email users on the Concierge path), routing tasks to #admins instead of Concierge for all MANAGE_TEAM users regardless.

    What changes do you think we should make in order to solve the problem?

    Since this is a coordinated multi-step deploy where Step 1 (client) deployed without Step 2 (server), the options are:

    1. Revert PR [Payment due @hungvu193] [No QA] Add inbAdminsWel onboarding variant + send MANAGE_TEAM tasks to server without optimistic flash #91263 to restore client-side optimistic task rendering for MANAGE_TEAM users until the server-side Step 2 is ready to deploy simultaneously.
    2. Coordinate deploy — deploy the Web-Expensify Step 2 PR to staging so the server correctly creates the welcome message and tasks for all MANAGE_TEAM signups.
    3. Guard the change — re-add a gate (e.g., check the inbAdminsWel variant from Auth Step 3) so optimistic tasks are only suppressed when the full pipeline is active.

    Option 1 (revert) is the safest immediate fix for the deploy blocker.

    Investigation details

    Key code path:

    Possibly related issues:


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  8. marcochavezf commented on May 22, 2026

    @marcochavezf
    Contributor

    This is expected, since the welcome message is replacing the onboarding tasks. Also, we're moving the welcome messages to a new variant here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions