You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Onboarding - Onboarding task are not shown when select Manage my team (11-50 employee or more) #91384
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]Onboarding-Onboarding task are not shown when select Manage my team (11-50 employee or more)[/-][+]Onboarding - Onboarding task are not shown when select Manage my team (11-50 employee or more)[/+]on May 22, 2026
Step 2 (a Web-Expensify server-side PR) has not deployed to staging yet, so the server doesn't create the tasks either — resulting in nothing appearing for the user.
Additionally, shouldUseFollowupsInsteadOfTasks now overrides the isPostingTasksInAdminsRoom() check (which was designed to keep + alias email users on the Concierge path), routing tasks to #admins instead of Concierge for all MANAGE_TEAM users regardless.
What changes do you think we should make in order to solve the problem?
Since this is a coordinated multi-step deploy where Step 1 (client) deployed without Step 2 (server), the options are:
Coordinate deploy — deploy the Web-Expensify Step 2 PR to staging so the server correctly creates the welcome message and tasks for all MANAGE_TEAM signups.
Guard the change — re-add a gate (e.g., check the inbAdminsWel variant from Auth Step 3) so optimistic tasks are only suppressed when the full pipeline is active.
Option 1 (revert) is the safest immediate fix for the deploy blocker.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
Activity
applause-bot commentedon May 22, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/1ac940b709a1ac9866cdd105bcff49044ec3a3b0adea602977c8b30686bdd008
melvin-bot commentedon May 22, 2026
Triggered auto assignment to @arosiclair (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 22, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 22, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
[-]Onboarding-Onboarding task are not shown when select Manage my team (11-50 employee or more)[/-][+]Onboarding - Onboarding task are not shown when select Manage my team (11-50 employee or more)[/+]MelvinBot commentedon May 22, 2026
Proposal
What is the root cause of that problem?
Two PRs merged on May 21 created a partially-deployed multi-step rollout that breaks onboarding for MANAGE_TEAM users:
PR [Payment due @ChavdaSachin] Onboarding: drop cohort gate now that server generates per-tier welcome #89469 removed the cohort gate so ALL
MANAGE_TEAMsignups (not just micro companies) setshouldUseFollowupsInsteadOfTasks = trueatReportUtils.ts:11622. Previously, 11-50+ employee signups got client-side optimistic tasks.PR [Payment due @hungvu193] [No QA] Add inbAdminsWel onboarding variant + send MANAGE_TEAM tasks to server without optimistic flash #91263 (Step 1 of a 4-step rollout) then removed all client-side optimistic task data for these users at
ReportUtils.ts:11960, relying on the server to create the visible welcome and tasks. The PR explicitly states: "No user-visible change until Step 2 deploys."Step 2 (a Web-Expensify server-side PR) has not deployed to staging yet, so the server doesn't create the tasks either — resulting in nothing appearing for the user.
Additionally,
shouldUseFollowupsInsteadOfTasksnow overrides theisPostingTasksInAdminsRoom()check (which was designed to keep+alias email users on the Concierge path), routing tasks to #admins instead of Concierge for all MANAGE_TEAM users regardless.What changes do you think we should make in order to solve the problem?
Since this is a coordinated multi-step deploy where Step 1 (client) deployed without Step 2 (server), the options are:
inbAdminsWelvariant from Auth Step 3) so optimistic tasks are only suppressed when the full pipeline is active.Option 1 (revert) is the safest immediate fix for the deploy blocker.
Investigation details
Key code path:
shouldUseFollowupsInsteadOfTasks = trueoptimisticData = []— no tasks appear on clientguidedSetupData, but the server needs the Step 2 PR to process themline 11624Possibly related issues:
Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.marcochavezf commentedon May 22, 2026
This is expected, since the welcome message is replacing the onboarding tasks. Also, we're moving the welcome messages to a new variant here