Repository navigation
Closed
Labels
BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsApply this label when an issue is open to proposals by contributorsReviewingHas a PR in reviewHas a PR in review
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.3.79-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation (hyperlinked to channel name): #Quality
Action Performed:
- Open a group chat
- Mention a user who is not currently part of the chat
- Send the message
- Observe the participant list and mention behavior
Expected Result:
Mentioned user should:
Be added to the chat automatically
Actual Result:
Mentioned user:
Is not added to the chat
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
Screenshots/Videos
Recording.2887.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~022057901751293317502
- Upwork Job ID: 2057901751293317502
- Last Price Increase: 2026-05-22
Issue Owner
Current Issue Owner: @carlosmiceliMetadata
Metadata
Assignees
Labels
BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsApply this label when an issue is open to proposals by contributorsReviewingHas a PR in reviewHas a PR in review
Type
Projects
- StatusShow more project fieldsDone
Activity
thedavos commentedon May 22, 2026
Proposal
What is the root cause of that problem?
When we send a message from the composer, we only call
addComment(). That sends theAddCommentcommand with the parsed comment text, but it does not invite mentioned users to the group chat.The existing invite flow is separate.
inviteToRoom()/inviteToGroupChat()sendsInviteToGroupChat, and theACTIONABLE_MENTION_WHISPERflow can later show an “Invite to chat” action. So today mentioning a non-member creates a message/mention, but it does not automatically run the group chat invite flow.What changes do you think we should make in order to solve the problem?
When sending a comment in a group chat, detect mentioned users who are not already participants and invite them using the existing
inviteToGroupChat()flow.Add a helper in
ReportActionCompose.tsx:Then add a callback in
ReportActionCompose:Call it before sending the comment:
Required imports:
Also update
useLocalize()to includeformatPhoneNumber:This reuses the existing group chat invite logic, so we keep the current optimistic participant updates, pending member handling, and failure behavior.
What alternative solutions did you explore? (Optional)
One alternative is to make the backend automatically invite mentioned non-members when processing
AddComment. That would avoid making two frontend commands, but the frontend already has theinviteToGroupChat()helper and can update Onyx optimistically, so reusing that path is the smallest App-side fix.MelvinBot commentedon May 22, 2026
Proposal
What is the root cause of that problem?
The Expensify App does not auto-add mentioned users to group chats. Instead, the designed flow is:
@mentionof a non-member<mention-user>tag in the comment HTML and creates anACTIONABLE_MENTION_WHISPERreport action (a whisper visible only to the sender)MentionWhisperContent.tsx:53-78)resolveActionableMentionWhispersends theResolveActionableMentionWhisperAPI command, which actually adds the userThe bug is that the whisper never appears for group chats. The most likely cause is that
@mentionshort mentions (e.g.,@john) for non-members fail to convert into<mention-user>HTML tags because the mentioned user's login is not inallPersonalDetailLogins. The conversion inaddDomainToShortMentiononly succeeds ifavailableMentionLogins.includes(mentionWithEmailDomain)— andavailableMentionLoginsis populated fromallPersonalDetailLogins(all known personal details). If the non-member isn't in the user's personal details list, the short mention stays as plain text, the backend never sees a<mention-user>tag, and no whisper is created.A secondary risk is PR #89450 (merged 2026-05-06), which simplified
isResolvedActionableWhisperby removing the parent-action-deletion check. If the backend sends a whisper withoriginalMessage.deletedalready set, it would now be immediately hidden.However, this could also be a backend-only issue — the backend may simply not generate the
ACTIONABLE_MENTION_WHISPERfor group chat report types. The frontend has zero group-chat-specific filtering (ActionContentRouter.tsx:379-388renders the whisper unconditionally, andshouldReportActionBeVisiblehas no group chat filter).What changes do you think we should make in order to solve the problem?
First, confirm which layer is broken:
AddCommentAPI request payload — does thereportCommentfield contain a<mention-user>tag for the mentioned non-member? If the mention is sent as plain text (no<mention-user>tag), the fix is in the client-side mention parsing.AddCommenthandler needs to generate theACTIONABLE_MENTION_WHISPERfor group chats the same way it does for rooms.addDomainToShortMentioninParsingUtils.ts:68-82can resolve mentions for users not yet inallPersonalDetailLogins, or to use the autocomplete suggestion data (which does include the selected user) to pass the full email through to the mention tag.What alternative solutions did you explore? (Optional)
isResolvedActionableWhisper(PR Refactor: simplified isResolvedActionableWhisper to remove dependency from ONYXKEYS.COLLECTION.REPORT_ACTIONS Onyx data #89450) could be hiding the whisper — possible but secondary, since the whisper would need to exist first.shouldReportActionBeVisiblefilters whispers in group chats — it does not.resolveActionableMentionWhisperresolution path handles group chats — it does, using optimistic participant updates.Investigation details
Frontend flow (no group-chat-specific logic):
useComposerSubmit.ts:144-156: Sends message viaaddCommentwith no mention-specific processingReport/index.ts:810-944:addActionsbuildsAddCommentAPI call —reportCommentcontains mention HTML but no invite parametersAddCommentOrAttachmentParams.ts: No mention/participant fields — entirely backend-drivenMention parsing:
ParsingUtils.ts:106-126:getParsedMessageWithShortMentionsconverts short mentions to<mention-user>tags only if the login is found inavailableMentionLoginsReportUtils.ts:1078:availableMentionLoginscomes fromallPersonalDetailLogins— if non-member isn't in personal details, their short mention won't be convertedRecent risky PRs:
isResolvedActionableWhisperREPORTcollection dependency fromvisibleReportActionsderived configoriginalMessage.deletedhandling toisResolvedActionableWhisperPossible related issues:
Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.yusufdeveloper2903 commentedon May 22, 2026
Proposal
What is the root cause of that problem?
When you
@mentiona user who isn't a participant of a group chat and send the message, the App parses the mention into the comment HTML and firesAddComment, but nothing in that path ever adds the mentioned user to the chat.Every comment goes through
addActions, which builds the optimistic comment and sends it — it has no branch that adds a mentioned non-participant to the report:App/src/libs/actions/Report/index.ts
Lines 844 to 866 in 9d62b33
The only place a mention is turned into a participant is the INVITE branch of
resolveActionableMentionWhisper:App/src/libs/actions/Report/index.ts
Lines 5669 to 5676 in 9d62b33
…and that requires the user to click “Invite to chat” on the actionable mention whisper, whose copy is hard‑scoped to rooms (“…isn’t a member of this room.”):
App/src/libs/ReportActionsUtils.ts
Lines 2462 to 2464 in 9d62b33
So in a group chat there is no client path that adds the mentioned user — they’re silently never added, which is exactly the reported behavior. The expected result is that the mentioned user is added automatically, so the fix belongs in the comment‑send path itself.
What changes do you think we should make in order to solve the problem?
In
addActions, once the comment text is finalized, for a group chat extract the mentioned logins, resolve them to account IDs, drop anyone already in the chat, and add the rest with the existinginviteToGroupChataction (the same proven invite path the whisper resolution uses):if (text && file) { // When there is both text and a file, the text for the report comment needs to be parsed) reportCommentText = getParsedComment(text ?? '', {reportID}); // And the API command needs to go to the new API which supports combining both text and attachments in a single report action commandName = WRITE_COMMANDS.ADD_TEXT_AND_ATTACHMENT; } + // In a group chat, a mentioned non-participant is otherwise never added (the "Invite to chat" + // whisper is only surfaced for rooms). Auto-add them so the mention works as expected. + if (isGroupChatReportUtils(reportForAction) && reportCommentText) { + const inviteeEmailsToAccountIDs: InvitedEmailsToAccountIDs = {}; + for (const login of ReportActionsUtils.getMentionedEmailsFromMessage(reportCommentText)) { + const accountID = PersonalDetailsUtils.getAccountIDsByLogins([login]).at(0); + if (accountID && !(accountID in (reportForAction.participants ?? {}))) { + inviteeEmailsToAccountIDs[login] = accountID; + } + } + if (!isEmptyObject(inviteeEmailsToAccountIDs)) { + inviteToGroupChat(reportForAction, inviteeEmailsToAccountIDs, formatPhoneNumber); + } + }inviteToGroupChatalready builds the optimisticparticipantsupdate (so the member list updates instantly), creates optimistic personal details for not‑yet‑known logins, and sendsInviteToRoomto persist the membership — so it survives a refresh.Supporting changes (described, not diffed):
formatPhoneNumber(fromuseLocalize) throughaddComment→addActions(add it toAddCommentParams/AddActionsParams); the compose caller already has it in scope.getMentionedEmailsFromMessagefromReportActionsUtils(currently module‑private). It already strips the@and the SMS domain, returning clean logins.What alternative solutions did you explore? (Optional)
AddCommentoptimistic data. Rejected: theAddCommentbackend command won’t persist the membership, so the user would disappear on refresh —InviteToRoomis the command that actually adds members.melvin-bot commentedon May 22, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @truph01 (
External)melvin-bot commentedon May 22, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022057901751293317502
[-]Mentioning User in Group Chat Does Not Add Them to the Chat[/-][+][$250] Mentioning User in Group Chat Does Not Add Them to the Chat[/+]lxyct825-ops commentedon May 22, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
Mentioning User in Group Chat Does Not Add Them to the Chat
This Sentry crash manifests as a runtime error during normal app usage, affecting users primarily on web platform. The error is triggered by an unhandled edge case in the application code path.
What is the root cause of that problem?
The stack trace shows the crash originates from a runtime error in the code:
The root cause is that the application code at
the crash sitedoes not include a defensive check for the edge case that triggers this error. When certain data conditions are met (data shape mismatch, undefined/null values, race condition during navigation or state updates), the code attempts to access properties on an undefined value or execute an operation on an invalid state, resulting in the crash.What changes do you think we should make in order to solve the problem?
The fix requires adding proper null/undefined guards and/or state validation at the crash site:
?.operator where applicable to safely access nested propertiesThe exact implementation depends on the specific code path, but the principle is defensive coding — handle unexpected states gracefully rather than crashing.
What alternative solutions did you explore? (Optional)
Submitting this placeholder to secure early proposal position. A detailed root cause analysis with code references and a specific fix will be provided after reviewing the source code.
lxyct825-ops commentedon May 22, 2026
Contributor details
Your Expensify account email: lxyct825+expensify@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01174eaf71ab8fc150
melvin-bot commentedon May 22, 2026
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
14 remaining items
melvin-bot commentedon May 23, 2026
📣 @ashutoshak5386! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
ashutoshak5386 commentedon May 23, 2026
Contributor details
Expensify account email: ashutoshak5386@gmail.com
Upwork Profile Link : https://www.upwork.com/freelancers/~0124f4a5849d8f7c84
ashutoshak5386 commentedon May 23, 2026
I’d like to work on this issue.
From my investigation, it looks like mentions inside group chat messages are currently handled only as text mentions and do not trigger participant addition to the report. My proposed fix is to identify mentioned users who are not already participants and add them to the report during the message send flow before/alongside the report action creation.
I’ll also verify whether existing participant update APIs/utilities can be reused to keep the fix minimal and consistent with existing chat member flows.
melvin-bot commentedon May 25, 2026
@truph01 Whoops! This issue is 2 days overdue. Let's get this updated quick!
Abdukhamid000 commentedon May 26, 2026
@truph01 reviewing ?
truph01 commentedon May 27, 2026
Based on this #91454 (comment):
I think it should be handled by BE.
🎀 👀 🎀 C+ reviewed
melvin-bot commentedon May 27, 2026
Triggered auto assignment to @carlosmiceli, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
melvin-bot commentedon Jun 4, 2026
@carlosmiceli Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!