Skip to content

[Due for payment 2026-06-02] Device management - No period after Learn more link #91479

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.80-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #91323
Email or phone of affected tester (no customers): isjdosdjoijosdjosnj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: User Settings

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Account > Copilot.
    → There is a period after Learn more link.
  3. Go to Account > Security.
  4. Click Device management.

Expected Result:

There will be a period after Learn more link.

Actual Result:

There is no period after Learn more link.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Image
Bug7161013_1779491926146.3.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7161013

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 22, 2026
  2. applause-bot commented on May 22, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/51678879314b3b784ef6a7a98c15f053d63dc89a442ee13ce59005a3d6d95b48

  3. melvin-bot commented on May 22, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #91323

  4. melvin-bot commented on May 22, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 22, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on May 22, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    The Device Management page description string in en.ts:2294 ends with </a> but has no trailing period. The Copilot page avoids this because it renders the period as a separate JSX node after its <TextLink>, but the Device Management page uses RenderHTML with the translation string directly, so the period must be in the string itself.

    What changes do you think we should make in order to solve the problem?

    Add a period (.) after the closing </a> tag in the deviceManagementPage.description string in both en.ts:2294 and es.ts:2108.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  7. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on May 24, 2026
  8. mountiny commented on May 24, 2026

    @mountiny
    Contributor

    We dont have to block on this

  9. changed the title [-]Device management - No period after Learn more link[/-] [+][Due for payment 2026-06-02] Device management - No period after Learn more link[/+] on May 26, 2026
  10. melvin-bot commented on May 26, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on May 26, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.82-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-02. 🎊

  12. melvin-bot commented on May 26, 2026

    @melvin-bot

    @arosiclair The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions