You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-17] [Due for payment 2026-06-10] Victory Chart: Fix scaling behavior for aspect ratio, labels, and legends #91515
Coming from #90253, when the chart scale changes, two issues occur:
Aspect ratio not preserved: The chart does not scale properly — it should maintain the same aspect ratio when the scale changes.
Labels and legends not repositioned: Labels and legends are not re-drawn at updated coordinates. Their x/y positions should be multiplied by the scale factor to reflect the new scale correctly.
Expected Behavior
On scale change, the chart scales uniformly while preserving its aspect ratio.
On scale change, all labels and legends are re-drawn at new coordinates computed by multiplying the base coordinates by the scale factor.
changed the title [-][Due for payment 2026-06-10] Victory Chart: Fix scaling behavior for aspect ratio, labels, and legends[/-][+][Due for payment 2026-06-17] [Due for payment 2026-06-10] Victory Chart: Fix scaling behavior for aspect ratio, labels, and legends[/+]on Jun 10, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.1-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Hi @mallenexpensify@luacmartins , may I request an increase in the bounty for this issue? It requires two separate PRs to fully complete, and we also ran into some fairly challenging issues around chart scaling on native devices.
Activity
daledah commentedon May 24, 2026
Screen.Recording.2026-05-24.at.11.58.20.mov
@luacmartins is this the expected behavior?
luacmartins commentedon May 24, 2026
Yea, that looks correct. Please go ahead with the PR
situchan commentedon May 24, 2026
Please assign me for review
quinthar commentedon May 31, 2026
Why do we go to some kind of horizontal scrolling when it gets small -- can we keep shrinking it down, like any other image?
luacmartins commentedon Jun 2, 2026
@daledah PR is merged, but we still need to address these in a follow up:
daledah commentedon Jun 3, 2026
I'll create a follow up PR soon
18 remaining items
[-][Due for payment 2026-06-10] Victory Chart: Fix scaling behavior for aspect ratio, labels, and legends[/-][+][Due for payment 2026-06-17] [Due for payment 2026-06-10] Victory Chart: Fix scaling behavior for aspect ratio, labels, and legends[/+]melvin-bot commentedon Jun 10, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 10, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.1-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-17. 🎊
For reference, here are some details about the assignees on this issue:
daledah commentedon Jun 11, 2026
Hi @mallenexpensify @luacmartins , may I request an increase in the bounty for this issue? It requires two separate PRs to fully complete, and we also ran into some fairly challenging issues around chart scaling on native devices.
Proposed amount to increase the price to: 500
Multiple PRs - Link to all PRs
Main PR: #91540
Follow up PR: #92613
luacmartins commentedon Jun 11, 2026
Sure
mallenexpensify commentedon Jun 11, 2026
Payment Summary
Contributor: @daledah due $500 via NewDot
Contributor+: @situchan due $500 via NewDot
@situchan plz complete the BZ checklist and tag me in a post once you have. Thx (I'm unsure what we might need/want here)
situchan commentedon Jun 11, 2026
No need BZ checklist for now. I think we'll add comprehensive regression test after project is completed.
quinthar commentedon Jun 13, 2026
Approved $500 to @daledah
garrettmknight commentedon Jun 16, 2026
$500 approved for @situchan