Skip to content

[Due for payment 2026-06-17] [Due for payment 2026-06-10] Victory Chart: Fix scaling behavior for aspect ratio, labels, and legends #91515

Closed

Description

@luacmartins

Problem

Coming from #90253, when the chart scale changes, two issues occur:

  1. Aspect ratio not preserved: The chart does not scale properly — it should maintain the same aspect ratio when the scale changes.
  2. Labels and legends not repositioned: Labels and legends are not re-drawn at updated coordinates. Their x/y positions should be multiplied by the scale factor to reflect the new scale correctly.

Expected Behavior

  • On scale change, the chart scales uniformly while preserving its aspect ratio.
  • On scale change, all labels and legends are re-drawn at new coordinates computed by multiplying the base coordinates by the scale factor.
Issue OwnerCurrent Issue Owner: @situchan
Issue OwnerCurrent Issue Owner: @situchan

Activity

  1. self-assigned this
    on May 23, 2026
  2. daledah commented on May 24, 2026

    @daledah
    Contributor
    Screen.Recording.2026-05-24.at.11.58.20.mov

    @luacmartins is this the expected behavior?

  3. luacmartins commented on May 24, 2026

    @luacmartins
    ContributorAuthor

    Yea, that looks correct. Please go ahead with the PR

  4. situchan commented on May 24, 2026

    @situchan
    Contributor

    Please assign me for review

  5. quinthar commented on May 31, 2026

    @quinthar
    Contributor

    Why do we go to some kind of horizontal scrolling when it gets small -- can we keep shrinking it down, like any other image?

  6. luacmartins commented on Jun 2, 2026

    @luacmartins
    ContributorAuthor

    @daledah PR is merged, but we still need to address these in a follow up:

  7. daledah commented on Jun 3, 2026

    @daledah
    Contributor

    I'll create a follow up PR soon

  8. 18 remaining items

  9. changed the title [-][Due for payment 2026-06-10] Victory Chart: Fix scaling behavior for aspect ratio, labels, and legends[/-] [+][Due for payment 2026-06-17] [Due for payment 2026-06-10] Victory Chart: Fix scaling behavior for aspect ratio, labels, and legends[/+] on Jun 10, 2026
  10. melvin-bot commented on Jun 10, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Jun 10, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.1-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-17. 🎊

    For reference, here are some details about the assignees on this issue:

    • @situchan requires payment through NewDot Manual Requests
    • @daledah requires payment through NewDot Manual Requests
  12. daledah commented on Jun 11, 2026

    @daledah
    Contributor

    Hi @mallenexpensify @luacmartins , may I request an increase in the bounty for this issue? It requires two separate PRs to fully complete, and we also ran into some fairly challenging issues around chart scaling on native devices.

    Proposed amount to increase the price to: 500

    Multiple PRs - Link to all PRs

    Main PR: #91540
    Follow up PR: #92613

  13. luacmartins commented on Jun 11, 2026

    @luacmartins
    ContributorAuthor

    Sure

  14. mallenexpensify commented on Jun 11, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @daledah due $500 via NewDot
    Contributor+: @situchan due $500 via NewDot

    @situchan plz complete the BZ checklist and tag me in a post once you have. Thx (I'm unsure what we might need/want here)

  15. situchan commented on Jun 11, 2026

    @situchan
    Contributor

    No need BZ checklist for now. I think we'll add comprehensive regression test after project is completed.

  16. quinthar commented on Jun 13, 2026

    @quinthar
    Contributor

    Approved $500 to @daledah

  17. garrettmknight commented on Jun 16, 2026

    @garrettmknight
    Contributor

    $500 approved for @situchan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions