Skip to content

[Due for payment 2026-06-04] Skip useTransactionInlineEdit on narrow transaction rows to reduce iOS scroll jank #91823

Closed

Description

@mountiny

Problem

useTransactionInlineEdit subscribes to 12+ Onyx keys per transaction row. On iOS narrow-layout transaction rows (TransactionItemRowNarrow), none of those subscriptions are consumed because the narrow layout has no inline-edit cells. Every row was still paying the full subscription overhead, which caused blank cells during fast scrolling on large reports.

Solution

The hook is now only invoked on wide-layout paths where inline editing is actually supported:

  1. MoneyRequestReportTransactionItem — split into a router component, a WithInlineEdit wrapper (wide path only), and a shared Body component. The narrow path skips the hook entirely; a local useRef(false) replaces wasEditingOnMouseDownRef so the press-handler shape stays identical.

  2. Search/SearchList/ListItem/TransactionListItem — the parent no longer calls useTransactionInlineEdit. TransactionListItemWide calls the hook internally and owns its own press/mousedown/hoverIn handlers. TransactionListItemNarrow gets a simplified press handler with no editing-dismissal logic.

PR

#91810

Issue OwnerCurrent Issue Owner: @aimane-chnaif

Activity

  1. changed the title [-]Skip useTransactionInlineEdit on narrow transaction rows to reduce iOS scroll jank[/-] [+][Due for payment 2026-06-04] Skip useTransactionInlineEdit on narrow transaction rows to reduce iOS scroll jank[/+] on May 28, 2026
  2. melvin-bot commented on May 28, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  3. melvin-bot commented on May 28, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.88-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-04. 🎊

    For reference, here are some details about the assignees on this issue:

  4. 2 remaining items

  5. melvin-bot commented on Jun 1, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  6. melvin-bot commented on Jun 3, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  7. melvin-bot commented on Jun 4, 2026

    @melvin-bot

    @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  8. mallenexpensify commented on Jun 5, 2026

    @mallenexpensify
    Contributor

    @aimane-chnaif can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~022063043491732489231

  9. aimane-chnaif commented on Jun 8, 2026

    @aimane-chnaif
    Contributor

    @mallenexpensify accepted offer

  10. mallenexpensify commented on Jun 8, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @aimane-chnaif paid $250 via Upwork

    @aimane-chnaif plz complete the BZ checklist and tag me in a post once you have. Thx

  11. aimane-chnaif commented on Jun 8, 2026

    @aimane-chnaif
    Contributor

    This is performance improvement so we can skip checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Task

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions