You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-04] [Due for payment 2026-06-03] Workspace - App crashes when opening Copy settings after disconnecting Intacct&connecting QBD #91825
Version Number: 9.3.83-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#90220 Email or phone of affected tester (no customers):applausetester+ssndjois2jd@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Log in with Expensifail account.
Create two Control workspaces - A and B.
Enable Accounting in Workspace A.
Go to staging.new.expensify.com
Go to Workspace A settings > Accounting.
Click Connect Sage Intacct.
Enter wrong credentials.
Click 3-dot menu > Disconnect > Disconnect.
Click Connect QuickBooks Desktop.
Click Done.
Click app back button to return to workspace list.
Click 3-dot menu on Workspace A > Copy settings.
Select Workspace B > Continue.
Expected Result:
App will not crash.
Actual Result:
App crashes after disconnecting Intacct, connecting QBD and opening Copy settings page.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
When disconnecting Intacct and connecting QBD, removePolicyConnection sets the old connection to null via Onyx.merge, which can leave policyTags in a state where individual tag group entries are null or have an undefined tags property. Object.values(null) throws a TypeError, crashing the app.
The original duplicate-workspace code at WorkspaceDuplicateSelectFeaturesForm.tsx:71 had partial defensive patterns (?.filter(...) ?? 0), but the copy-settings code dropped those guards.
Line 63 has the same class of bug — c.pendingAction will crash if any category entry in the Onyx record is null.
What changes do you think we should make in order to fix the problem?
The removePolicyConnection action at src/libs/actions/connections/index.ts:37-39 sets connections[connectionName]: null via Onyx.merge, which can propagate null entries into related Onyx collection keys during the disconnect/reconnect flow
The PolicyTagLists type (Record<string, OnyxValueWithOfflineFeedback<PolicyTagList>>) doesn't model null values at the TypeScript level, but Onyx merge operations can produce them at runtime
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-]Workspace - App crashes when opening Copy settings after disconnecting Intacct&connecting QBD[/-][+][Due for payment 2026-06-03] Workspace - App crashes when opening Copy settings after disconnecting Intacct&connecting QBD[/+]on May 27, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.83-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@yuwenmemon@fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.88-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
changed the title [-][Due for payment 2026-06-03] Workspace - App crashes when opening Copy settings after disconnecting Intacct&connecting QBD[/-][+][Due for payment 2026-06-04] [Due for payment 2026-06-03] Workspace - App crashes when opening Copy settings after disconnecting Intacct&connecting QBD[/+]on May 28, 2026
@yuwenmemon@fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
applause-bot commentedon May 27, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/e64421d5c40801eae9c95e8132678216992b516d47eb6a94fe1b0223d805f189
https://platform.applause.com/services/links/v1/external/2058d9a22956c9c48e2630a59d3a6a666860c070304b31b83e570c4eab26dee9
melvin-bot commentedon May 27, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #90220
melvin-bot commentedon May 27, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 27, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon May 27, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
The app crashes when opening Copy settings after disconnecting Sage Intacct and connecting QuickBooks Desktop on a workspace.
What is the root cause of that problem?
The crash is at
CopyPolicySettingsSelectFeaturesPage.tsx:65whereObject.values(tagGroup.tags)is called without null-safety:When disconnecting Intacct and connecting QBD,
removePolicyConnectionsets the old connection tonullviaOnyx.merge, which can leavepolicyTagsin a state where individual tag group entries arenullor have an undefinedtagsproperty.Object.values(null)throws aTypeError, crashing the app.The original duplicate-workspace code at
WorkspaceDuplicateSelectFeaturesForm.tsx:71had partial defensive patterns (?.filter(...) ?? 0), but the copy-settings code dropped those guards.Line 63 has the same class of bug —
c.pendingActionwill crash if any category entry in the Onyx record isnull.What changes do you think we should make in order to fix the problem?
Add null guards in
CopyPolicySettingsSelectFeaturesPage.tsx:Line 63 — guard against null category entries:
Lines 64-66 — guard against null
tagGroupand undefinedtagGroup.tags:Investigation details
removePolicyConnectionaction atsrc/libs/actions/connections/index.ts:37-39setsconnections[connectionName]: nullviaOnyx.merge, which can propagate null entries into related Onyx collection keys during the disconnect/reconnect flowPolicyTagListstype (Record<string, OnyxValueWithOfflineFeedback<PolicyTagList>>) doesn't model null values at the TypeScript level, but Onyx merge operations can produce them at runtimeNext Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.[-]Workspace - App crashes when opening Copy settings after disconnecting Intacct&connecting QBD[/-][+][Due for payment 2026-06-03] Workspace - App crashes when opening Copy settings after disconnecting Intacct&connecting QBD[/+]melvin-bot commentedon May 27, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.83-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-03. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 27, 2026
@yuwenmemon @fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon May 28, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.88-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-04. 🎊
For reference, here are some details about the assignees on this issue:
[-][Due for payment 2026-06-03] Workspace - App crashes when opening Copy settings after disconnecting Intacct&connecting QBD[/-][+][Due for payment 2026-06-04] [Due for payment 2026-06-03] Workspace - App crashes when opening Copy settings after disconnecting Intacct&connecting QBD[/+]melvin-bot commentedon May 28, 2026
@yuwenmemon @fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
fedirjh commentedon May 28, 2026
Should be fixed in #91241
melvin-bot commentedon Jun 1, 2026
@fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Jun 3, 2026
@fedirjh Huh... This is 4 days overdue. Who can take care of this?
fedirjh commentedon Jun 5, 2026
This was fixed:
CleanShot.2026-06-05.at.17.21.53.mp4