Skip to content

[Due for payment 2026-06-04] [Due for payment 2026-06-03] Workspace - Accounting row is shown when QBD connection fails #91827

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.83-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #90220
Email or phone of affected tester (no customers): applausetester+ssndjois2jd@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Log in with Expensifail account.
  • Create two Control workspaces - A and B.
  • Enable Accounting in Workspace A.
  1. Go to staging.new.expensify.com
  2. Go to Workspace A settings > Accounting.
  3. Click Connect QuickBooks Desktop.
  4. Click Done.
  5. Click app back button to return to workspace list.
  6. Click 3-dot menu on Workspace A > Copy settings.
  7. Select Workspace B > Continue.

Expected Result:

Accounting row will be hidden when QBD connection fails.

Actual Result:

Accounting row is shwon when QBD connection fails.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7164142_1779874091500.9.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7164142

Issue OwnerCurrent Issue Owner: @fedirjh

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 27, 2026
  2. applause-bot commented on May 27, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/349e9f46843930936b10b8f71a30d39e80ee8785bbea64edb8ba1932109bb905

  3. melvin-bot commented on May 27, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #90220

  4. melvin-bot commented on May 27, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 27, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on May 27, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    The Copy Policy Settings feature list decides whether to show the "Accounting" row by checking connectedIntegrationCount > 0 (CopyPolicySettingsUtils.ts:205). That count comes from getAllValidConnectedIntegration(), which only excludes connections where isAuthenticationError is true. A QBD connection that failed but did not set lastSync.isAuthenticationError = true (e.g. lastSync is empty or isConnected is false) still passes the filter and is counted as valid.

    The same gap exists in getAccountingConnectionIdentity(), which also skips connections only on isAuthenticationError.

    What changes do you think we should make in order to solve the problem?

    getAllValidConnectedIntegration() in utils.ts:75-79 should additionally exclude connections that are unverified by also checking isConnectionUnverified(). The filter should become:

    (integration) => !!policy?.connections?.[integration]
        && !isAuthenticationError(policy, integration)
        && !isConnectionUnverified(policy, integration)
    

    The same fix should be applied to getAccountingConnectionIdentity() in CopyPolicySettingsUtils.ts:113 — add || isConnectionUnverified(policy, connectionName) to the skip condition.

    This ensures that any broken/unverified connection (empty lastSync, isConnected === false, or unverified NetSuite/Certinia) is excluded from both the feature visibility check and the compatibility check.

    What alternative solutions did you explore?

    An alternative would be to check policy.areConnectionsEnabled instead of counting valid connections, mirroring what the main workspace settings page does. However, that would show the Accounting row even when there's no connection data to copy, which isn't desirable for the copy-settings context. The isConnectionUnverified approach is more precise — it reuses existing infrastructure that already handles the various failure modes per connection type.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  7. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on May 27, 2026
  8. changed the title [-]Workspace - Accounting row is shown when QBD connection fails[/-] [+][Due for payment 2026-06-03] Workspace - Accounting row is shown when QBD connection fails[/+] on May 27, 2026
  9. melvin-bot commented on May 27, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.83-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-03. 🎊

    For reference, here are some details about the assignees on this issue:

    • @fedirjh does not require payment (Contractor)
  10. melvin-bot commented on May 27, 2026

    @melvin-bot

    @yuwenmemon @fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  11. changed the title [-][Due for payment 2026-06-03] Workspace - Accounting row is shown when QBD connection fails[/-] [+][Due for payment 2026-06-04] [Due for payment 2026-06-03] Workspace - Accounting row is shown when QBD connection fails[/+] on May 28, 2026
  12. melvin-bot commented on May 28, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.88-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-04. 🎊

    For reference, here are some details about the assignees on this issue:

    • @fedirjh does not require payment (Contractor)
  13. melvin-bot commented on May 28, 2026

    @melvin-bot

    @yuwenmemon @fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. fedirjh commented on May 28, 2026

    @fedirjh
    Contributor

    Should be addressed in #91241

  15. melvin-bot commented on Jun 1, 2026

    @melvin-bot

    @fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  16. melvin-bot commented on Jun 3, 2026

    @melvin-bot

    @fedirjh Huh... This is 4 days overdue. Who can take care of this?

  17. fedirjh commented on Jun 5, 2026

    @fedirjh
    Contributor

    This was fixed

    CleanShot.2026-06-05.at.17.14.27.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions