You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-04] [Due for payment 2026-06-03] Workspace - Accounting row is shown when QBD connection fails #91827
Version Number: 9.3.83-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#90220 Email or phone of affected tester (no customers):applausetester+ssndjois2jd@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Log in with Expensifail account.
Create two Control workspaces - A and B.
Enable Accounting in Workspace A.
Go to staging.new.expensify.com
Go to Workspace A settings > Accounting.
Click Connect QuickBooks Desktop.
Click Done.
Click app back button to return to workspace list.
Click 3-dot menu on Workspace A > Copy settings.
Select Workspace B > Continue.
Expected Result:
Accounting row will be hidden when QBD connection fails.
Actual Result:
Accounting row is shwon when QBD connection fails.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The Copy Policy Settings feature list decides whether to show the "Accounting" row by checking connectedIntegrationCount > 0 (CopyPolicySettingsUtils.ts:205). That count comes from getAllValidConnectedIntegration(), which only excludes connections where isAuthenticationError is true. A QBD connection that failed but did not set lastSync.isAuthenticationError = true (e.g. lastSync is empty or isConnected is false) still passes the filter and is counted as valid.
What changes do you think we should make in order to solve the problem?
getAllValidConnectedIntegration() in utils.ts:75-79 should additionally exclude connections that are unverified by also checking isConnectionUnverified(). The filter should become:
The same fix should be applied to getAccountingConnectionIdentity() in CopyPolicySettingsUtils.ts:113 — add || isConnectionUnverified(policy, connectionName) to the skip condition.
This ensures that any broken/unverified connection (empty lastSync, isConnected === false, or unverified NetSuite/Certinia) is excluded from both the feature visibility check and the compatibility check.
What alternative solutions did you explore?
An alternative would be to check policy.areConnectionsEnabled instead of counting valid connections, mirroring what the main workspace settings page does. However, that would show the Accounting row even when there's no connection data to copy, which isn't desirable for the copy-settings context. The isConnectionUnverified approach is more precise — it reuses existing infrastructure that already handles the various failure modes per connection type.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-]Workspace - Accounting row is shown when QBD connection fails[/-][+][Due for payment 2026-06-03] Workspace - Accounting row is shown when QBD connection fails[/+]on May 27, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.83-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@yuwenmemon@fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2026-06-03] Workspace - Accounting row is shown when QBD connection fails[/-][+][Due for payment 2026-06-04] [Due for payment 2026-06-03] Workspace - Accounting row is shown when QBD connection fails[/+]on May 28, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.88-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@yuwenmemon@fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
applause-bot commentedon May 27, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/349e9f46843930936b10b8f71a30d39e80ee8785bbea64edb8ba1932109bb905
melvin-bot commentedon May 27, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #90220
melvin-bot commentedon May 27, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 27, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon May 27, 2026
Proposal
What is the root cause of that problem?
The Copy Policy Settings feature list decides whether to show the "Accounting" row by checking
connectedIntegrationCount > 0(CopyPolicySettingsUtils.ts:205). That count comes fromgetAllValidConnectedIntegration(), which only excludes connections whereisAuthenticationErroristrue. A QBD connection that failed but did not setlastSync.isAuthenticationError = true(e.g.lastSyncis empty orisConnectedisfalse) still passes the filter and is counted as valid.The same gap exists in
getAccountingConnectionIdentity(), which also skips connections only onisAuthenticationError.What changes do you think we should make in order to solve the problem?
getAllValidConnectedIntegration()inutils.ts:75-79should additionally exclude connections that are unverified by also checkingisConnectionUnverified(). The filter should become:The same fix should be applied to
getAccountingConnectionIdentity()inCopyPolicySettingsUtils.ts:113— add|| isConnectionUnverified(policy, connectionName)to the skip condition.This ensures that any broken/unverified connection (empty
lastSync,isConnected === false, or unverified NetSuite/Certinia) is excluded from both the feature visibility check and the compatibility check.What alternative solutions did you explore?
An alternative would be to check
policy.areConnectionsEnabledinstead of counting valid connections, mirroring what the main workspace settings page does. However, that would show the Accounting row even when there's no connection data to copy, which isn't desirable for the copy-settings context. TheisConnectionUnverifiedapproach is more precise — it reuses existing infrastructure that already handles the various failure modes per connection type.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.[-]Workspace - Accounting row is shown when QBD connection fails[/-][+][Due for payment 2026-06-03] Workspace - Accounting row is shown when QBD connection fails[/+]melvin-bot commentedon May 27, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.83-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-03. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 27, 2026
@yuwenmemon @fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][Due for payment 2026-06-03] Workspace - Accounting row is shown when QBD connection fails[/-][+][Due for payment 2026-06-04] [Due for payment 2026-06-03] Workspace - Accounting row is shown when QBD connection fails[/+]melvin-bot commentedon May 28, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.88-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-04. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 28, 2026
@yuwenmemon @fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
fedirjh commentedon May 28, 2026
Should be addressed in #91241
melvin-bot commentedon Jun 1, 2026
@fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Jun 3, 2026
@fedirjh Huh... This is 4 days overdue. Who can take care of this?
fedirjh commentedon Jun 5, 2026
This was fixed
CleanShot.2026-06-05.at.17.14.27.mp4