Skip to content

[Due for payment 2026-06-17] Workspaces - Members row shows 2 members when there is only 1 member on Copy settings page #91833

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.83-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #90220
Email or phone of affected tester (no customers): applausetester+sdjsd90s@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Log in with Expensifail account.
  • Create two Control workspaces - A and B.
  • Both workspaces have only 1 member which is workspace owner.
  1. Go to staging.new.expensify.com
  2. Click 3-dot menu on Workspace A > Copy settings.

Expected Result:

Members row will be hidden when there is only 1 member (yourself).

Actual Result:

Members row shows 2 members when there is only 1 member.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7164147_1779874590682.10.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7164147

Issue OwnerCurrent Issue Owner: @truph01

Activity

  1. applause-bot commented on May 27, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/503f3f5605bc7c524d1af27be689e48d4945224c3c948931b71507a1a8412b8a

  2. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 27, 2026
  3. melvin-bot commented on May 27, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #90220

  4. melvin-bot commented on May 27, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 27, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on May 27, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    The member count on the Copy Settings page is calculated using getMemberAccountIDsForWorkspace() at CopyPolicySettingsSelectFeaturesPage.tsx:62, which returns all entries in employeeList — including Expensify guides/account managers that the server automatically assigns to workspaces.

    The regular Workspace Members page filters these out via isExpensifyTeam() checks (WorkspaceMembersPage.tsx:433-439), so users see 1 member there. But the Copy Settings page has no such filtering, so the hidden guide inflates the count to 2.

    This also causes the Members row to appear when it shouldn't — CopyPolicySettingsUtils.ts:201 gates visibility on memberCount > 1, which evaluates to true because of the extra guide entry.

    What changes do you think we should make in order to solve the problem?

    Filter out Expensify team members when computing memberCount in CopyPolicySettingsSelectFeaturesPage.tsx:62. Before counting, exclude entries whose login satisfies isExpensifyTeam() (from src/libs/PolicyUtils.ts), consistent with how WorkspaceMembersPage handles this.

    The same fix should be applied to the Duplicate Workspace feature at WorkspaceDuplicateSelectFeaturesForm.tsx:41-42 which has the identical unfiltered count.

    What alternative solutions did you explore? (Optional)

    Adding a filterExpensifyTeam parameter to getMemberAccountIDsForWorkspace() was considered, but filtering at the call site is simpler and more consistent with how WorkspaceMembersPage handles it.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  7. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on May 27, 2026
  8. 18 remaining items

  9. melvin-bot commented on Jun 5, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  10. melvin-bot commented on Jun 5, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @fedirjh does not require payment (Contractor)
    • Reviewer: @truph01 owed $250 via NewDot

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  11. fedirjh commented on Jun 5, 2026

    @fedirjh
    Contributor

    This is not ready for payment yet, it's being fixed in #92777

  12. changed the title [-][Due for payment 2026-06-04] [Due for payment 2026-06-03] Workspaces - Members row shows 2 members when there is only 1 member on Copy settings page[/-] [+]Workspaces - Members row shows 2 members when there is only 1 member on Copy settings page[/+] on Jun 6, 2026
  13. added a commit that references this issue on Jun 7, 2026
    2db53f7
  14. changed the title [-]Workspaces - Members row shows 2 members when there is only 1 member on Copy settings page[/-] [+][Due for payment 2026-06-17] Workspaces - Members row shows 2 members when there is only 1 member on Copy settings page[/+] on Jun 10, 2026
  15. melvin-bot commented on Jun 10, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Jun 10, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.1-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-17. 🎊

    For reference, here are some details about the assignees on this issue:

    • @fedirjh does not require payment (Contractor)
    • @truph01 requires payment through NewDot Manual Requests
  17. melvin-bot commented on Jun 10, 2026

    @melvin-bot

    @truph01 @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions