You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-17] Workspaces - Members row shows 2 members when there is only 1 member on Copy settings page #91833
Version Number: 9.3.83-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#90220 Email or phone of affected tester (no customers):applausetester+sdjsd90s@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Log in with Expensifail account.
Create two Control workspaces - A and B.
Both workspaces have only 1 member which is workspace owner.
Go to staging.new.expensify.com
Click 3-dot menu on Workspace A > Copy settings.
Expected Result:
Members row will be hidden when there is only 1 member (yourself).
Actual Result:
Members row shows 2 members when there is only 1 member.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The member count on the Copy Settings page is calculated using getMemberAccountIDsForWorkspace() at CopyPolicySettingsSelectFeaturesPage.tsx:62, which returns all entries in employeeList — including Expensify guides/account managers that the server automatically assigns to workspaces.
The regular Workspace Members page filters these out via isExpensifyTeam() checks (WorkspaceMembersPage.tsx:433-439), so users see 1 member there. But the Copy Settings page has no such filtering, so the hidden guide inflates the count to 2.
This also causes the Members row to appear when it shouldn't — CopyPolicySettingsUtils.ts:201 gates visibility on memberCount > 1, which evaluates to true because of the extra guide entry.
What changes do you think we should make in order to solve the problem?
Filter out Expensify team members when computing memberCount in CopyPolicySettingsSelectFeaturesPage.tsx:62. Before counting, exclude entries whose login satisfies isExpensifyTeam() (from src/libs/PolicyUtils.ts), consistent with how WorkspaceMembersPage handles this.
What alternative solutions did you explore? (Optional)
Adding a filterExpensifyTeam parameter to getMemberAccountIDsForWorkspace() was considered, but filtering at the call site is simpler and more consistent with how WorkspaceMembersPage handles it.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-][Due for payment 2026-06-04] [Due for payment 2026-06-03] Workspaces - Members row shows 2 members when there is only 1 member on Copy settings page[/-][+]Workspaces - Members row shows 2 members when there is only 1 member on Copy settings page[/+]on Jun 6, 2026
changed the title [-]Workspaces - Members row shows 2 members when there is only 1 member on Copy settings page[/-][+][Due for payment 2026-06-17] Workspaces - Members row shows 2 members when there is only 1 member on Copy settings page[/+]on Jun 10, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.1-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@truph01@mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon May 27, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/503f3f5605bc7c524d1af27be689e48d4945224c3c948931b71507a1a8412b8a
melvin-bot commentedon May 27, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #90220
melvin-bot commentedon May 27, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 27, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon May 27, 2026
Proposal
What is the root cause of that problem?
The member count on the Copy Settings page is calculated using
getMemberAccountIDsForWorkspace()atCopyPolicySettingsSelectFeaturesPage.tsx:62, which returns all entries inemployeeList— including Expensify guides/account managers that the server automatically assigns to workspaces.The regular Workspace Members page filters these out via
isExpensifyTeam()checks (WorkspaceMembersPage.tsx:433-439), so users see 1 member there. But the Copy Settings page has no such filtering, so the hidden guide inflates the count to 2.This also causes the Members row to appear when it shouldn't —
CopyPolicySettingsUtils.ts:201gates visibility onmemberCount > 1, which evaluates totruebecause of the extra guide entry.What changes do you think we should make in order to solve the problem?
Filter out Expensify team members when computing
memberCountinCopyPolicySettingsSelectFeaturesPage.tsx:62. Before counting, exclude entries whose login satisfiesisExpensifyTeam()(fromsrc/libs/PolicyUtils.ts), consistent with howWorkspaceMembersPagehandles this.The same fix should be applied to the Duplicate Workspace feature at
WorkspaceDuplicateSelectFeaturesForm.tsx:41-42which has the identical unfiltered count.What alternative solutions did you explore? (Optional)
Adding a
filterExpensifyTeamparameter togetMemberAccountIDsForWorkspace()was considered, but filtering at the call site is simpler and more consistent with howWorkspaceMembersPagehandles it.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.18 remaining items
melvin-bot commentedon Jun 5, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Jun 5, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
fedirjh commentedon Jun 5, 2026
This is not ready for payment yet, it's being fixed in #92777
[-][Due for payment 2026-06-04] [Due for payment 2026-06-03] Workspaces - Members row shows 2 members when there is only 1 member on Copy settings page[/-][+]Workspaces - Members row shows 2 members when there is only 1 member on Copy settings page[/+]fix: filter Expensify team members from member count in Duplicate Wor…
[-]Workspaces - Members row shows 2 members when there is only 1 member on Copy settings page[/-][+][Due for payment 2026-06-17] Workspaces - Members row shows 2 members when there is only 1 member on Copy settings page[/+]melvin-bot commentedon Jun 10, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 10, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.1-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-17. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 10, 2026
@truph01 @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]