Skip to content

[Due for payment 2026-06-08] [Due for payment 2026-06-04] Rules- X button is below Try it out button, Try it out button is not full width after rotation #91881

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.84-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #91251
Email or phone of affected tester (no customers): applausetester+khcategory19@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Samsung Galaxy S25 FE / Android 16
App Component: Workspace Settings

Action Performed:

Precondition:

  • Log in with Expensifail account.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings.
  3. Go to Rules (enable it in More features).
  4. Rotate the device to landscape.
  5. Rotate the device to portrait.

Expected Result:

In landscape mode, X button will not appear below Try it out button.
After rotating to portrait mode, Try it out button will be full width.

Actual Result:

In landscape mode, X button appears below Try it out button.
After rotating to portrait mode, Try it out button is not full width.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7164529_1779905631598.Screen_Recording_20260528_021054_Expensify.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7164529

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 27, 2026
  2. applause-bot commented on May 27, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/3d0a798f720a285e39d991f22363386dc1a095eaa9344b8b7b02bdb330570450

  3. melvin-bot commented on May 27, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #91251

  4. melvin-bot commented on May 27, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. MelvinBot commented on May 27, 2026

    @MelvinBot
    Contributor

    Proposal

    Problem: In landscape mode on mobile, the "Try it out" CTA button has flexBasis: '100%' which forces it onto its own row within the flexWrap: 'wrap' container in BillingBanner. The X close button then wraps to a row below it. After rotating back to portrait, the percentage-based flex layout may not recalculate correctly, leaving the button at a non-full width.

    Solution:
    In AgentPromotionalBanner.tsx:70, the rightComponent memo decides between a full-width CTA and a compact CTA based solely on shouldUseNarrowLayout. On native, shouldUseNarrowLayout is always true, so the full-width variant (with flexBasis: '100%') is always rendered regardless of orientation.

    The fix is to also check isInLandscapeMode, matching the pattern already used by BillingBanner.tsx:129:

    1. Destructure isInLandscapeMode from useResponsiveLayout() at line 42
    2. Change line 70 from if (shouldUseNarrowLayout) to if (shouldUseNarrowLayout && !isInLandscapeMode)
    3. Add isInLandscapeMode to the useMemo dependency array at line 92

    In landscape, this renders the compact small button variant that can sit alongside the X icon on the same row rather than forcing a wrap.

    Supporting evidence
    • BillingBanner uses a flexRow + flexWrap container (line 118) and conditionally reorders children based on shouldUseNarrowLayout && !isInLandscapeMode (line 129)
    • In landscape, the CTA renders before the X icon, but since it still has flexBasis: '100%' from AgentPromotionalBanner, it takes the entire row, pushing X below
    • shouldUseNarrowLayout is hardcoded to true on native (useResponsiveLayout/index.native.ts), so the banner never uses the compact variant on mobile

    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  6. github-actions commented on May 27, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. yuwenmemon commented on May 27, 2026

    @yuwenmemon
    Contributor

    @MelvinBot Implement this

  8. MelvinBot commented on May 27, 2026

    @MelvinBot
    Contributor

    🤖 Draft PR created: #91905
    Please mark it as "Ready for review" when it is ready for review.

  9. 4 remaining items

  10. added and removed on May 28, 2026
  11. NicolasBonet commented on May 28, 2026

    @NicolasBonet
    Contributor

    Xiaomi Redmi Note 10 / Android 12 App 9.3.87-0 No Try it out banner in Rules

    That has to be fully unrelated with this issue, probably worth opening a new one as the PRs involved with promotional banners remove nothing from the code.

  12. IuliiaHerets commented on May 28, 2026

    @IuliiaHerets

    Original tester confirmed that issue was fixed on build 88-0

    Image
  13. changed the title [-]Rules- X button is below Try it out button, Try it out button is not full width after rotation[/-] [+][Due for payment 2026-06-04] Rules- X button is below Try it out button, Try it out button is not full width after rotation[/+] on May 28, 2026
  14. melvin-bot commented on May 28, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on May 28, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.88-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-04. 🎊

  16. melvin-bot commented on May 28, 2026

    @melvin-bot

    @yuwenmemon The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  17. yuwenmemon commented on May 28, 2026

    @yuwenmemon
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR:
      Link to the comment on the Issue:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    Do we agree 👍 or 👎

  18. changed the title [-][Due for payment 2026-06-04] Rules- X button is below Try it out button, Try it out button is not full width after rotation[/-] [+][Due for payment 2026-06-08] [Due for payment 2026-06-04] Rules- X button is below Try it out button, Try it out button is not full width after rotation[/+] on Jun 1, 2026
  19. melvin-bot commented on Jun 1, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.89-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-08. 🎊

  20. melvin-bot commented on Jun 1, 2026

    @melvin-bot

    @yuwenmemon The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions