You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-08] [Due for payment 2026-06-04] Rules- X button is below Try it out button, Try it out button is not full width after rotation #91881
Version Number: 9.3.84-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#91251 Email or phone of affected tester (no customers):applausetester+khcategory19@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Samsung Galaxy S25 FE / Android 16 App Component: Workspace Settings
Action Performed:
Precondition:
Log in with Expensifail account.
Go to staging.new.expensify.com
Go to workspace settings.
Go to Rules (enable it in More features).
Rotate the device to landscape.
Rotate the device to portrait.
Expected Result:
In landscape mode, X button will not appear below Try it out button.
After rotating to portrait mode, Try it out button will be full width.
Actual Result:
In landscape mode, X button appears below Try it out button.
After rotating to portrait mode, Try it out button is not full width.
Problem: In landscape mode on mobile, the "Try it out" CTA button has flexBasis: '100%' which forces it onto its own row within the flexWrap: 'wrap' container in BillingBanner. The X close button then wraps to a row below it. After rotating back to portrait, the percentage-based flex layout may not recalculate correctly, leaving the button at a non-full width.
Solution:
In AgentPromotionalBanner.tsx:70, the rightComponent memo decides between a full-width CTA and a compact CTA based solely on shouldUseNarrowLayout. On native, shouldUseNarrowLayout is always true, so the full-width variant (with flexBasis: '100%') is always rendered regardless of orientation.
The fix is to also check isInLandscapeMode, matching the pattern already used by BillingBanner.tsx:129:
Destructure isInLandscapeMode from useResponsiveLayout() at line 42
Change line 70 from if (shouldUseNarrowLayout) to if (shouldUseNarrowLayout && !isInLandscapeMode)
Add isInLandscapeMode to the useMemo dependency array at line 92
In landscape, this renders the compact small button variant that can sit alongside the X icon on the same row rather than forcing a wrap.
Supporting evidence
BillingBanner uses a flexRow + flexWrap container (line 118) and conditionally reorders children based on shouldUseNarrowLayout && !isInLandscapeMode (line 129)
In landscape, the CTA renders before the X icon, but since it still has flexBasis: '100%' from AgentPromotionalBanner, it takes the entire row, pushing X below
shouldUseNarrowLayout is hardcoded to true on native (useResponsiveLayout/index.native.ts), so the banner never uses the compact variant on mobile
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Xiaomi Redmi Note 10 / Android 12 App 9.3.87-0 No Try it out banner in Rules
That has to be fully unrelated with this issue, probably worth opening a new one as the PRs involved with promotional banners remove nothing from the code.
changed the title [-]Rules- X button is below Try it out button, Try it out button is not full width after rotation[/-][+][Due for payment 2026-06-04] Rules- X button is below Try it out button, Try it out button is not full width after rotation[/+]on May 28, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.88-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@yuwenmemon The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR:
Link to the comment on the Issue:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
changed the title [-][Due for payment 2026-06-04] Rules- X button is below Try it out button, Try it out button is not full width after rotation[/-][+][Due for payment 2026-06-08] [Due for payment 2026-06-04] Rules- X button is below Try it out button, Try it out button is not full width after rotation[/+]on Jun 1, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.89-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@yuwenmemon The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
applause-bot commentedon May 27, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/3d0a798f720a285e39d991f22363386dc1a095eaa9344b8b7b02bdb330570450
melvin-bot commentedon May 27, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #91251
melvin-bot commentedon May 27, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon May 27, 2026
Proposal
Problem: In landscape mode on mobile, the "Try it out" CTA button has
flexBasis: '100%'which forces it onto its own row within theflexWrap: 'wrap'container inBillingBanner. TheXclose button then wraps to a row below it. After rotating back to portrait, the percentage-based flex layout may not recalculate correctly, leaving the button at a non-full width.Solution:
In
AgentPromotionalBanner.tsx:70, therightComponentmemo decides between a full-width CTA and a compact CTA based solely onshouldUseNarrowLayout. On native,shouldUseNarrowLayoutis alwaystrue, so the full-width variant (withflexBasis: '100%') is always rendered regardless of orientation.The fix is to also check
isInLandscapeMode, matching the pattern already used byBillingBanner.tsx:129:isInLandscapeModefromuseResponsiveLayout()at line 42if (shouldUseNarrowLayout)toif (shouldUseNarrowLayout && !isInLandscapeMode)isInLandscapeModeto theuseMemodependency array at line 92In landscape, this renders the compact
smallbutton variant that can sit alongside theXicon on the same row rather than forcing a wrap.Supporting evidence
BillingBanneruses aflexRow+flexWrapcontainer (line 118) and conditionally reorders children based onshouldUseNarrowLayout && !isInLandscapeMode(line 129)flexBasis: '100%'fromAgentPromotionalBanner, it takes the entire row, pushing X belowshouldUseNarrowLayoutis hardcoded totrueon native (useResponsiveLayout/index.native.ts), so the banner never uses the compact variant on mobileNext Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.github-actions commentedon May 27, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
yuwenmemon commentedon May 27, 2026
@MelvinBot Implement this
MelvinBot commentedon May 27, 2026
🤖 Draft PR created: #91905
Please mark it as "Ready for review" when it is ready for review.
4 remaining items
NicolasBonet commentedon May 28, 2026
That has to be fully unrelated with this issue, probably worth opening a new one as the PRs involved with promotional banners remove nothing from the code.
IuliiaHerets commentedon May 28, 2026
Original tester confirmed that issue was fixed on build 88-0
[-]Rules- X button is below Try it out button, Try it out button is not full width after rotation[/-][+][Due for payment 2026-06-04] Rules- X button is below Try it out button, Try it out button is not full width after rotation[/+]melvin-bot commentedon May 28, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 28, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.88-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-04. 🎊
melvin-bot commentedon May 28, 2026
@yuwenmemon The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
yuwenmemon commentedon May 28, 2026
BugZero Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR:
Link to the comment on the Issue:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
[-][Due for payment 2026-06-04] Rules- X button is below Try it out button, Try it out button is not full width after rotation[/-][+][Due for payment 2026-06-08] [Due for payment 2026-06-04] Rules- X button is below Try it out button, Try it out button is not full width after rotation[/+]melvin-bot commentedon Jun 1, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.89-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-08. 🎊
melvin-bot commentedon Jun 1, 2026
@yuwenmemon The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]