Skip to content

[Due for payment 2026-07-23] [$250] Expense - Received payment button is moved to the last section in More menu #91928

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.84-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #90097
Email or phone of affected tester (no customers): sjdnoisjosidjo@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Disable Approvals and Payments in Workflows settings.
  • Change Submission frequency to Instantly.
  • Invite a member to the workspace.
  • Perform the steps below as the invited member.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create an expense.
  4. Open the report.
  5. Click More menu.

Expected Result:

Received payment button will be at the first section.

Actual Result:

Received payment button is moved to the last section.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7165078_1779951791219.16.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7165078

Issue OwnerCurrent Issue Owner: @mallenexpensify
Upwork Automation - Do Not Edit

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 28, 2026
  2. applause-bot commented on May 28, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/e89f71f890ada01bf726762820a9c74bfe9931e57a15ef13dc78f53691864a8c

  3. melvin-bot commented on May 28, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #90097

  4. melvin-bot commented on May 28, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 28, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on May 28, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    PR #90097 introduced section-based ordering for the More menu via PopoverMenuSections.ts. The REPORT_MORE_MENU_SECTIONS array at line 8-26 includes REPORT_SECONDARY_ACTIONS.PAY in the first section but omits REPORT_SECONDARY_ACTIONS.RECEIVED_PAYMENT. These are distinct constants ('pay' vs 'receivedPayment'). When RECEIVED_PAYMENT is pushed as a menu item, it doesn't match any section entry, so sortAndSectionPopoverMenuItems assigns it UNRECOGNIZED_SECTION (Number.MAX_SAFE_INTEGER) at line 47, causing it to sort to the very end.

    What changes do you think we should make in order to solve the problem?

    Add REPORT_SECONDARY_ACTIONS.RECEIVED_PAYMENT to the first section of REPORT_MORE_MENU_SECTIONS in src/libs/PopoverMenuSections.ts, alongside PAY, so it gets sectionIndex: 0 and appears in the first section as expected.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  7. aswin-s commented on May 28, 2026

    @aswin-s
    Contributor

    The Received Payment action was not included in the original spec for issue #87964. The spec lists the first section of the Reports view as: Submit / Retract / Reject / Unapprove / Cancel Payment (all possible options)

    Received Payment is not mentioned in any of the four layout variants (Empty report, Reports with a single expense, Reports with multiple expenses, Expenses). Since PopoverMenuSections.ts only maps actions explicitly listed in the spec to their sections, RECEIVED_PAYMENT was never assigned — causing it to fall through to the unrecognized bucket and sort to the end.

    This is a gap in the original spec #87964, not a regression in the implementation. @Julesssss @rojiphil Your thoughts on this?

  8. Julesssss commented on May 28, 2026

    @Julesssss
    Contributor

    Agree, I shared the issues here to discuss how we should handle these additional cases.

  9. 22 remaining items

  10. melvin-bot commented on Jul 16, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.34-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-07-23. 🎊

    For reference, here are some details about the assignees on this issue:

    • @rojiphil requires payment through NewDot Manual Requests
  11. melvin-bot commented on Jul 16, 2026

    @melvin-bot

    @rojiphil The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  12. melvin-bot commented on Jul 21, 2026

    @melvin-bot

    @rojiphil Huh... This is 4 days overdue. Who can take care of this?

  13. melvin-bot commented on Jul 22, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  14. melvin-bot commented on Jul 22, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/2062098870789046470/hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  15. rojiphil commented on Jul 23, 2026

    @rojiphil
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not Required. The existing checklist is good enough to capture such issues.

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template

    Regression Test Proposal

    Precondition:

    Disable Approvals and Payments in Workflows settings.
    Change Submission frequency to Instantly.
    Invite a member to the workspace.

    Test:

    1. Go to staging.new.expensify.com
    2. Go to workspace chat.
    3. Create an expense.
    4. Open the report.
    5. Click More menu.
    6. Verify that the Received payment menu option is at the first section.

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-8f86-a0f5-349a-44ac0c386ce4
  16. mallenexpensify commented on Jul 27, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @rojiphil due $250 via NewDot

    ^ Test case created. Thx

  17. quinthar commented on Sep 2, 2026

    @quinthar
    Contributor

    Approved $250 to @rojiphil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions