You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-07-23] [$250] Expense - Received payment button is moved to the last section in More menu #91928
Version Number: 9.3.84-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#90097 Email or phone of affected tester (no customers):sjdnoisjosidjo@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Disable Approvals and Payments in Workflows settings.
Change Submission frequency to Instantly.
Invite a member to the workspace.
Perform the steps below as the invited member.
Go to staging.new.expensify.com
Go to workspace chat.
Create an expense.
Open the report.
Click More menu.
Expected Result:
Received payment button will be at the first section.
Actual Result:
Received payment button is moved to the last section.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
PR #90097 introduced section-based ordering for the More menu via PopoverMenuSections.ts. The REPORT_MORE_MENU_SECTIONS array at line 8-26 includes REPORT_SECONDARY_ACTIONS.PAY in the first section but omits REPORT_SECONDARY_ACTIONS.RECEIVED_PAYMENT. These are distinct constants ('pay' vs 'receivedPayment'). When RECEIVED_PAYMENT is pushed as a menu item, it doesn't match any section entry, so sortAndSectionPopoverMenuItems assigns it UNRECOGNIZED_SECTION (Number.MAX_SAFE_INTEGER) at line 47, causing it to sort to the very end.
What changes do you think we should make in order to solve the problem?
Add REPORT_SECONDARY_ACTIONS.RECEIVED_PAYMENT to the first section of REPORT_MORE_MENU_SECTIONS in src/libs/PopoverMenuSections.ts, alongside PAY, so it gets sectionIndex: 0 and appears in the first section as expected.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
The Received Payment action was not included in the original spec for issue #87964. The spec lists the first section of the Reports view as: Submit / Retract / Reject / Unapprove / Cancel Payment (all possible options)
Received Payment is not mentioned in any of the four layout variants (Empty report, Reports with a single expense, Reports with multiple expenses, Expenses). Since PopoverMenuSections.ts only maps actions explicitly listed in the spec to their sections, RECEIVED_PAYMENT was never assigned — causing it to fall through to the unrecognized bucket and sort to the end.
This is a gap in the original spec #87964, not a regression in the implementation. @Julesssss@rojiphil Your thoughts on this?
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.34-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@rojiphil The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required. The existing checklist is good enough to capture such issues.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
applause-bot commentedon May 28, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/e89f71f890ada01bf726762820a9c74bfe9931e57a15ef13dc78f53691864a8c
melvin-bot commentedon May 28, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #90097
melvin-bot commentedon May 28, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 28, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon May 28, 2026
Proposal
What is the root cause of that problem?
PR #90097 introduced section-based ordering for the More menu via
PopoverMenuSections.ts. TheREPORT_MORE_MENU_SECTIONSarray at line 8-26 includesREPORT_SECONDARY_ACTIONS.PAYin the first section but omitsREPORT_SECONDARY_ACTIONS.RECEIVED_PAYMENT. These are distinct constants ('pay'vs'receivedPayment'). WhenRECEIVED_PAYMENTis pushed as a menu item, it doesn't match any section entry, sosortAndSectionPopoverMenuItemsassigns itUNRECOGNIZED_SECTION(Number.MAX_SAFE_INTEGER) at line 47, causing it to sort to the very end.What changes do you think we should make in order to solve the problem?
Add
REPORT_SECONDARY_ACTIONS.RECEIVED_PAYMENTto the first section ofREPORT_MORE_MENU_SECTIONSinsrc/libs/PopoverMenuSections.ts, alongsidePAY, so it getssectionIndex: 0and appears in the first section as expected.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.aswin-s commentedon May 28, 2026
The Received Payment action was not included in the original spec for issue #87964. The spec lists the first section of the Reports view as: Submit / Retract / Reject / Unapprove / Cancel Payment (all possible options)
Received Payment is not mentioned in any of the four layout variants (Empty report, Reports with a single expense, Reports with multiple expenses, Expenses). Since PopoverMenuSections.ts only maps actions explicitly listed in the spec to their sections, RECEIVED_PAYMENT was never assigned — causing it to fall through to the unrecognized bucket and sort to the end.
This is a gap in the original spec #87964, not a regression in the implementation. @Julesssss @rojiphil Your thoughts on this?
Julesssss commentedon May 28, 2026
Agree, I shared the issues here to discuss how we should handle these additional cases.
22 remaining items
melvin-bot commentedon Jul 16, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.34-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-07-23. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 16, 2026
@rojiphil The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
melvin-bot commentedon Jul 21, 2026
@rojiphil Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon Jul 22, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Jul 22, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
rojiphil commentedon Jul 23, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required. The existing checklist is good enough to capture such issues.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/664869
Regression Test Proposal
Precondition:
Disable Approvals and Payments in Workflows settings.
Change Submission frequency to Instantly.
Invite a member to the workspace.
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-8f86-a0f5-349a-44ac0c386ce4mallenexpensify commentedon Jul 27, 2026
Payment Summary
Contributor+: @rojiphil due $250 via NewDot
^ Test case created. Thx
quinthar commentedon Sep 2, 2026
Approved $250 to @rojiphil