Skip to content

Extra text displayed with invoice subtitle #92094

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.3.89-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #90760
Email or phone of affected tester (no customers): theed79jhhvhj75@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Web, Android, IOS
App Component: Other

Action Performed:

  1. Go to staging.new.expensify.com.
  2. Log in with a new account without creating a workspace.
  3. Use the search input and search for type:invoice.
  4. Verify subtitle should be: "You need a workspace with Invoices enabled to send invoices." according to the PR

Expected Result:

subtitle should be "You need a workspace with Invoices enabled to send invoices."

Actual Result:

Extra text displayed with invoice subtitle

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7166449_1780066795387.2026-05-29_16-58-09.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7166449

Activity

  1. applause-bot commented on May 29, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/dbb51e9e6bcb2f7c512b40701bb3279f9a8ac93585b03415ea76957253be2d09

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 29, 2026
  3. melvin-bot commented on May 29, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #90760

  4. melvin-bot commented on May 29, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 29, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on May 29, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    PR #90760 added two new subtitle variants for the invoice empty state and a branch in EmptySearchView.tsx that picks between them based on hasSeenTour:

    • subtitleCannotSend → "You need a workspace with Invoices enabled to send invoices."
    • subtitleCannotSendWithTestDrive → "You need a workspace with Invoices enabled to send invoices. Take a test drive of Expensify to learn more."

    In the QA repro, the tester logs in with a new account without a workspace:

    • userCanSendInvoice → false (no invoice-enabled workspace)
    • hasSeenTour → false (new account)

    The selector at EmptySearchView.tsx:337-343 therefore falls into the second branch and renders subtitleCannotSendWithTestDrive, which appends " Take a test drive of Expensify to learn more." after the expected sentence. That trailing sentence is the "extra text" the QA tester flagged — the PR description promised only "You need a workspace with Invoices enabled to send invoices." regardless of tour state.

    What changes do you think we should make in order to solve the problem?

    When the user cannot send an invoice, always show the concise subtitle (subtitleCannotSend) — the existing "Take a test drive" button is already the affordance for the tour, so re-stating it inside the subtitle is redundant and is exactly the "extra text" the bug reports.

    Concretely, in src/pages/Search/EmptySearchView.tsx:

    This matches the QA expectation from the PR test plan and keeps the test-drive button visible for new users.

    What alternative solutions did you explore?

    Update the PR description and QA steps to acknowledge the WithTestDrive variant for users who have not seen the tour. This preserves the current implementation but doesn't fix the user-visible duplication between the subtitle copy and the test-drive button.

    Supporting evidence

    PR #90760 file changes:

    Repro state mapping:

    • New account, no workspace → canSendInvoice(allPolicies, login) returns false.
    • hasSeenTour is sourced from ONYXKEYS.NVP_ONBOARDING via hasSeenTourSelector and defaults to false for a brand-new account.
    • Both conditions together select subtitleCannotSendWithTestDrive.

    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/92094) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  7. ahmedGaber93 commented on May 29, 2026

    @ahmedGaber93
    Contributor

    @dangrous There was a mistake in the PR steps—the message is correct. We should close this.

  8. dylanexpensify commented on May 29, 2026

    @dylanexpensify
    Contributor

    @ahmedGaber93 so we're good to close?

  9. ahmedGaber93 commented on May 29, 2026

    @ahmedGaber93
    Contributor

    @dylanexpensify Yes, we’re good to close.

  10. dylanexpensify commented on May 29, 2026

    @dylanexpensify
    Contributor

    Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions