You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Version Number: v9.3.89-1 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#90760 Email or phone of affected tester (no customers):theed79jhhvhj75@gmail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Web, Android, IOS App Component: Other
Action Performed:
Go to staging.new.expensify.com.
Log in with a new account without creating a workspace.
Use the search input and search for type:invoice.
Verify subtitle should be: "You need a workspace with Invoices enabled to send invoices." according to the PR
Expected Result:
subtitle should be "You need a workspace with Invoices enabled to send invoices."
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
PR #90760 added two new subtitle variants for the invoice empty state and a branch in EmptySearchView.tsx that picks between them based on hasSeenTour:
subtitleCannotSend → "You need a workspace with Invoices enabled to send invoices."
subtitleCannotSendWithTestDrive → "You need a workspace with Invoices enabled to send invoices. Take a test drive of Expensify to learn more."
In the QA repro, the tester logs in with a new account without a workspace:
userCanSendInvoice → false (no invoice-enabled workspace)
hasSeenTour → false (new account)
The selector at EmptySearchView.tsx:337-343 therefore falls into the second branch and renders subtitleCannotSendWithTestDrive, which appends " Take a test drive of Expensify to learn more." after the expected sentence. That trailing sentence is the "extra text" the QA tester flagged — the PR description promised only "You need a workspace with Invoices enabled to send invoices." regardless of tour state.
What changes do you think we should make in order to solve the problem?
When the user cannot send an invoice, always show the concise subtitle (subtitleCannotSend) — the existing "Take a test drive" button is already the affordance for the tour, so re-stating it inside the subtitle is redundant and is exactly the "extra text" the bug reports.
This matches the QA expectation from the PR test plan and keeps the test-drive button visible for new users.
What alternative solutions did you explore?
Update the PR description and QA steps to acknowledge the WithTestDrive variant for users who have not seen the tour. This preserves the current implementation but doesn't fix the user-visible duplication between the subtitle copy and the test-drive button.
New account, no workspace → canSendInvoice(allPolicies, login) returns false.
hasSeenTour is sourced from ONYXKEYS.NVP_ONBOARDING via hasSeenTourSelector and defaults to false for a brand-new account.
Both conditions together select subtitleCannotSendWithTestDrive.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/92094) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
Activity
applause-bot commentedon May 29, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/dbb51e9e6bcb2f7c512b40701bb3279f9a8ac93585b03415ea76957253be2d09
melvin-bot commentedon May 29, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #90760
melvin-bot commentedon May 29, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 29, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon May 29, 2026
Proposal
What is the root cause of that problem?
PR #90760 added two new subtitle variants for the invoice empty state and a branch in
EmptySearchView.tsxthat picks between them based onhasSeenTour:subtitleCannotSend→"You need a workspace with Invoices enabled to send invoices."subtitleCannotSendWithTestDrive→"You need a workspace with Invoices enabled to send invoices. Take a test drive of Expensify to learn more."In the QA repro, the tester logs in with a new account without a workspace:
userCanSendInvoice→false(no invoice-enabled workspace)hasSeenTour→false(new account)The selector at
EmptySearchView.tsx:337-343therefore falls into the second branch and renderssubtitleCannotSendWithTestDrive, which appends" Take a test drive of Expensify to learn more."after the expected sentence. That trailing sentence is the "extra text" the QA tester flagged — the PR description promised only"You need a workspace with Invoices enabled to send invoices."regardless of tour state.What changes do you think we should make in order to solve the problem?
When the user cannot send an invoice, always show the concise subtitle (
subtitleCannotSend) — the existing "Take a test drive" button is already the affordance for the tour, so re-stating it inside the subtitle is redundant and is exactly the "extra text" the bug reports.Concretely, in
src/pages/Search/EmptySearchView.tsx:!userCanSendInvoice && hasSeenTourand!userCanSendInvoicebranches into a single branch that usessubtitleCannotSend.subtitleCannotSendWithTestDrivekey from allsrc/languages/*.tsfiles added in PR Guard invoice empty state on canSendInvoice and fix money request back nav #90760 (en, de, es, fr, it, ja, nl, pl, pt-BR, zh-hans).This matches the QA expectation from the PR test plan and keeps the test-drive button visible for new users.
What alternative solutions did you explore?
Update the PR description and QA steps to acknowledge the
WithTestDrivevariant for users who have not seen the tour. This preserves the current implementation but doesn't fix the user-visible duplication between the subtitle copy and the test-drive button.Supporting evidence
PR #90760 file changes:
src/pages/Search/EmptySearchView.tsx— invoice case rewritten to pick subtitle based onuserCanSendInvoiceandhasSeenTour.src/languages/en.ts:7948-7949— both new subtitle strings.Repro state mapping:
canSendInvoice(allPolicies, login)returnsfalse.hasSeenTouris sourced fromONYXKEYS.NVP_ONBOARDINGviahasSeenTourSelectorand defaults tofalsefor a brand-new account.subtitleCannotSendWithTestDrive.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/92094)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
ahmedGaber93 commentedon May 29, 2026
@dangrous There was a mistake in the PR steps—the message is correct. We should close this.
dylanexpensify commentedon May 29, 2026
@ahmedGaber93 so we're good to close?
ahmedGaber93 commentedon May 29, 2026
@dylanexpensify Yes, we’re good to close.
dylanexpensify commentedon May 29, 2026
Great!